Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-09 Thread Benjamin Kosnik
> I'd like to know if my direction is ok. I can look into other issues > releated to this and fix them, but it doesn't make much sense if > separate build is not supported and can be easily broken in the > future. I like your direction here. > This patch is enough for 4.7 to have build working (

[v3] libstdc++/54314

2012-09-26 Thread Benjamin Kosnik
adds in exports for more vtable bits, as per bugzilla -benjamin tested x86/linux tested x86/linux --enable-symvers=gnu-versioned-namespace012-09-26 Benjamin Kosnik PR libstdc++/54314 * config/abi/pre/gnu.ver: Add vtable exports. * config/abi/pre/gnu-versioned

Re: [v3] libstdc++/54102

2012-08-28 Thread Benjamin Kosnik
> > ... finally got around to fixing up the generated HTML, so that > > charset is set to UTF-8. > > I regenerated doc/html and checked it in. Attached are the diffs. ... here using xhtml that will validate with W3c checkers. -benjamindiff --git a/libstdc++-v3/doc/Makefile.am b/libstdc++-v3/do

Re: [wwwdocs] Update coding conventions for C++

2012-06-26 Thread Benjamin Kosnik
> With that concern stated, I will write into the conventions whatever > concensus arises. > > Of course, I have no objection to an occasional inline cleanup. > That is, build with -Werror and adjusting inlines that have, > through the course of time, become larger than is useful. This seems to

Re: [wwwdocs] Update coding conventions for C++

2012-06-25 Thread Benjamin Kosnik
Hey Lawrence, thanks for this work and for keeping the public up-to-date with this gcc-patches posting. This looks pretty good to me. The only remaining issue for me is the fuzzyness/handwaving around inlining. I think the only way to really enforce "what can be inlined" is not to have people u

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-25 Thread Benjamin Kosnik
Hey hey! Looking good Dodji. Can't wait to use this stuff. > There are so many libstdc++ tests that were failing because of that > benign issue that I preferred to just run them with > -ftrack-macro-expansion diabled, after inspecting each of them to be > sure there was nothing more serious under

Re: [v3] libstdc++/52689 testcase

2012-04-25 Thread Benjamin Kosnik
s guys, of course it wasn't this simple. I see now that although this was not failing on my setup, it was coming in as unsupported to to my mis-use of the dg-require-target hook. Which was clearly not my intent... tested x86/linux -benjamin2012-04-25 Benjamin Kosnik PR libstdc++/52689 * t

Re: [v3] std::uninitialized_copy test

2012-04-17 Thread Benjamin Kosnik
> Definitely, thanks! The name of the new testcase seems a bit weird > (for the FSF branches): shall we maybe refer to the original (Fedora > or RHEL Bugzilla, I suppose) PR in a comment and then use either an > explicative name (our current practice) or just a small number for > the name of the t

Re: [v3] Update Solaris baselines for GCC 4.7, take 2

2012-03-01 Thread Benjamin Kosnik
> After PRs libstdc++/52188 and libstdc++/52189 have been resolved, I'd > finally like to update the Solaris baselines for the 4.7 release. > This time, everything looks good: only additions to GLIBCXX_3.4.1[67], > CXXABI_1.3.6, and CXXABI_TM_1, as expected. > > Bootstrapped without regressions o

Re: Unreviewed libstdc++/libgomp patch

2012-02-27 Thread Benjamin Kosnik
On Tue, 28 Feb 2012 00:12:33 +0100 Jakub Jelinek wrote: > and $(EGREP) -v '#(#| |$$)' just throws away the whole > };# Appended to version file. > line. I wonder if > sed -e 's/#[# $].*$//' > wouldn't be better, or alternative add ^ before the first # > in the egrep regex. Of course we can add

Re: v3 PATCH to include/bits/locale_facets.h to revert reordering of virtual functions

2012-02-23 Thread Benjamin Kosnik
Thanks Jason. -benjamin

Re: [v3] libstdc++/51798

2012-02-17 Thread Benjamin Kosnik
Noticed that the config for the new atomic builtins was not correct for targets that did not do link tests. (ie x86-x-cris-elf). Fixed as follows. tested x86/linux tested x86/linux x cris-elf -benjamin2012-02-17 Benjamin Kosnik PR libstdc++/51798 continued. * acinclude.m4

[v3] libstdc++/47058

2012-02-17 Thread Benjamin Kosnik
Adds support for disabling -Werror with --disable-werror configure flag. tested x86/linux --enable-maintainer-mode tested x86/linux --enable-maintainer-mode --disable-werror -benjamin2012-02-17 Benjamin Kosnik PR libstdc++/47058 * acinclude.m4 (GLIBCXX_ENABLE_WERROR): New

Re: obvious(?) typo in libstdc++-v3/src/c++98/locale.cc

2012-02-15 Thread Benjamin Kosnik
> The typo is obvious, but whether or not the wrapped code still works > isn't (to me). > > * src/c++98/locale.cc (locale::facet::_S_get_c_locale): Fix > typo. Please check this in. -benjamin

[v3] libstdc++/51368

2012-02-15 Thread Benjamin Kosnik
/pythoncommit 7087fa3c623191a70de5959ce23dbe004be61caf Author: bkoz Date: Wed Feb 15 11:33:24 2012 -0800 2012-02-15 Benjamin Kosnik PR libstdc++/51368 * acinclude.m4 (GLIBCXX_ENABLE_PYTHON): New. * configure.ac: Use it. * python/Makefile.am: Same. * configure

Re: [v3] libstdc++/51798

2012-02-13 Thread Benjamin Kosnik
rdless of the weak setting), so the initial read from *M > can be hoisted outside the loop. nice! > > Ok? cool, thanks for reviewing this. I fixed up the line numbers for the header file edits. -benjamin 2012-02-13 Benjamin Kosnik * testsuite/20_util/shared_ptr/cons/43820_neg.c

[v3] libstdc++/51798

2012-02-09 Thread Benjamin Kosnik
This is the rest of 51798, completing the conversion to C++11 atomics in libstdc++. This is now a complete transition, modulo documentation which I plan to finish as a separate patch once I am back from the ISO C++ meeting. tested x86_64/linux -benjamin 2012-02-09 Benjamin Kosnik

Re: [v3] Update C++11 status table.

2012-02-09 Thread Benjamin Kosnik
> * doc/xml/manual/documentation_hacking.xml: Fix invalid > attribute. > > Also committed to trunk. Tested with 'make doc-xml-validate-docbook > doc-html' Doh! Thanks for cleaning up after my late-night hacking. If you can, I'd appreciate you trying to generate the PDF doxygen manua

[v3] libstdc++/49445

2012-02-03 Thread Benjamin Kosnik
og @@ -1,5 +1,10 @@ 2012-02-03 Benjamin Kosnik + PR libstdc++/49445 + * testsuite/29_atomics/atomic/cons/49445.cc: Add. + +2012-02-03 Benjamin Kosnik + PR libstdc++/51811 * include/bits/atomic_base.h (atomic<_Tp*>): Fix offsets. * testsuite/29_atomics/atomic/operators/51811.cc: N

Re: [v3] libstdc++/51811

2012-02-03 Thread Benjamin Kosnik
> Different patch attached? Indeed, sorry. Here's the right one. -benjamin2012-02-03 Benjamin Kosnik PR libstdc++/51811 * include/bits/atomic_base.h (atomic<_Tp*>): Fix offsets. * testsuite/29_atomics/atomic/operators/51811.cc: New. * testsuite/29_

[v3] libstdc++/51811

2012-02-03 Thread Benjamin Kosnik
Fix-ups for atomic<_tp*> operators. Found some open issues with atomic that merit further study. tested x86/linux -benjamin2012-02-02 Benjamin Kosnik PR libstdc++/52068 * src/c++11/Makefile.am (toolexeclib_LTLIBRARIES, libc__11_la_SOURCES): Remove. * src

[v3] libstdc++/52068

2012-02-02 Thread Benjamin Kosnik
Remove install weirdness from 49829 fix. tested x86/linux -benjamin2012-02-02 Benjamin Kosnik PR libstdc++/52068 * src/c++11/Makefile.am (toolexeclib_LTLIBRARIES, libc__11_la_SOURCES): Remove. * src/c++11/Makefile.in: Regenerate. * src/c++98/Makefile.am

Re: [v3] libstdc++/49829

2012-01-26 Thread Benjamin Kosnik
> build step. As checked in. tested x86/linux -benjamin2012-01-27 Benjamin Kosnik Matthias Klose * configure.ac (GLIBCXX_ENABLE_DEBUG_FLAGS): Use -gdwarf-4 -g3 -O0. * configure.in: Regenerated. * src/Makefile.am (all-once, install-data-once): New rules. (all-local, install-

Re: [v3] libstdc++/49829

2012-01-24 Thread Benjamin Kosnik
> this breaks builds configured with --enable-libstdcxx-debug. confirmed > Tried > the following (not yet working) fix. OK. The attached is closer, but still not quite there. -benjamindiff --git a/libstdc++-v3/src/Makefile.am b/libstdc++-v3/src/Makefile.am index 87b2a16..59cc57d 100644 --- a

Re: [RFC] libstdc++ atomic_flag changes

2012-01-24 Thread Benjamin Kosnik
> The issue that I'm trying to solve is that we will have at least two > targets whose test-and-set insn does not define "set" as 1, as a > variable of type "bool" would expect. In the case of Sparc we > *could* make the test-and-set implementation test for any non-zero > value, but in the case o

Re: [v3] libstdc++/49829

2012-01-23 Thread Benjamin Kosnik
> tested x86-64/linux > tested x86-64/linux -x- arm-eabi > tested x86-64/linux -x- cris-elf Here is the missing bit, as tested above. -benjamindiff --git a/libstdc++-v3/src/Makefile.am b/libstdc++-v3/src/Makefile.am index aa25a7e..87b2a16 100644 --- a/libstdc++-v3/src/Makefile.am +++ b/libstdc+

[v3] libstdc++/49829

2012-01-23 Thread Benjamin Kosnik
This modularizes the libstdc++ sources such that the resulting library binaries are now composed of three convenience libraries. In short: libstdc++.[a, so] == libc++98 + libc++11 + libsupc++ Arguably, this is the way it should have been done all along. And certainly since the C++11 support hit

Re: Cross-build breakage with libstdc++-v3 doc changes

2012-01-18 Thread Benjamin Kosnik
problem when building a spu-elf > cross-compiler ... Testing this patch, will check it in if passes, sorry. -benjamin 2012-01-18 Benjamin Kosnik * configure.ac: Move epub checks... * acinclude (GLIBCXX_CONFIGURE_DOCBOOK): ...here, use test -f instead of AC_CHECK_FILES. diff --g

[v3] doc updates

2012-01-17 Thread Benjamin Kosnik
Regerate the html docs included in the source distribution. -benjamin 20120117-2.patch.bz2 Description: application/bzip

[v3] doc-epub rule updates

2012-01-17 Thread Benjamin Kosnik
This updates the support for generating epub docs to EPUB3. Using the EPUB3 stylesheets allows the removal of ruby and other tool checks from configure, and generates a much better documentation file. tested x86/linux -benjamin2012-01-17 Benjamin Kosnik * configure.ac (BUILD_EPUB

[v3] RFC libstdc++11convenience.la

2012-01-16 Thread Benjamin Kosnik
point, the continued ad hoc nature of src/Makefile.am's current approach will break down. At some other point, we might want to start building a libstdc++11 library with different flags from src/c++03. This is how to get there. tested x86/linux -benjamin2012-01-16 Benjamin Kosnik

Re: [v3] Link libstdc++ with -lpthread on IRIX 6 (PR target/47852)

2012-01-13 Thread Benjamin Kosnik
> 2011-02-25 Rainer Orth > > PR target/47852 > * configure.host (irix6.5*): Add -lpthread to OPT_LDFLAGS. > OK -benjamin

Re: [wwwdocs] gcc-4.7/porting_to.html

2012-01-13 Thread Benjamin Kosnik
> I went ahead and created a small patch with the changes above which > is the second patch below and committed it. If you'd like to see > some changes, just let me know. Thanks Gerald! This looks good. For the links, I just tried to add them where they'd been added before. Seems reasonable

Re: [wwwdocs] gcc-4.7/porting_to.html

2012-01-12 Thread Benjamin Kosnik
Here's the page with links, more validation fixes, and removal of the C item. best, Benjamin2012-01-12 Benjamin Kosnik * htdocs/gcc-4.7/porting_to.html: Fixup for validation. * htdocs/gcc-4.7/changes.html: Add link to porting_to.html. * htdocs/gcc-4.6/changes

Re: [wwwdocs] gcc-4.7/porting_to.html

2012-01-12 Thread Benjamin Kosnik
> > + Boolean type promotion changes > > + > > + > > + The C compiler no longer promotes boolean values in arithmetic > > + statements to integer values. Configure-related code that checks > > for > > + C99's may be impacted. If the following line is > > + newly present in configure

Re: [wwwdocs] gcc-4.7/porting_to.html

2012-01-11 Thread Benjamin Kosnik
> validation fixups... More of them -benjamin2012-01-11 Benjamin Kosnik * htdocs/gcc-4.7/porting_to.html: Fixup for validation. Index: htdocs/gcc-4.7/porting_to.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-

Re: [wwwdocs] gcc-4.7/porting_to.html

2012-01-11 Thread Benjamin Kosnik
validation fixups... -benjamin2012-01-11 Benjamin Kosnik * htdocs/gcc-4.7/porting_to.html: Fixup for validation. Index: htdocs/gcc-4.7/porting_to.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.7/porting_to.html,v

[wwwdocs] gcc-4.7/porting_to.html

2012-01-11 Thread Benjamin Kosnik
As requested by Jakub. I thought it better to get this in, warts and all, and have it be corrected than to dally around again and have it not checked in. -benjamin2012-01-11 Benjamin Kosnik * htdocs/gcc-4.7/porting_to.html: Add. Index: htdocs/gcc-4.7/porting_to.html

Re: [patch libstdc++]: Fix PR/51673

2012-01-09 Thread Benjamin Kosnik
operators signature for LLP64 size_t, and adjusted signatures for mt-allocator using size_t. 2012-01-09 Benjamin Kosnik PR libstc++/51673 part 1 * config/abi/pre/gnu-versioned-namespace.ver: Sync cxxabi symbols with gnu.ver. diff --git a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver b

[wwwdocs] correct libstdc++ links

2012-01-09 Thread Benjamin Kosnik
Correct libstdc++ naming convention to be the same as used by the other html tarballs, ie library-html.tar.bz2. I just checked this in as I was fixing the recent gcc mailing list report of broken links. -benjamin2012-01-09 Benjamin Kosnik * onlinedocs/index.html: Use same naming

[v3] add -Wabi to build flags

2012-01-09 Thread Benjamin Kosnik
y will impact a lot of code. tested x86/linux -benjamin2012-01-09 Benjamin Kosnik * fragment.am (WARN_CXXFLAGS): Add -Wabi. * Makefile.in: Regenerate. * doc/Makefile.in: Same. * include/Makefile.in: Same. * libsupc++/Makefile.in: Same. * src/Makefile.in: Same.

[v3] eh_tm fixup atomic bulitin

2011-12-19 Thread Benjamin Kosnik
Remove use of _GLIBCXX__ATOMIC_BUILTINS_4 as it's no longer ever defined... Also, random fixup for "make check-performance." tested x86/linux -benjamin2011-12-19 Benjamin Kosnik * testsuite/performance/25_algorithms/search_n.cc: Disambiguate local variab

[v3] fix num_put/.../9780-2 for recent glibcs

2011-12-15 Thread Benjamin Kosnik
x f16 -- glibc 2.14.90-212011-12-15 Benjamin Kosnik * testsuite/22_locale/num_put/put/char/9780-2.cc: Add test for "C" locale, add sanity checks in case of grouping. diff --git a/libstdc++-v3/testsuite/22_locale/num_put/put/char/9780-2.cc b/libstdc++-v3/testsuite/2

Re: [v3] doxygen warnings

2011-12-12 Thread Benjamin Kosnik
> > This patch just removes/restructures some of the doxygen markup to > > avoid warnings when generating the documentation. Most of the > > libstdc++ headers are pretty doxygen clean now. > > By the way, I recently made this feature request for Doxygen: > > https://bugzilla.gnome.org/show_bug.c

Re: [v3] RFC: rename __calculate_memory_order

2011-12-07 Thread Benjamin Kosnik
> * include/bits/atomic_base.h (__calculate_memory_order): > Rename to... (__cmpexch_failure_order): This, and rewrite as > constexpr function. (compare_exchange_strong, compare_exchange_weak): > Use it. > * include/std/atomic (compare_exchange_strong, > compare_exchange_weak): Lik

Re: [PATCH] Re: [v3] updated atomic configury

2011-11-30 Thread Benjamin Kosnik
Thanks Andrew. Here's the updated patch, as checked in. This removes one level of cruft WRT atomic configure-ness (leaving us with the most primordial...). tested x86/linux tested x86/linux x arm-eabi tested x86/linux x cris-elf -benjamin 2011-11-30 Benjamin Kosnik * acinclu

[v3] updated atomic configury

2011-11-21 Thread Benjamin Kosnik
es, cool, yeah! #endif But this doesn't seem to work. And what I have in this patch, which is #if defined(ATOMIC_INT_LOCK_FREE) doesn't really say the same thing... -benjamin tested x86/linux tested x86/linux x cris-elf tested x86/linux x arm-eabi-elf2011-11-21 Benjamin Kosnik

Re: PATCH for to use tree clobbers for c++/51060 (temporary re-use)

2011-11-15 Thread Benjamin Kosnik
> Now that we have a way of explicitly marking a variable as dead, we > can use that to indicate the end of a temporary's lifetime by adding > it as a cleanup for that temporary. Since gimple_push_cleanup still > deals in trees I needed to tweak a couple of places to avoid trying > to treat a clo

Re: cxx-mem-model merge [6 of 9] - libstdc++-v3

2011-11-11 Thread Benjamin Kosnik
> > I just realized I may be feeding you an inconsistent > > configuration, see the atomicity stuff in > > libstdc++-v3/config/cpu/cris. Is that just obsolete and unused > > now or what do I need to add for that to work? > > > > You don't need to do anything there. I think that atomicity stuff >

Re: [v3] doxygen markup for tr2

2011-11-04 Thread Benjamin Kosnik
One more buglet -benjamin2011-11-04 Benjamin Kosnik * scripts/run_doxygen: Fix sed quoting. diff --git a/libstdc++-v3/scripts/run_doxygen b/libstdc++-v3/scripts/run_doxygen index 3fef95f..7b601bc 100644 --- a/libstdc++-v3/scripts/run_doxygen +++ b/libstdc++-v3/scripts/run_doxygen @@ -261,7

[v3] doxygen markup for tr2

2011-11-03 Thread Benjamin Kosnik
Some doxygen markup tweaks to get the tr2 components to show up. Also, I've regenerated doc/html. tested x86/linux -benjamin 2011-11-03 Benjamin Kosnik * doc/doxygen/doxygroups.cc: Add markup for namespace tr2. * include/tr2/bool_set: Adjust doxygen markup. * include/tr2/dynamic_b

[v3] tr2 missing bits

2011-11-01 Thread Benjamin Kosnik
Ooops, noticed some minor bits when I was regenerating the docs. Some of the TR2 man pages needed munging, and the c++config bits for versioning TR2 needed to go in. tested x86/linux best, benjamin 2011-11-02 Benjamin Kosnik * include/bits/c++config: Add tr2 to versioned namespaces

[v3] tr2: bool_set, dynamic_bitset, ratio

2011-10-19 Thread Benjamin Kosnik
Hi Edward! I have reviewed and selectively merged your development branch, libstdcxx-tr2-ideas-branch, into trunk. As ISO C++ is now looking at new library efforts for TR2 (and N2965 has already been checked in to trunk) I thought it well-timed. Please check my work, patch attached. On libst

Re: Intrinsics for N2965: Type traits and base classes

2011-10-19 Thread Benjamin Kosnik
> Please post a ChangeLog entry with a patch. Someone added one for > you: > > 2011-10-17 Michael Spertus > > * gcc/c-family/c-common.c (c_common_reswords): Add __bases, > __direct_bases. > * gcc/c-family/c-common.h: Add RID_BASES and RID_DIRECT_BASES. > > but it is in the

Re: Intrinsics for N2965: Type traits and base classes

2011-10-17 Thread Benjamin Kosnik
B, E {}; + +int main() { + assert_same_type::type, types>(); + assert_same_type::type, types>(); + assert_same_type::type, types<>>(); + return 0; +} diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index e8a621a..3baca8c 100644 --- a/libstdc++-v3/ChangeLog +++

Re: [v3] Remove duplicate symbol in gnu.ver (PR bootstrap/50715)

2011-10-17 Thread Benjamin Kosnik
Agh. Sorry about this Rainer. Thanks for the patch. -benjamin

Re: [wwwdocs] gcc-4.6/porting_to.html

2011-10-11 Thread Benjamin Kosnik
> I realized this one hasn't made it in, but is really nice. I made a > number of minor edits (typos, markup, simplifying headings,... among > others). What do you think -- should we include this? > > Many users still won't have GCC 4.6 deployed yet, so I think it's > still worth it. > > Wha

Re: Intrinsics for N2965: Type traits and base classes

2011-10-10 Thread Benjamin Kosnik
This is looking pretty good, from the libstdc++ side. This latest round of gcc hacking fixes the previous testsuite fixes, so once you get the gcc bits OK'd by Jason you can check in. > I'd still like to see some testcases for the intrinsic, independent > of the library. Seems like some simple t

Re: [v3] cxxabi.h vs. unwind-cxx.h

2011-10-10 Thread Benjamin Kosnik
Here's a patch that works for both C and C++. tested x86/linux -benjamin 2011-10-10 Benjamin Kosnik PR libstdc++/49818 * config/abi/pre/gnu.ver (CXXABI_1.3.6): Add symbols. * testsuite/util/testsuite_abi.cc: Same. * libsupc++/unwind-cxx.h: Move required eh API... * libsupc++/cxx

[v3] cxxabi.h vs. unwind-cxx.h

2011-10-06 Thread Benjamin Kosnik
10-06 Benjamin Kosnik PR libstdc++/49818 * config/abi/pre/gnu.ver (CXXABI_1.3.6): Add symbols. * testsuite/util/testsuite_abi.cc: Same. * libsupc++/unwind-cxx.h: Move required eh API... * libsupc++/cxxabi.h: ... to here. Add required forward declarations. * libsupc++/pu

Re: [v3] versioned-namespaces spelling/soname change

2011-10-06 Thread Benjamin Kosnik
> ... I went ahead and reverted the change, wasn't documented anywhere, > definitely unintended. Thanks -benjamin

Re: [v3] use NSDMI in C++11 mutex types

2011-10-06 Thread Benjamin Kosnik
> Does anyone have any comments or objections to going in this > direction? If the new base classes aren't OK the NSDMI syntax could > still be used, just without refactoring to remove the code > duplication. I like where you are going here. This looks good to me. -benjamin

Re: [v3] versioned-namespaces spelling/soname change

2011-10-05 Thread Benjamin Kosnik
> I'm going to let this chill a bit on mainline and then check in to > 4.6.x. Seems fine so I dropped this into the 4_6-branch tested x86/linux -benjamin 2011-10-05 Benjamin Kosnik PR libstdc++/48698 * acinclude.m4 (GLIBCXX_ENABLE_SYMVERS): Set libtool_V

Re: Intrinsics for N2965: Type traits and base classes

2011-10-03 Thread Benjamin Kosnik
> Hey! Here is a preliminary test suite. Just the basics on this one. > There's a bit of an issue with fundamental types, ICEs, but seems > fixable. here's the pre-processed sources for the ICE -benjamin ice-reflection-1.ii.bz2 Description: application/bzip

Re: Intrinsics for N2965: Type traits and base classes

2011-10-03 Thread Benjamin Kosnik
> OK. Here is a new diff that hopefully takes into account all of > Jason's and Benjamin's comments. Benjamin's TR2 build patch is not > repeated (or tested!) here. Benjamin, I'd really appreciate if you > wouldn't mind confirming I handled that correctly in tr2/type_traits > (Including the inclus

Re: Intrinsics for N2965: Type traits and base classes

2011-09-29 Thread Benjamin Kosnik
> OK. Here are some simple benchmarks. I simulated heavy use of > reflection with 1000 classes that each had about a thousand base > classes. I also created a super-simple typelist class > > template struct typelist {}; // Variadic templates rock > > If bases returns a typelist, the program take

Re: Intrinsics for N2965: Type traits and base classes

2011-09-27 Thread Benjamin Kosnik
Oops, this is the right patch. -benjamindiff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index a59a0b6..e1176ee 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,5 +1,14 @@ 2011-09-27 Benjamin Kosnik + * doc/Makefile.am: Add tr2 support. + * doc

Re: Intrinsics for N2965: Type traits and base classes

2011-09-27 Thread Benjamin Kosnik
best, benjamindiff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index a59a0b6..e1176ee 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,5 +1,14 @@ 2011-09-27 Benjamin Kosnik + * doc/Makefile.am: Add tr2 support. + * doc/Makefile.in: Regenerate. + +2011-

[v3] versioned-namespaces spelling/soname change

2011-09-26 Thread Benjamin Kosnik
-namespace2011-09-26 Benjamin Kosnik PR libstdc++/48698 * acinclude.m4 (GLIBCXX_ENABLE_SYMVERS): Set libtool_VERSION here. * configure.ac: Move AC_SUBST of libtool_VERSION past call to GLIBCXX_ENABLE_SYMVERS. * configure: Regenerate. * include/bits/c++config: Use __7 as versioned namespace nam

[v3] doc-epub

2011-09-21 Thread Benjamin Kosnik
Fix for image directory location. The generated epub is ok, but missing images. There's another tool that may be used to generate epubs, called db2epub.py, but it isn't cooperating. So we will stick with the status quo for now. -benjamin2011-09-21 Benjamin Kosnik ${manual_xml};

Re: [v3] tuple round 2

2011-09-07 Thread Benjamin Kosnik
> 2011-08-03 Benjamin Kosnik > François Dumont > > * testsuite/23_containers/array/at_neg.cc: Move... > * testsuite/23_containers/array/at.cc: ...here. Remove > -fno-exceptions, call const at member function. I've reverted the name change. -benjamin

[v3] constexpr tuple

2011-09-06 Thread Benjamin Kosnik
jamin2011-09-06 Benjamin Kosnik * include/std/tuple (_Tuple_impl::_M_head, _M_tail): Mark constexpr. (tuple(tuple&&)): Same. (tuple(const tuple<_UElements...>& __in)): Same. (tuple(tuple<_UElements...>&& __in)): Same. (tuple_cat(const tuple<_TElements

Re: RFC: add a testsuite for libstdc++ pretty-printers

2011-08-24 Thread Benjamin Kosnik
> Any comments on this? > > I'd like to get it in; Phil found a bug in the std::tuple printer, and > it would be nice to put in a test case along with the fix. Hey Tom (and Phil!). Sorry for the delay: this looks fine. Please put it in on trunk and enjoy your vacation! -benjamin

Re: [v3] doxygen markup fixes

2011-08-08 Thread Benjamin Kosnik
> > +/** @file bits/alloc_traits.h > > + *  This is an internal header file, included by other library > > headers. > > + *  Do not attempt to use it directly. > > @headername{scoped_allocator} > > + */ > > + > > > > The correct header for allocator_traits is Ack. Thanks for the review. Kind of

[v3] docbook vs. images

2011-08-04 Thread Benjamin Kosnik
This fixes the docbook html output with respect to images. Now, filerefs for PNG data are relative to the html install directory, and an images directory is copied and populated so that the links match PNG files. tested x86/linux -benjamin2011-08-04 Benjamin Kosnik * doc/xml/manual

[v3] check-performance compile fail cleanup

2011-08-03 Thread Benjamin Kosnik
These tests recently started failing at compile time for me due to no declarations for unlink due to no include of unistd.h. So, I did the obvious thing and included it. tested x86/linux -benjamin2011-08-03 Benjamin Kosnik * testsuite/performance/27_io/filebuf_sputn_unbuf.cc: Include

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-03 Thread Benjamin Kosnik
> +++ b/libstdc++-v3/acinclude.m4 > @@ -685,9 +685,9 @@ AC_DEFUN([GLIBCXX_EXPORT_INCLUDES], [ >fi > ># Stuff in the actual top level. Currently only used by libsupc++ > to > - # get unwind* headers from the gcc dir. > - #TOPLEVEL_INCLUDES='-I$(toplevel_srcdir)/gcc > -I$(toplevel_srcdi

[v3] tuple round 2

2011-08-03 Thread Benjamin Kosnik
Hey this fixes up the array::at issue as pointed out on this list. In addition, it adds some more tuple markup for constexpr. I'm going to stage in the tuple work, as some of it is more controversial. tested x86/linux -benjamin2011-08-03 Benjamin Kosnik * include/std/tuple: Mark

[v3] docbook biblioid/imagedata markup fixes

2011-07-29 Thread Benjamin Kosnik
As noted earlier today, this removes various warnings when processing doc/xml/* files. tested x86/linux -benjamin2011-07-29 Benjamin Kosnik * doc/xml/manual/build_hacking.xml: Markup imagedata changes. * doc/xml/manual/policy_data_structures.xml: Same. * doc/xml/class.txml: Remove

[v3] constexpr pair additions

2011-07-22 Thread Benjamin Kosnik
Add constexpr markup to move/forward, and enable more std::pair constructors. tested x86/linux -benjamin2011-07-22 Benjamin Kosnik Daniel Krugler * include/bits/move.h (move, forward): Mark constexpr. * include/bits/stl_pair.h (pair): Mark move ctors constexpr. * testsuite

[v3] testsuite renames

2011-07-21 Thread Benjamin Kosnik
Some shortened pathnames from doc cleanup branch. tested x86/linux -benjamin2011-07-21 Benjamin Kosnik * testsuite/ext/pb_ds/regression/tree_no_data_map_rand.cc: Move... * testsuite/ext/pb_ds/regression/tree_set_rand.cc: ... here. * testsuite/ext/pb_ds/regression

[v3] constexpr array additions

2011-07-20 Thread Benjamin Kosnik
rator []! tested x86/linux -benjamin2011-07-20 Benjamin Kosnik Daniel Krugler * include/std/array (array::at, array::operator[]): Mark constexpr. * testsuite/23_containers/array/requirements/ constexpr_element_access.cc: Add. Index: include/std/

[v3] constexpr time_point additions

2011-07-20 Thread Benjamin Kosnik
This updates to N3291, and adds constexpr to time_point nonmember arithmetic operations, as pointed out to me in private email by Daniel Krugler. Indeed, they can become constant expressions: thanks! These additions are on top of N3229. tested x86/linux -benjamin2011-07-20 Benjamin Kosnik

Re: Remove NetWare support

2011-07-20 Thread Benjamin Kosnik
> diff --git a/libstdc++-v3/crossconfig.m4 b/libstdc++-v3/crossconfig.m4 > --- a/libstdc++-v3/crossconfig.m4 > +++ b/libstdc++-v3/crossconfig.m4 > @@ -173,14 +173,6 @@ case "${host}" in >AC_DEFINE(HAVE_ISNANL) > fi > ;; > - *-netware) > -SECTION_FLAGS='-ffunction-sections -f

[v3] constexpr n3291 missing bits

2011-07-19 Thread Benjamin Kosnik
While reviewing the state of gcc constexpr vs. ISO C++, I noticed that the bitset access operator was missing, so I added it thusly. Like ice cream on a hot summer day, the expanded constexpr diagnostics do not disappoint. Thanks Jason! An example: testsuite/23_containers/bitset/operations/cons

Re: [PATCH][libstdc++] Also install cxxabi_tweaks.h in freestanding mode.

2011-04-28 Thread Benjamin Kosnik
> 2011-04-27 Doug Kwan > > * include/Makefile.am (install-freestanding-headers): Also > install cxxabi_tweaks.h. > * include/Makefile.in: Regnerate. OK for trunk and 4.6 -benjamin

Re: [google] Install cpu_defines.h (issue4440044)

2011-04-19 Thread Benjamin Kosnik
> This patch adds cpu_defines.h to the set of files to be installed. > Doug, could you describe why we need to do this? Will you be > submitting this patch for trunk? It's already in trunk, see 2011-03-15 Doug Kwan PR libstdc++/48123 * include/Makefile.am (install-freestandi

Re: [wwdocs] add libstdc++ docs for 4.6.0

2011-04-06 Thread Benjamin Kosnik
> I ended up fiddling a bit with permissions and such, but everything > should be in place now and I also committed the web patch on your > behalf. Thanks! This pleases me a great deal. > Testing the links, there is one thing does does not work, and where > I was not sure how to address it: Th

[wwdocs] add libstdc++ docs for 4.6.0

2011-04-05 Thread Benjamin Kosnik
bstdc++ into /sourceware/www/gcc/htdocs/onlinedocs/gcc-4.6.0 best, benjamin2011-04-05 Benjamin Kosnik * htdocs/onlinedocs/index.html: Add libstdc++ documentation for 4.6.0. Index: htdocs/onlinedocs/index.html === RCS file:

Re: [v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-23 Thread Benjamin Kosnik
> 2011-03-15 Rainer Orth > > * config/abi/post/solaris2.8/baseline_symbols.txt: Regenerate. > * config/abi/post/solaris2.8/sparcv9/baseline_symbols.txt: > Likewise. > * config/abi/post/solaris2.10/baseline_symbols.txt: Likewise. > * config/abi/post/solaris2.10/amd64/bas

Re: [PATCH] sparc and alpha baseline_symbols.txt update

2011-03-23 Thread Benjamin Kosnik
> 2011-03-22 Matthias Klose > > * config/abi/post/sparc-linux-gnu/baseline_symbols.txt: > Regenerated. > > 2011-03-22 Uros Bizjak > > * config/abi/post/alpha-linux-gnu/baseline_symbols.txt: > Regenerated. Yay. Jakub I'm deferring to you on this, your analysis seems sound. The

Re: [Patch] [libstdc++] [C++0x] Export std::string base object move constructor.

2011-03-22 Thread Benjamin Kosnik
> Here is updated patch with testcases, tested with unpatched libstdc++ > where it failed to link and patched where it succeeded. > The testcases are copies of corresponding moveable.cc tests, just > using the new class inheriting from std::basic_string resp. > std::basic_string and with -fno-inli

Re: [Patch] [libstdc++] [C++0x] Export std::string base object move constructor.

2011-03-22 Thread Benjamin Kosnik
Thanks for reporting this issue Adam. Don't hesitate to file bug reports in gcc bugzilla category libstdc++ when you find problems like this in the future! > So, if Benjamin or other libstdc++ maintainers want it fixed for > 4.6, you want a patch like attached, plus some testcases for both > std:

Re: [PATCH] libstdc++ ABI issues with __int128

2011-03-21 Thread Benjamin Kosnik
> Well, such stricter checking wouldn't be completely painless, e.g. currently > both current baseline_symbols.txt and the ones I've posted don't include the > two TLS: lines, because of the fear that not everyone has TLS enabled. > If baseline_symbols.txt right now miss some symbols, it is not a b

Re: [PATCH] libstdc++ ABI issues with __int128

2011-03-21 Thread Benjamin Kosnik
> Most of the linux targets are actually __GXX_TYPEINFO_EQUALITY_INLINE 1 > and thus perhaps if we want to maintain some ABI compatibility with 3.4-ish > inlined typeid comparisons, we might need to export _ZTS* for _ZTI* > that could somehow be emitted for user code too. Right, for C++98 types.

Re: [PATCH] libstdc++ ABI issues with __int128

2011-03-21 Thread Benjamin Kosnik
> The problem is that abicheck only flags as incompatible additions to > GLIBCXX_3.4, but not other base versions.  Ideally it would flag addition > to any version that hasn't been added (addition of the version is flagged > by > OBJECT:0:CXXABI_1.3.5 > etc. entries (no @s in it). > This patch for

Re: [PATCH] libstdc++ ABI issues with __int128

2011-03-19 Thread Benjamin Kosnik
2011-03-19 Jakub Jelinek * config/abi/pre/gnu.ver (CXXABI_1.3): Don't export _ZT[IS][PK]*[no]. (CXXABI_1.3.5): Export _ZTI[PK]*[no]. This looks good to me, nice catch. I'll figure out what happened with check_abi when I'm back, conductivity-wise. And: > And another question i

[wwwdocs] gcc-4.6/porting_to.html

2011-03-16 Thread Benjamin Kosnik
Needs some more work, here's a rough draft. -benjaminIndex: htdocs/gcc-4.6/porting_to.html === RCS file: htdocs/gcc-4.6/porting_to.html diff -N htdocs/gcc-4.6/porting_to.html *** /dev/null 1 Jan 1970 00:00:00 - --- htdocs/gcc-4.6

Re: [v3] typeinfo tuning

2011-03-16 Thread Benjamin Kosnik
(revision 0) +++ testsuite/19_diagnostics/stdexcept.cc (revision 0) @@ -0,0 +1,228 @@ +// 2011-03-16 Benjamin Kosnik + +// Copyright (C) 2011 +// Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/

Re: [v3] typeinfo tuning

2011-03-15 Thread Benjamin Kosnik
Like so. -benjamin2011-03-15 Benjamin Kosnik * include/std/thread: Revert. * src/thread.cc: Same. * config/abi/pre/gnu.ver: Same. Index: src/thread.cc === --- src/thread.cc (revision 171019) +++ src/thread.cc (working copy

  1   2   >