Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

2020-04-03 Thread Egeyar Bagcioglu via Gcc-patches
On 3/18/20 10:05 AM, Martin Liška wrote: On 3/17/20 7:43 PM, Egeyar Bagcioglu wrote: Hi Martin, I like the patch. It definitely serves our purposes at Oracle and provides another way to do what my previous patches did as well. 1) It keeps the backwards compatibility regarding -frecord

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

2020-03-17 Thread Egeyar Bagcioglu via Gcc-patches
Hi Martin, I like the patch. It definitely serves our purposes at Oracle and provides another way to do what my previous patches did as well. 1) It keeps the backwards compatibility regarding -frecord-gcc-switches; therefore, removes my related doubts about your previous patch. 2) It still

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-05 Thread Egeyar Bagcioglu
On 3/5/20 8:36 AM, Richard Biener wrote: On Wed, Mar 4, 2020 at 5:28 PM Egeyar Bagcioglu wrote: On 3/4/20 1:18 AM, Fangrui Song wrote: On 2020-03-03, Joseph Myers wrote: On Tue, 3 Mar 2020, Egeyar Bagcioglu wrote: Although we discussed after the submission of the first version

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-05 Thread Egeyar Bagcioglu
I'm sending the updated patch based on Egeyar's work. It utilizes a new environmental variable and uses the currently existing -frecord-gcc-switches option. Thoughts? I am leaving it to the more experienced to comment on redefining the functionality of -frecord-gcc-switches. The code

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 6:33 PM, Jakub Jelinek wrote: On Wed, Mar 04, 2020 at 06:23:10PM +0100, Martin Liška wrote: On 3/4/20 4:25 PM, Egeyar Bagcioglu wrote: Thanks Richard. I do not have write-access to the GCC repo. I'd be glad if someone commits it  for me. Can we please wait? I'm really convinced

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 6:23 PM, Martin Liška wrote: On 3/4/20 4:25 PM, Egeyar Bagcioglu wrote: Thanks Richard. I do not have write-access to the GCC repo. I'd be glad if someone commits it for me. Can we please wait? I'm really convinced we do not want one another very similar functionality. I am

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 5:28 PM, Egeyar Bagcioglu wrote: On 3/4/20 1:18 AM, Fangrui Song wrote: On 2020-03-03, Joseph Myers wrote: On Tue, 3 Mar 2020, Egeyar Bagcioglu wrote: Although we discussed after the submission of the first version that there are several other options performing similar tasks

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 1:18 AM, Fangrui Song wrote: On 2020-03-03, Joseph Myers wrote: On Tue, 3 Mar 2020, Egeyar Bagcioglu wrote: Although we discussed after the submission of the first version that there are several other options performing similar tasks, I believe we established that there is still

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 4:34 PM, Andreas Schwab wrote: On Mär 04 2020, Richard Biener wrote: --record-gcc-command-line is not a FSF GCC option, there's -frecord-gcc-switches though which --record-gcc-command-line is translated to -frecord-gcc-switches by the driver. That happens for all double-dash

Re: [PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-04 Thread Egeyar Bagcioglu
On 3/4/20 10:00 AM, Richard Biener wrote: On Tue, Mar 3, 2020 at 5:41 PM Egeyar Bagcioglu wrote: This patch is for .GCC.command.line sections in LTO objects to be copied into the final objects as in the following example: [egeyar@localhost lto]$ gcc -flto -O3 demo.c -c -g --record-gcc

Re: [PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-03 Thread Egeyar Bagcioglu
On 3/3/20 3:44 PM, Egeyar Bagcioglu wrote: In addition to the new test case, I built binutils as my test case after passing this option to CFLAGS. The added .GCC.command.line section of ld.bfd listed many compile commands as expected. Tested on x86_64-pc-linux-gnu. As mentioned above, I

[PATCH v2 1/3] Introduce dg-require-target-object-format

2020-03-03 Thread Egeyar Bagcioglu
gcc/testsuite/: 2020-02-27 Egeyar Bagcioglu * lib/target-supports-dg.exp (dg-require-target-object-format): New. --- gcc/testsuite/lib/target-supports-dg.exp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/gcc/testsuite/lib/target-supports-dg.exp b/gcc/testsuite/lib

[PATCH v2 2/3] Introduce the gcc option --record-gcc-command-line

2020-03-03 Thread Egeyar Bagcioglu
gcc: 2020-02-27 Egeyar Bagcioglu * common.opt (--record-gcc-command-line): New option. * config/elfos.h (TARGET_ASM_RECORD_GCC_COMMAND_LINE): Define as elf_record_gcc_command_line. * doc/tm.texi: Regenerate. * doc/tm.texi.in

[PATCH v2 0/3] Introduce a new GCC option, --record-gcc-command-line

2020-03-03 Thread Egeyar Bagcioglu
.GCC.command.line section of ld.bfd listed many compile commands as expected. Tested on x86_64-pc-linux-gnu. Please review the patches, let me know what you think and apply if appropriate. Regards Egeyar Egeyar Bagcioglu (3): Introduce dg-require-target-object-format Introduce the gcc

[PATCH v2 3/3] Keep .GCC.command.line sections of LTO objetcs.

2020-03-03 Thread Egeyar Bagcioglu
) : gcc -flto -O2 demo2.c -c -g --record-gcc-command-line -DFORTIFY=2 Regards Egeyar libiberty: 2020-02-27 Egeyar Bagcioglu * simple-object.c (handle_lto_debug_sections): Name ".GCC.command.line" among debug sections to be copied over from lto objects. --- libibe

Re: [PATCH 1/2] Introduce dg-require-target-object-format

2019-11-18 Thread Egeyar Bagcioglu
On 11/14/19 3:51 AM, Hans-Peter Nilsson wrote: On Thu, 7 Nov 2019, Egeyar Bagcioglu wrote: On 11/7/19 8:47 AM, Segher Boessenkool wrote: On Wed, Nov 06, 2019 at 06:21:33PM +0100, Egeyar Bagcioglu wrote: +proc dg-require-target-object-format { args } { +if { [gcc_target_object_format

Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

2019-11-18 Thread Egeyar Bagcioglu
On 11/13/19 10:37 AM, Martin Liška wrote: On 11/7/19 3:50 PM, Egeyar Bagcioglu wrote: On 11/7/19 10:24 AM, Martin Liška wrote: On 11/6/19 6:21 PM, Egeyar Bagcioglu wrote: Hello, Hello. Thanks for your detailed reply Martin. You'll find my reply inline. Since you added Nick Clifton

Re: [PATCH 2/2] Introduce the gcc option --record-gcc-command-line

2019-11-07 Thread Egeyar Bagcioglu
On 11/7/19 7:57 PM, Segher Boessenkool wrote: Hi! On Thu, Nov 07, 2019 at 06:44:17PM +0100, Egeyar Bagcioglu wrote: On 11/7/19 9:03 AM, Segher Boessenkool wrote: + ASM_OUTPUT_ASCII(asm_out_file, cmdline, cmdline_length); +} + cmdline[0] = 0; + ASM_OUTPUT_ASCII(asm_out_file

Re: [PATCH 2/2] Introduce the gcc option --record-gcc-command-line

2019-11-07 Thread Egeyar Bagcioglu
Hello again Segher! On 11/7/19 9:03 AM, Segher Boessenkool wrote: Hi! On Wed, Nov 06, 2019 at 06:21:34PM +0100, Egeyar Bagcioglu wrote: +static const char * +record_gcc_command_line_spec_function(int argc ATTRIBUTE_UNUSED, const char **argv) +{ + const char *filename = argv[0]; + FILE *out

Re: [PATCH 1/2] Introduce dg-require-target-object-format

2019-11-07 Thread Egeyar Bagcioglu
On 11/7/19 6:17 PM, jose.march...@oracle.com wrote: On 11/7/19 8:47 AM, Segher Boessenkool wrote: > Hi! > > On Wed, Nov 06, 2019 at 06:21:33PM +0100, Egeyar Bagcioglu wrote: >> gcc/testsuite/ChangeLog: >> 2019-11

Re: [PATCH 1/2] Introduce dg-require-target-object-format

2019-11-07 Thread Egeyar Bagcioglu
Hi Segher! On 11/7/19 8:47 AM, Segher Boessenkool wrote: Hi! On Wed, Nov 06, 2019 at 06:21:33PM +0100, Egeyar Bagcioglu wrote: gcc/testsuite/ChangeLog: 2019-11-06 Egeyar Bagcioglu * lib/target-supports-dg.exp: Define dg-require-target-object-format. * lib/target-supports-dg.exp

Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

2019-11-07 Thread Egeyar Bagcioglu
On 11/7/19 4:13 PM, Nick Clifton wrote: Hi Egeyar, Thanks for including me in this discussion. This option is similar to -frecord-gcc-switches. For the record I will also note that there is -fverbose-asm which does almost the same thing, but only records the options as comments in the

Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

2019-11-07 Thread Egeyar Bagcioglu
On 11/7/19 10:24 AM, Martin Liška wrote: On 11/6/19 6:21 PM, Egeyar Bagcioglu wrote: Hello, Hello. Thanks for your detailed reply Martin. You'll find my reply inline. Since you added Nick Clifton to your following reply, I am adding him to this email too. He is not only the author

[PATCH 2/2] Introduce the gcc option --record-gcc-command-line

2019-11-06 Thread Egeyar Bagcioglu
gcc/ChangeLog: 2019-10-21 Egeyar Bagcioglu * common.opt (--record-gcc-command-line): New option. * config/elfos.h (TARGET_ASM_RECORD_GCC_COMMAND_LINE): Define as elf_record_gcc_command_line. * doc/tm.texi: Regenerate. * doc/tm.texi.in

[PATCH 1/2] Introduce dg-require-target-object-format

2019-11-06 Thread Egeyar Bagcioglu
gcc/testsuite/ChangeLog: 2019-11-06 Egeyar Bagcioglu * lib/target-supports-dg.exp: Define dg-require-target-object-format. --- gcc/testsuite/lib/target-supports-dg.exp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/gcc/testsuite/lib/target-supports-dg.exp b/gcc

[PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

2019-11-06 Thread Egeyar Bagcioglu
compile commands as expected. Tested on x86_64-pc-linux-gnu. Please review the patches, let me know what you think and apply if appropriate. Regards Egeyar Egeyar Bagcioglu (2): Introduce dg-require-target-object-format Introduce the gcc option --record-gcc-command-line gcc/common.opt

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-27 Thread Egeyar Bagcioglu
On 10/26/2017 05:03 PM, Jeff Law wrote: On 10/18/2017 10:59 AM, Egeyar Bagcioglu wrote: Hello, Test case "guality.exp=nrv-1.c" fails on aarch64. Optimizations reorder the instructions and cause the value of a variable to be checked before its first assignment. The following patch

Re: [PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-24 Thread Egeyar Bagcioglu
On 10/20/2017 03:13 PM, Richard Earnshaw (lists) wrote: On 19/10/17 09:14, Richard Biener wrote: I guess Alex work on stmt frontiers will fix this instance? Thank you all for the reviews. I fetched Alex's branches in gcc (aoliva/SFN) and in binutils (users/aoliva/SFN). Using gcc and binutils

[PATCH] Fix nrv-1.c false failure on aarch64.

2017-10-18 Thread Egeyar Bagcioglu
reak point is reached after the assignment instruction is executed. Please review the patch and apply if legitimate. Egeyar >From a11fe0b1fcf1867a0fa8c4627e347bda07a4c61b Mon Sep 17 00:00:00 2001 From: Egeyar Bagcioglu <egeyar.bagcio...@oracle.com> Date: Thu, 12 Oct 2017 06:16:30 -0700 S