Re: [PATCH] Make Warray-bounds alias to Warray-bounds= [PR107787]

2022-11-24 Thread Franz Sirl
ttached my patch, feel free to integrate the testsuite changes. Franz From 9bfefe2082f55f2ad2cd19beedbfeaf9bd20fb4a Mon Sep 17 00:00:00 2001 From: Franz Sirl Date: Thu, 8 Jul 2021 10:25:00 +0200 Subject: [PATCH 08/11] Unify -Warray-bounds/-Warray-bounds= warning variables. --- gcc/b

Re: [RFA] Minor improvement to coremark, avoid unconditional jump to return

2022-10-07 Thread Franz Sirl
Am 2022-10-07 um 16:13 schrieb Jeff Law: On 10/7/22 04:51, Franz Sirl wrote: Am 2022-09-25 um 18:28 schrieb Jeff Law: This is a minor improvement for the core_list_find routine in coremark. Basically for riscv, and likely other targets, we can end up with an unconditional jump to a return

Re: [RFA] Minor improvement to coremark, avoid unconditional jump to return

2022-10-07 Thread Franz Sirl
Am 2022-09-25 um 18:28 schrieb Jeff Law: This is a minor improvement for the core_list_find routine in coremark. Basically for riscv, and likely other targets, we can end up with an unconditional jump to a return statement.    This is a result of compensation code created by bb-reorder, and

Re: [PATCH] libgo: Recognize off64_t / loff_t type definition of musl libc

2022-06-21 Thread Franz Sirl
Am 2022-06-21 um 09:34 schrieb Sören Tempel via Gcc-patches: Hi, The problem is: glibc defines loff_t in sys/types.h, not fcntl.h (where musl defines it). I falsely assumed that the newly committed AC_CHECK_TYPES invocation would include fcntl.h *in addition to* AC_INCLUDES_DEFAULT. However, as

Re: [PATCH v2] c++: Check attributes on friend declarations [PR99032]

2021-05-18 Thread Franz Sirl
Am 2021-05-14 um 00:08 schrieb Marek Polacek via Gcc-patches: On Wed, May 12, 2021 at 08:27:18PM -0400, Jason Merrill wrote: On 5/12/21 8:03 PM, Marek Polacek wrote: diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c index 89f874a32cc..2bcefb619aa 100644 --- a/gcc/cp/decl2.c +++ b/gcc/cp/decl2.c @@

Re: [PATCH] run -Wnonnull later (PR 87489)

2021-02-19 Thread Franz Sirl
Am 2021-02-01 um 01:31 schrieb Martin Sebor via Gcc-patches: The initial -Wnonnull implementation in the middle end took place too late in the pipeline (just before expansion), and as a result was prone to false positives (bug 78817).  In an attempt to avoid the worst of those, the warning was

Re: [committed] i386: Use lock prefixed insn instead of MFENCE [PR95750]

2020-07-21 Thread Franz Sirl
Am 2020-07-20 um 20:39 schrieb Uros Bizjak via Gcc-patches: Currently, __atomic_thread_fence(seq_cst) on x86 and x86-64 generates mfence instruction. A dummy atomic instruction (a lock-prefixed instruction or xchg with a memory operand) would provide the same sequential consistency guarantees

Re: [PATCH] Add missing store in emission of asan_stack_free.

2020-05-20 Thread Franz Sirl
Am 2020-05-19 um 21:05 schrieb Martin Liška: Hi. We make direct emission for asan_emit_stack_protection for smaller stacks. That's fine but we're missing the piece that marks the stack as released and we run out of pre-allocated stacks. I also included some stack-related constants that were

[PATCH] Alias -Warray-bounds to -Warray-bounds=1

2018-07-25 Thread Franz Sirl
Hi, as discussed with Martin, this patch consolidates -Warray-bounds into an alias of -Warray-bounds=1. Bootstrapped on x86_64-linux, no regressions. Please apply if it's OK. Franz. gcc/ChangeLog: 2018-07-25 Franz Sirl * common.opt: Alias -Warray-bounds to -Warray-bounds=1

Re: committed: remove redundant -Wall from -Warray-bounds (PR 82063)

2018-07-24 Thread Franz Sirl
Am 2018-07-24 um 17:35 schrieb Martin Sebor: On 07/24/2018 03:24 AM, Franz Sirl wrote: Am 2018-07-20 um 23:22 schrieb Martin Sebor: As the last observation in PR 82063 Jim points out that    Both -Warray-bounds and -Warray-bounds= are listed in the c.opt    file as being enabled by -Wall

Re: committed: remove redundant -Wall from -Warray-bounds (PR 82063)

2018-07-24 Thread Franz Sirl
Am 2018-07-20 um 23:22 schrieb Martin Sebor: As the last observation in PR 82063 Jim points out that   Both -Warray-bounds and -Warray-bounds= are listed in the c.opt   file as being enabled by -Wall, but they are the same option,   and it causes this one option to be processed twice in the

Re: backporting fix for 85602 to GCC 8

2018-07-18 Thread Franz Sirl
(untested). Feel free to commit it (I have no access) if you think it's correct. Franz. 2018-07-12 Franz Sirl * invoke.texi (Wstringop-overflow, Wstringop-truncation): Mention enabling via -Wall. (Wall): Add -Wstringop-overflow02 and -Wstringop-truncation. Index

Re: Have g++ define _FILE_OFFSET_BITS=64 on Solaris

2018-06-25 Thread Franz Sirl
Am 2018-06-25 um 15:57 schrieb Rainer Orth: Hi Franz, so you are supposed to use "-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64", but at least a quick glance at the Sol10 headers shows that the additional -D_LARGEFILE_SOURCE only makes a difference for fseeko/ftello. That still right, that's

Re: Have g++ define _FILE_OFFSET_BITS=64 on Solaris

2018-06-22 Thread Franz Sirl
Am 2018-06-22 um 09:51 schrieb Rainer Orth: Hi Franz, No idea about possible problems, but isn't it usually recommended to use either _FILE_OFFSET_BITS=64 or _LARGEFILE{64}_SOURCE=1, not both at the same time? quite the contrary: for regular largefile support, you're supposed to use `getconf

Re: Have g++ define _FILE_OFFSET_BITS=64 on Solaris

2018-06-21 Thread Franz Sirl
Am 2018-06-21 um 16:17 schrieb Rainer Orth: I recently found two libstdc++ testcases failing on some Solaris hosts for 32-bit only: FAIL: 27_io/filesystem/operations/space.cc execution test FAIL: experimental/filesystem/operations/space.cc execution test Both file in the same way: terminate

Re: [RFC][PATCH] Stabilize a few qsort comparison functions

2018-06-13 Thread Franz Sirl
Am 2018-06-12 um 23:49 schrieb Jeff Law: On 02/07/2018 09:58 AM, Franz Sirl wrote: Hi, this is the result of an attempt to minimize the differences between the compile results of a Linux-based and a Cygwin64-based powerpc-eabi cross toolchain. The method used was:     - find the -fverbose

Re: [PATCH] use string length to relax -Wstringop-overflow for nonstrings (PR 85623)

2018-05-14 Thread Franz Sirl
Am 2018-05-10 um 21:26 schrieb Martin Sebor: GCC 8.1 warns for unbounded (and some bounded) string comparisons involving arrays declared attribute nonstring (i.e., char arrays that need not be nul-terminated).  For instance:   extern __attribute__((nonstring)) char a[4];   int f (void)   {

[RFC][PATCH] Stabilize a few qsort comparison functions

2018-02-07 Thread Franz Sirl
ID member. Comments? Bootstrapped on linux-x86_64, no testsuite regressions. Franz Sirl 2018-02-07  Franz Sirl <franz.sirl-ker...@lauterbach.com>     * ira-build.c (object_range_compare_func): Stabilize sort.     * tree-sra.c (compare_access_positions): Likewise.     * va

[PATCH] Minor warning option sync with clang

2018-01-22 Thread Franz Sirl
/ChangeLog; 2018-01-22  Franz Sirl  <franz.sirl-ker...@lauterbach.com>     * c-decl.c (grokdeclarator): Use OPT_Wextern_initializer.     * c-typeck.c (build_binary_op): Use     OPT_Wcompare_distinct_pointer_types. c-family/ChangeLog: 2018-01-22  Franz Sirl  <franz.sirl-ker...@laute

Re: [PATCH v2] New C++ warning option '-Waccess-specifiers'

2017-07-24 Thread Franz Sirl
Am 2017-07-24 um 00:19 schrieb Volker Reichelt: On 23 Jul, Eric Gallager wrote: On 7/23/17, Volker Reichelt wrote: Hi again, here is an updated patch for a new warning about redundant access-specifiers. It takes Dave's various comments into account. The main

Re: [PATCH] Use secure_getenv for GOMP_DEBUG

2017-07-03 Thread Franz Sirl
Am 27.06.17 um 13:10 schrieb Tom de Vries: --- a/libgomp/plugin/plugin-hsa.c +++ b/libgomp/plugin/plugin-hsa.c @@ -39,32 +39,7 @@ #include #include "libgomp-plugin.h" #include "gomp-constants.h" - -/* Secure getenv() which returns NULL if running as SUID/SGID. */ -#ifndef

Re: [PATCH] Introduce --with-gcc-major-version-only configure option (take 2)

2017-01-19 Thread Franz Sirl
Am 2017-01-12 um 21:16 schrieb Jakub Jelinek: libmpx/ * configure.ac: Add GCC_BASE_VER. * Makefile.am (gcc_version): Use @get_gcc_base_ver@ instead of cat to get version from BASE-VER file. * configure: Regenerated. Hi, it seems libmpx/configure.ac is missing

Re: Remove mode argument from gen_rtx_SET

2015-05-08 Thread Franz Sirl
Am 2015-05-07 um 13:37 schrieb Richard Sandiford: One problem with the automatically-generated gen_rtx_FOO () macros is that they always have a mode parameter, even for codes like SET where the mode should always be VOIDmode. This inevitably leads to cases where a caller accidentally passes

Re: Remove mode argument from gen_rtx_SET

2015-05-08 Thread Franz Sirl
Am 2015-05-08 um 13:57 schrieb Segher Boessenkool: On Fri, May 08, 2015 at 12:32:30PM +0200, Franz Sirl wrote: this patch (r222882 is fine, r222883 fails) breaks bootstrap for me on x86_64-linux-gnu: i386.md has set:BND twice; replace that with just set, and all should be fine. Maybe gen

Re: [PATCH] Put all constants last in tree_swap_operands_p, remove odd -Os check

2014-08-15 Thread Franz Sirl
Am 15.08.2014 um 11:32 schrieb Manuel López-Ibáñez: On 15 August 2014 11:07, Richard Biener rguent...@suse.de wrote: - if (TREE_CODE (arg1) == INTEGER_CST) + if (CONSTANT_CLASS_P (arg1) == INTEGER_CST) Huh? /* Nonzero if NODE represents a constant. */ #define CONSTANT_CLASS_P(NODE)\

Re: Use [warning enabled by default] for default warnings

2014-02-11 Thread Franz Sirl
Am 2014-02-11 15:36, schrieb Richard Sandiford: I thought the trend these days was to move towards -Werror, so that for many people the expected output is to get no warnings at all. And bear in mind that the kind of warnings that are not under -W control tend to be those that are so likely to