Re: PATCH: Add pause intrinsic

2011-05-26 Thread Jakub Jelinek
On Thu, May 26, 2011 at 04:29:50PM +0200, Richard Guenther wrote: > To make it a compiler memory barrier you have to "expand" the > builtin already in the frontend and present the middle-end with > __asm__ ("" : : : "memory"). That will serve as a compiler > memory barrier also covering local

Re: PATCH: Add pause intrinsic

2011-05-26 Thread Jakub Jelinek
On Thu, May 26, 2011 at 09:10:32AM -0700, Andi Kleen wrote: > Richard Guenther writes: > As for why having a builtin: one reason would be portability. You mean portability to other compilers (I think reasonable amount of them support gcc-ish inline asm), or to other architectures? __builtin_ia32_

Re: RFC: explicitely mark out-of-scope deaths

2011-05-27 Thread Jakub Jelinek
On Fri, May 27, 2011 at 03:59:47PM +0200, Michael Matz wrote: > On Thu, 26 May 2011, Steven Bosscher wrote: > > > on IRC we discussed about this, here's the RFC patch.  It bootstraps > > > and causes some minor regressions most probably due to some missing > > > sprinkled checks for the special c

[PATCH] Try to canonicalize MEM_REFs that are put into MEM_EXPRs for DEBUG_INSNs (PR debug/47283, take 2)

2011-03-03 Thread Jakub Jelinek
Guenther instead of calling set_mem_expr with a type just clears MEM_EXPR if it isn't suitable for alias oracle. Bootstrapped/regtested again on x86_64-linux and i686-linux, ok? 2011-03-03 Jakub Jelinek PR debug/47283 * cfgexpand.c (expand_debug_expr) : If MEM_REF

[committed] Fix OpenMP ICE on invalid during gimplification (PR c/47963)

2011-03-03 Thread Jakub Jelinek
Hi! omp_notice_variable isn't prepared to see INTEGER_CST (which wouldn't be there on valid code where DECL_SIZE is a DECL). Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2011-03-03 Jakub Jelinek PR c/47963 *

[RFC] OpenMP 3.1 atomics

2011-03-03 Thread Jakub Jelinek
Hi! This patch is a WIP patch for OpenMP 3.1 atomics, so far for C FE only. It handles parsing (I created 3 new tree codes for atomic read, atomic capture of the old and of the new value), gimplification and omp expansion thereof, but currently both atomic read and atomic write are implemented alw

[gomp3.1] C/C++ min/max reductions

2011-03-03 Thread Jakub Jelinek
Hi! This patch adds min/max reduction support for C/C++, which was quite easy given that the middle-end already needs to support it for Fortran. Tested on x86_64-linux, committed to gomp-3_1-branch. 2011-03-03 Jakub Jelinek * c-parser.c (c_parser_omp_clause_reduction): Handle min

Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.

2011-03-03 Thread Jakub Jelinek
On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote: > 2011-03-03 Michael Snyder > > * libiberty/cplus-dem.c (ada_demangle): Stop memory leak. > Also fix a one line indent problem. No libiberty/ in libiberty/ChangeLog. > @@ -1129,10 +1129,11 @@ ada_demangle (const char

Re: [ping] Re: [patch, powerpc] #undef LINK_EH_SPEC before defining it

2011-03-03 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 05:30:10PM +1030, Alan Modra wrote: > On Wed, Feb 16, 2011 at 11:36:09PM +0100, Matthias Klose wrote: > > >../../src/gcc/config/rs6000/sysv4.h:839:1: warning: "LINK_EH_SPEC" > > >redefined > > >In file included from ./tm.h:33, > > >from ../../src/gcc/cp/rtti.c:27: > > >../.

Re: [ping] Re: [patch, powerpc] #undef LINK_EH_SPEC before defining it

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 10:13:02PM +1030, Alan Modra wrote: > > Including freebsd-spec.h in a Linux configuration is certainly very > > questionable and undefining LINK_EH_SPEC and other macros before defining > > them would be certainly cleaner if the freebsd-spec.h include can't be just > > kille

Re: [1/2] Reducing the overhead of dwarf2 location trracking

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 01:53:30PM +, Richard Sandiford wrote: > A typo in dwarf2out.c:compare_loc_operands means that we fail to > detect equivalent addresses in location lists. On this ARM testcase: > > > https://bugs.launchpad.net/gcc-linaro/+bug/714921/+attachment/1837418/+files/gcc-

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 03:30:34PM +0100, Richard Guenther wrote: > On Fri, Mar 4, 2011 at 2:56 PM, Richard Sandiford > > Jakub confirms that this indeed the intended behaviour, and I haven't > > seen any problem with the output. > > Hm, but isn't it incorrect debug info? I would have expected th

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 04:00:06PM +0100, Richard Guenther wrote: > But then location lists for those variables depend on the function context > and cannot be shared for different callers. Am I missing something? Sure, they can't be shared between different functions. If Richard's patch does tha

Re: [2/2] Reducing the overhead of dwarf2 location tracking

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 01:56:55PM +, Richard Sandiford wrote: > * dwarf2out.c (dw_loc_list_node): Add resolved_addr and replaced. > (cached_dw_loc_list_def): New structure. > (cached_dw_loc_list): New typedef. > (cached_dw_loc_list_table): New variable. > (cached_

Re: [Patch, libfortran, committed] PR 47802 Hack around POSIX draft localtime_r

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 07:54:29PM +0200, Janne Blomqvist wrote: > This should fix the problem reported on HP-UX 10.2. Committed as obvious: Well, it is not so obvious, you shouldn't be ignoring the return value from strftime, because if it fails, ltm will contain raondom undefined values. If ther

[PATCH] Avoid IPA-CP versioning if type mismatch prevents it (PR tree-optimization/47967)

2011-03-04 Thread Jakub Jelinek
linux, ok for trunk? 2011-03-04 Jakub Jelinek PR tree-optimization/47967 * ipa-cp.c (build_const_val): Return NULL instead of creating VIEW_CONVERT_EXPR for mismatching sizes. (ipcp_create_replace_map): Return NULL if build_const_val failed. (ipcp_insert_

[PATCH] Teach var-tracking about some targets setmem/movmem patterns (PR debug/47991)

2011-03-04 Thread Jakub Jelinek
s390x-linux cross. Ok for trunk? 2011-03-04 Jakub Jelinek PR debug/47991 * var-tracking.c (find_use_val): Return NULL for cui->sets && cui->store_p BLKmode MEMs. * gcc.dg/pr47991.c: New test. --- gcc/var-tracking.c.jj 2011-02-15 15:42:27.0

[PATCH] Fix gcc.dg/torture/pr47968.c testcase on i?86

2011-03-04 Thread Jakub Jelinek
fixes it by disabling warnings. Ok? 2011-03-04 Jakub Jelinek * gcc.dg/torture/pr47968.c: Ignore warnings. --- gcc/testsuite/gcc.dg/torture/pr47968.c.jj 2011-03-04 19:39:16.092421074 +0100 +++ gcc/testsuite/gcc.dg/torture/pr47968.c 2011-03-04 22:02:14.980388635 +0100 @@ -1,4 +1,5

Re: [PATCH] Fix gcc.dg/torture/pr47968.c testcase on i?86

2011-03-04 Thread Jakub Jelinek
On Sat, Mar 05, 2011 at 12:47:18AM +0100, Richard Guenther wrote: > On Sat, Mar 5, 2011 at 12:10 AM, Jakub Jelinek wrote: > > This testcase fails on i686-linux, because of: > > gcc.dg/torture/pr47968.c:6:7: note: The ABI for passing parameters with > > 16-byte alignment h

[committed] Fix get_loop_body ICE (PR rtl-optimization/47899)

2011-03-05 Thread Jakub Jelinek
Hi! I've committed this patch of Zdenek to fix PR47899 after bootstrap/regtest on x86_64-linux and i686-linux to trunk, pre-approved in the PR. Zdenek, if you want to adjust the ChangeLog entry I've made up or use different e-mail address, just Change it in SVN. kam.uniff.cz domain you've used in

[gomp3.1] Handle list form of OMP_NUM_THREADS

2011-03-07 Thread Jakub Jelinek
on x86_64-linux, committed to gomp-3_1-branch. 2011-03-07 Jakub Jelinek * libgomp.h (gomp_nthreads_var_list, gomp_nthreads_var_list_len): New externs. * env.c (gomp_nthreads_var_list, gomp_nthreads_var_list_len): New variables. (parse_unsigned_long_list

[committed] Fix profiledbootstrap on x86_64-linux (PR bootstrap/48000)

2011-03-07 Thread Jakub Jelinek
Hi! I've bootstrapped/regtested and profiledbootstrapped/regtested the following patch from Zdenek on x86_64-linux and i686-linux and with richi's approval from IRC committed to trunk. 2011-03-07 Zdenek Dvorak PR bootstrap/48000 * cfgloopmanip.c (fix_bb_placements): Return imm

[PATCH] Don't warn with -Wstrict-overflow about X + C1 == C2 transformations (PR tree-optimization/48022)

2011-03-07 Thread Jakub Jelinek
d i686-linux, ok for trunk? 2011-03-07 Jakub Jelinek PR tree-optimization/48022 * fold-const.c (fold_comparison): Don't call fold_overflow_warning for EQ/NE_EXPR. * gcc.dg/pr48022-1.c: New test. * gcc.dg/pr48022-2.c: New test. --- gcc/fold-const.

[PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Jakub Jelinek
t -Su. Ok for trunk? 2011-03-08 Jakub Jelinek * go.test/go-test.exp: For goroutines.go test pass max($[`ulimit -u`/4], 1) as first argument, or 64 as a safe default. --- gcc/testsuite/go.test/go-test.exp.jj2011-01-15 11:26:32.0 +0100 +++ gcc/test

Re: [PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 07:20:28AM -0800, Ian Lance Taylor wrote: > Jakub Jelinek writes: > > > 2011-03-08 Jakub Jelinek > > > > * go.test/go-test.exp: For goroutines.go test pass > > max($[`ulimit -u`/4], 1) as first argument, or 64 as a safe > &g

[PATCH] Rerun df_analyze if delete_trivially_dead_insns deleted something during IRA (PR debug/47881)

2011-03-08 Thread Jakub Jelinek
i686-linux. Ok for trunk? 2011-03-07 Jakub Jelinek PR debug/47881 * ira.c (ira): Call df_analyze again if delete_trivially_dead_insns removed anything. * gcc.dg/pr47881.c: New test. --- gcc/ira.c.jj2011-02-21 15:37:42.0 +0100 +++ gcc/ira.c 2011-

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 07:28:37AM -0800, Ian Lance Taylor wrote: > Rainer Orth writes: > > >> I found no ChangeLog for libgo and no other libgo-related entries. > >> I suspect that means I should omit this change because it belongs upstream. > > > > Indeed, cf. libgo/README*. I've Cc'ed Ian who

Re: [PATCH] Decrease number of threads used by goroutines.go test

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 04:27:04PM +0100, Rainer Orth wrote: > >> 2011-03-08 Jakub Jelinek > >> > >>* go.test/go-test.exp: For goroutines.go test pass > >>max($[`ulimit -u`/4], 1) as first argument, or 64 as a safe > >>defaul

[PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Jakub Jelinek
where else by default it is run just with 64 threads 2011-03-08 Jakub Jelinek * go.test/go-test.exp: For goroutines.go test if GCCGO_RUN_ALL_TESTS is not set in the environment, pass 64 as first argument when not running expensive tests or pass max($[`ulimit -u`/4], 1

Re: [PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 07:40:38PM +0100, Rainer Orth wrote: > Jakub Jelinek writes: > > > Ok, here is an updated patch which uses both proposed env vars: > > > > GCCGO_RUN_ALL_TESTS=1 makes it fail for me as before (i.e. 1 threads) > > > > GCC_TEST_R

Re: [PATCH] Decrease number of threads used by goroutines.go test (take 2)

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 07:56:38PM +0100, Rainer Orth wrote: > Jakub Jelinek writes: > At best, it's shell-specific: Solaris 11 /bin/sh (which is ksh93) does > have it, although admittedly previous Solaris/IRIX/Tru64 UNIX shells > don't. On the other hand, bash has it o

[PATCH] Decrease number of threads used by goroutines.go test (take 3)

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 08:10:31PM +0100, Rainer Orth wrote: > Jakub Jelinek writes: > > > I'm happy to drop the [ ishost "*-linux*" ] && if you are going to look for > > failures on weirdo OSes. I have no idea what ulimit -u does on anything but &g

Re: [PATCH v2] Re: avoid useless if-before-free tests

2011-03-08 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 08:20:22PM +0100, Rainer Orth wrote: > Jim Meyering writes: > > >> I honestly don't see the point of this whitespace change unless done > >> across all ChangeLogs, not just a few that you happen to touch. > > > > As I said, it's gone, now, from my patch. > > If no one obje

[PATCH] Fix MEM_IN_STRUCT_P/MEM_SCALAR_P during expansion (PR rtl-optimization/47866)

2011-03-08 Thread Jakub Jelinek
T_FIELD_REF etc. The BIT_FIELD_REF = 1 stores are done through store_field though, and for some reason the code sets MEM_IN_STRUCT_P in that codepath unconditionally. Changing this fixes the testcase, bootstrapped/regtested on x86_64-linux and i686-linux. I'll try to test this on ia64-li

Re: [PATCH] Fix MEM_IN_STRUCT_P/MEM_SCALAR_P during expansion (PR rtl-optimization/47866)

2011-03-09 Thread Jakub Jelinek
lly. > > > > The irony of marking something scalar when its type is VECTOR_TYPE... > > > >> Changing this fixes the testcase, bootstrapped/regtested on x86_64-linux > >> and i686-linux.  I'll try to test this on ia64-linux tomorrow. > >> > >> 20

[PATCH] Fix s390_delegitimize_address (PR debug/48043)

2011-03-10 Thread Jakub Jelinek
-05/msg00133.html Andreas has bootstrapped/regtested this. Ok for trunk? 2011-03-09 Jakub Jelinek PR debug/48043 * config/s390/s390.c (s390_delegitimize_address): Make sure the result mode match

Re: [PATCH, testsuite]: Fix PR target/48055; FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c compilation, -O2 -flto

2011-03-10 Thread Jakub Jelinek
On Thu, Mar 10, 2011 at 04:48:48PM +0100, Uros Bizjak wrote: > > Are you sure?  Making the vars static enables folding the zero > > initialization. > > I was looking at other similar testcases (snprintf-chk.c, > vsprintf-chk.c), where uninitialized buffer is declared as static (and > it didn't fa

[DOC PATCH] Add -Wunused-but-set-* note to gcc-4.6/changes.html and mention removal of in STL headers

2011-03-10 Thread Jakub Jelinek
Hi! This mentions -Wunused-but-set-* warnings (which are C/C++/ObjC/ObjC++, so not sure how to mention them in the language specific areas instead) and briefly mentions removal of includes. More should go probably into gcc-4.6/porting_to.html. --- htdocs/gcc-4.6/changes.html.jj 2011-03-10

[gomp3.1] In OpenMP 3.1 draft const-qualified decls having no mutable member are no longer predetermined shared

2011-03-10 Thread Jakub Jelinek
Hi! As %subj. said, const vars are no longer predetermined shared, they are just not allowed in private/lastprivate/reduction clauses. Tested on x86_64-linux, committed to gomp-3_1-branch. 2011-03-10 Jakub Jelinek * c-omp.c (c_omp_predetermined_sharing): Don't r

Re: [PATCH] PR c++/PR48035

2011-03-10 Thread Jakub Jelinek
On Thu, Mar 10, 2011 at 05:14:12PM +0100, Dodji Seketeli wrote: > --- /dev/null > +++ b/gcc/testsuite/g++.dg/inherit/virtual8.C ... > + > +int > +main () > +{ > +char *v = new char[sizeof (E) + 16]; > +memset (v, 0x55, sizeof (E) + 16); > +E *e = new (v) E (); > +e->~E (); > + > +

Re: [PATCH] PR c++/PR48035

2011-03-10 Thread Jakub Jelinek
On Thu, Mar 10, 2011 at 12:31:57PM -0800, Mike Stump wrote: > On Mar 10, 2011, at 10:22 AM, Jakub Jelinek wrote: > > The standard way of signalizing a test failure is calling abort (), > > not returning 1, see http://gcc.gnu.org/codingconventions.html > > Actually, returning

[PATCH] With -fno-early-inlining -finline-functions-called-once don't inline functions if there is argument type mismatch (PR tree-optimization/48063)

2011-03-10 Thread Jakub Jelinek
here is an argument mismatch. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux. Ok for trunk? 2011-03-10 Jakub Jelinek PR tree-optimization/48063 * ipa-inline.c (cgraph_decide_inlining): Don't try to inline functions called once if !tree_can_inline_p

Re: [PATCH] PR c++/PR48035

2011-03-11 Thread Jakub Jelinek
On Thu, Mar 10, 2011 at 06:02:50PM -0500, Jason Merrill wrote: > On 03/10/2011 11:14 AM, Dodji Seketeli wrote: > >+ /* If we are initializing a sub-object of > >+ CURRENT_OBJECT_TYPE [for which a primary base class > >+ sub-object has already been initialized] then we must NOT

Re: [PATCH] PR c++/PR48035

2011-03-11 Thread Jakub Jelinek
On Fri, Mar 11, 2011 at 09:01:40AM +0100, Jakub Jelinek wrote: > Do we need to redo parts of class.c anyway? From what I understand, the > problematic vtbl pointers are at the end of the base types and DECL_SIZE > is set to the CLASSTYPE_AS_BASE type size, thus those pointers ought to &

[committed] Fix cgraph ICE with aliases (PR middle-end/48044)

2011-03-11 Thread Jakub Jelinek
e needed wasn't set in them. Bootstrapped/regtested on x86_64-linux and i686-linux, approved by Honza on IRC. 2011-03-11 Jakub Jelinek PR middle-end/48044 * ipa.c (cgraph_remove_unreachable_nodes): Enqueue all vnode->force_output nodes as needed. * gcc.dg/t

Re: [PATCH] PR c++/PR48035

2011-03-11 Thread Jakub Jelinek
On Fri, Mar 11, 2011 at 09:56:59AM -0500, Jason Merrill wrote: > On 03/11/2011 03:01 AM, Jakub Jelinek wrote: > >Do we need to redo parts of class.c anyway? From what I understand, the > >problematic vtbl pointers are at the end of the base types and DECL_SIZE > >is set to

Re: [PATCH] Fix PR47127: call cloog_state_malloc and cloog_state_free only once.

2011-03-14 Thread Jakub Jelinek
_loop_depth (scop); change. Fixed thusly, committed to trunk as obvious. 2011-03-14 Jakub Jelinek PR bootstrap/48102 * graphite-cloog-compat.h (build_cloog_prog): Remove STATE parameter. --- gcc/graphite-cloog-compat.h.jj 2010-10-04 15:00:01.0 +0200 +++ gcc/gr

Re: fix for pr47837

2011-03-14 Thread Jakub Jelinek
On Tue, Mar 08, 2011 at 09:54:42AM -0800, Xinliang David Li wrote: > Please review the attached patch, it does some simplification of the > complicated logical or expressions (x1 or x2 or x3 ...) constructed > from control flow analysis into simpler form. BTW, PR47679 is another case of predicates

Re: [libgfortran, patch] More than 26 temporary files with weak mktemp()

2011-03-14 Thread Jakub Jelinek
On Mon, Mar 14, 2011 at 12:18:16PM +0200, Janne Blomqvist wrote: > On Sat, Mar 12, 2011 at 17:21, FX wrote: > A static variable which is modified introduces a race condition. That is true. > Secondly, you reset the count to 0 at the start of every loop which > makes the static thing superfluous?

[DOC PATCH] 4.6 branching changes

2011-03-14 Thread Jakub Jelinek
Hi! I've committed these changes to reflect the creation of 4.6 branch. --- c99status.html 6 Apr 2010 11:34:44 - 1.55 +++ c99status.html 14 Mar 2011 13:52:00 - 1.56 @@ -21,6 +21,7 @@ paragraph 6) do not count as library iss This page describes the C99 support in ma

[4.6 PATCH] 4.6 branching changes

2011-03-14 Thread Jakub Jelinek
Hi! I've committed following patch to 4.6 branch: 2011-03-14 Jakub Jelinek * doc/invoke.texi, doc/standards.texi: Refer to gcc-4.6/c99status.html. * DEV-PHASE: Mark "prerelease". --- gcc/doc/standards.texi (.../trunk) (revision 1709

[PATCH] Trunk is now 4.7

2011-03-14 Thread Jakub Jelinek
Hi! 2011-03-14 Jakub Jelinek * BASE-VER: Change to 4.7.0. --- gcc/BASE-VER(revision 170924) +++ gcc/BASE-VER(revision 170945) @@ -1 +1 @@ -4.6.0 +4.7.0 Jakub

Re: Add a testcase for reload PR 47166

2011-03-14 Thread Jakub Jelinek
On Mon, Mar 14, 2011 at 12:34:16PM +0100, Richard Guenther wrote: > On Mon, Mar 14, 2011 at 11:25 AM, Richard Sandiford > wrote: > > A reload patch that I posted in January: > > > >    http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00548.html > > > > turned out to be related to PR 47166, so Bernd co

Patch ping

2011-03-14 Thread Jakub Jelinek
Hi! http://gcc.gnu.org/ml/gcc-patches/2011-02/msg01749.html - PR middle-end/47917, snprintf folding Jakub

Re: [v3] Replace docs.sun.com URLs by their OTN equivalents

2011-03-14 Thread Jakub Jelinek
On Mon, Mar 14, 2011 at 09:26:56PM +0100, Rainer Orth wrote: > Benjamin Kosnik writes: > >>libstdc++-v3: > >>* doc/xml/manual/abi.xml: Replace docs.sun.com URLs by their > >> OTN equivalents. > > > > This is ok. > > Thanks. Jakub, ok for 4.6, too? Yeah. Jakub

Re: [PATCH gcc/fortran] get rid of gfc_free

2011-03-15 Thread Jakub Jelinek
On Tue, Mar 15, 2011 at 11:02:38AM +0100, Jim Meyering wrote: > > Instead of "please let us know", maybe recommend using > > __builtin_expect instead? E.g. something like > > > > if (__builtin_expect (ptr != NULL, 0)) > > free (ptr); > > Good idea. Thanks. > Though how about avoiding the doub

[PATCH] Updated DW_OP_GNU_entry_value/DW_TAG_GNU_call_site patch

2011-03-15 Thread Jakub Jelinek
Hi! Now that we are back in stage 1, I'd like move on with the entry_value/call_site debug info extensions. Here is the http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01793.html patch updated to current trunk, bootstrapped/regtested on x86_64-linux and i686-linux. Ok for trunk? 2011-03-15

[PATCH] Updated ENTRY_VALUE patch (PR debug/45882)

2011-03-15 Thread Jakub Jelinek
Hi! Here is http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01794.html patch updated to current trunk, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2011-03-15 Jakub Jelinek PR debug/45882 * rtl.def (ENTRY_VALUE): Change format from "e&q

[PATCH] Adjustment to DW_TAG_GNU_call_site patch for ICF debug

2011-03-15 Thread Jakub Jelinek
Hi! Here is the http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01795.html patch updated to current trunk, bootstrapped/regtested on x86_64-linux and i686-linux. Ok for trunk? 2011-03-15 Jakub Jelinek * calls.c (emit_call_1): Set MEM_EXPR on call's MEM. * var-track

[PATCH] Remove -fenable-icf-debug support

2011-03-15 Thread Jakub Jelinek
i686-linux. 2011-03-15 Jakub Jelinek * emit-rtl.c (try_split): Don't call copy_call_info debug hook. * calls.c: Remove debug.h include. (emit_call_1): Don't call virtual_call_token debug hook. * dwarf2out.c (debug_dcall_section, debug_vca

[committed] Fix fallout from snprintf folding patch (PR tree-optimization/48129)

2011-03-15 Thread Jakub Jelinek
/regtested on x86_64-linux and i686-linux, tested on the testcase with cross to cris-elf, committed to trunk as obvious. 2011-03-15 Jakub Jelinek PR tree-optimization/48129 * builtins.c (fold_builtin_snprintf): Convert to type of built_in_decls[BUILT_IN_SNPRINTF] retval

Re: [PATCH][bug 48123] Install cpu_defines.h for freestanding C++ library.

2011-03-15 Thread Jakub Jelinek
On Tue, Mar 15, 2011 at 07:38:27PM +0100, Paolo Carlini wrote: > > This patch fixes the problem in bug 48123. The problem is that > >some headers include c++config.h, which in turn includes cpu_defines.h > >but cpu_defines.h is not installed. This has been broken for a long > >time. Patch wa

[PATCH] Fix fallout of my fold_binary EQ/NE patch (PR middle-end/48136)

2011-03-15 Thread Jakub Jelinek
idn't succeed, earlier folding already modified the operands so it didn't look like what the code was expecting. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2011-03-15 Jakub Jelinek PR middle-end/48136 * fold-const.c (fold_binary_l

[PATCH] Fix RTL DSE compile time hog (PR rtl-optimization/48141)

2011-03-15 Thread Jakub Jelinek
drop it on the floor when it becomes too long (say over 5000 stores or something similar, perhaps a param). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk (and after a while for 4.6)? 2011-03-15 Jakub Jelinek PR rtl-optimization/48141 * dse.c (record_store)

Re: [PATCH] Fix RTL DSE compile time hog (PR rtl-optimization/48141)

2011-03-15 Thread Jakub Jelinek
On Tue, Mar 15, 2011 at 07:12:13PM -0400, Kenneth Zadeck wrote: > so how much time does this save? >From those 7 minutes back to 16 seconds (--enable-checking=yes, it was 4 seconds in 4.3 with release checking), DSE{1,2} takes each 1%, while previously it was together well over 99%. > I agree tha

Re: [PATCH] Adjustment to DW_TAG_GNU_call_site patch for ICF debug

2011-03-16 Thread Jakub Jelinek
On Wed, Mar 16, 2011 at 11:11:07AM +0100, Andreas Schwab wrote: > Jakub Jelinek writes: > > > + { > > + int nargs = list_length (TYPE_ARG_TYPES (type)); > > + link = CALL_INSN_FUNCTION_USAGE (insn); > > ../../gcc/var-tracking.c: In fu

Re: [PATCH] Fix RTL DSE compile time hog (PR rtl-optimization/48141)

2011-03-16 Thread Jakub Jelinek
-dse-active-local-stores=5000 cc1 spends 18.9 seconds in DSE1+DSE2, with =1000 just 4 seconds and with =10 0.4 seconds. With the earlier patch in addition to this one the time in DSE1+DSE2 is 0.3 seconds no matter what the parameter is. 2011-03-16 Jakub Jelinek P

Re: [PATCH] Fix RTL DSE compile time hog (PR rtl-optimization/48141)

2011-03-16 Thread Jakub Jelinek
On Wed, Mar 16, 2011 at 01:19:30PM +0100, Paolo Bonzini wrote: > Jakub's behavior is expected, since the number of active local > stores should be 1 with the earlier patch in that testcase. > However, similar artificial testcases can probably be constructed > that still trigger the ill behavior. N

Re: RFA: fix PR c/48116

2011-03-16 Thread Jakub Jelinek
On Wed, Mar 16, 2011 at 11:18:04AM -0600, Tom Tromey wrote: > This patch fixes PR c/48116. > > The bug is that -Wreturn-type does not follow the documentation. In > particular, it should warn for this code, but does not: > > static void f() {} > static void g() { return f(); } > > I thi

Re: C++ PATCH for c++/48115 (ICE with ellipsis and templates)

2011-03-16 Thread Jakub Jelinek
On Wed, Mar 16, 2011 at 03:54:45PM -0400, Jason Merrill wrote: > Here the issue was that require_complete_type doesn't do anything in > templates, but convert_arg_to_ellipsis was assuming that it did. > The simple fix is to make sure we really do have a complete type. > > Tested x86_64-pc-linux-gn

[PATCH] Fix prepare_call_arguments for types passed by reference (PR middle-end/48152)

2011-03-16 Thread Jakub Jelinek
for trunk? 2011-03-17 Jakub Jelinek PR middle-end/48152 * var-tracking.c (prepare_call_arguments): If argument needs to be passed by reference, adjust argtype and mode. --- gcc/var-tracking.c.jj 2011-03-16 18:30:12.0 +0100 +++ gcc/var-tracking.c 2011-0

[PATCH] Don't emit entry_value/call_site stuff if -gstrict-dwarf (PR bootstrap/48153)

2011-03-16 Thread Jakub Jelinek
686-linux, tested on a short testcase that with -gstrict-dwarf we don't emit any of them. Ok for trunk? 2011-03-17 Jakub Jelinek PR bootstrap/48153 * dwarf2out.c (mem_loc_descriptor) : Return NULL if dwarf_strict. (gen_subprogram_die): Don't add call

Re: [PATCH] Updated DW_OP_GNU_entry_value/DW_TAG_GNU_call_site patch

2011-03-16 Thread Jakub Jelinek
On Wed, Mar 16, 2011 at 03:38:25PM -0700, H.J. Lu wrote: IMNSHO you really should reconsider using Pmode != ptr_mode for your port. That said, the patch looks good to me, though I can't approve it. > diff --git a/gcc/ChangeLog.x32 b/gcc/ChangeLog.x32 > index 764e3de..45db256 100644 > --- a/gcc/C

[PATCH] Ensure DEBUG_INSNs don't contain MEMs with non-canonical MEM_EXPRs (PR debug/48134)

2011-03-16 Thread Jakub Jelinek
anonicalization isn't successful, just clears the MEM_EXPR. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk and 4.6.1? 2011-03-17 Jakub Jelinek PR debug/48134 * cfgexpand.c (expand_debug_expr) : Use fold to canonicalize MEM_EXPR, if it still isn&#x

Re: [wwwdocs] gcc-4.6/porting_to.html

2011-03-17 Thread Jakub Jelinek
On Wed, Mar 16, 2011 at 11:51:30PM -0700, Benjamin Kosnik wrote: > + > + To fix, first see if the unused variable or parameter can be removed > + without changing the result or logic of the surrounding code. If not, > + annoate it with __attribute__((__unused__)) annotate Also, I think we should

Re: C++ PATCH for c++/48113 (SFINAE bug causing bind regression in libstdc++)

2011-03-17 Thread Jakub Jelinek
On Thu, Mar 17, 2011 at 09:26:36AM +0100, Richard Guenther wrote: > Ok for 4.6.0. I guess we need to do a RC2 anyway. Yeah, certainly. I'll roll one during the weekend, it would be nice if all the pending fixes still desirable for 4.6.0 make it till then and after RC2 we'd try to allow only very

Re: [libgfortran, 4.6] Don't use clock_gettime on Tru64 UNIX (PR fortran/47571)

2011-03-17 Thread Jakub Jelinek
On Thu, Mar 17, 2011 at 11:23:56AM +0100, Rainer Orth wrote: > The conditional use of clock_gettime via weakrefs completely broke > Fortran on Tru64 UNIX: while the function is available in librt, the > platform doesn't support weakrefs, so every execution test fails due to > the undefined symbol.

[PATCH] Adjust DECL_INCOMING_RTL for pass_by_reference parameters (PR debug/48163)

2011-03-17 Thread Jakub Jelinek
nfo for A and I parameters, with this patch the location info is present and correct. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2011-03-17 Jakub Jelinek PR debug/48163 * function.c (assign_parms): For data.passed_pointer parms use MEM of data.entry_

[PATCH] Fix handling of calls to constants (PR debug/48163)

2011-03-17 Thread Jakub Jelinek
ested on x86_64-linux and i686-linux, ok for trunk? 2011-03-17 Jakub Jelinek PR debug/48163 * var-tracking.c (prepare_call_arguments): If CALL target is a non-SYMBOL_REF CONSTANT_P, just add that into the list as pc instead of looking it up using cselib_lookup an

[PATCH] Fix hppa-* --enable-checking=release bootstrap (PR bootstrap/48161)

2011-03-17 Thread Jakub Jelinek
tted, so just gen_rtx_PLUS directly. But having CONST_INT as the first argument and REG as second argument of commutative RTL is invalid. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux and Dave tested it on hppa. Ok for trunk/4.6 (it is a P1 regression)? 2011-03-17 Jakub Jel

Re: [PATCH] Fix hppa-* --enable-checking=release bootstrap (PR bootstrap/48161)

2011-03-17 Thread Jakub Jelinek
On Thu, Mar 17, 2011 at 12:54:44PM -0700, Richard Henderson wrote: > On 03/17/2011 11:46 AM, Jakub Jelinek wrote: > > - result = gen_rtx_PLUS (tmode, result, tmp); > > + { > > + if (swap_commutative_operands_p (result, tmp)) > > + result = gen_r

Re: [PATCH] Fix hppa-* --enable-checking=release bootstrap (PR bootstrap/48161)

2011-03-17 Thread Jakub Jelinek
On Thu, Mar 17, 2011 at 09:07:43PM +0100, Jakub Jelinek wrote: > The following fixes the testcase in cross to hppa-* as well. > I'll bootstrap/regtest it momentarily, ok if it passes? Now bootstrapped/regtested on x86_64-linux and i686-linux. > 2011-03-17 Richard Henderson >

[PATCH] Emit .debug_aranges when needed (PR debug/48176)

2011-03-18 Thread Jakub Jelinek
_info0 can be used too). If you want, for 4.7+ I think we could just use if (text_section_used || cold_text_section_used || arange_table_in_use) { gcc_assert (info_section_emitted); ... Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/4.6? 2011-03-18 Jakub Jel

[PATCH] Fix -fcrossjumping at -O1 (PR rtl-optimization/48156)

2011-03-18 Thread Jakub Jelinek
86_64-linux, ok for trunk and 4.6.1? While it is a wrong-code bug, I doubt many people are using -O -fcrossjumping options together, and -fcrossjumping is only the default for -O2+, where live problem is added by default. 2011-03-18 Jakub Jelinek PR rtl-optimization/48156

Re: [PATCH] Fix -fcrossjumping at -O1 (PR rtl-optimization/48156)

2011-03-18 Thread Jakub Jelinek
On Fri, Mar 18, 2011 at 12:23:11PM -0400, Kenneth Zadeck wrote: > I believe that this is not the right way to go. > > if someone specifies -fcrossjumping, then the pass should turn on > live for the duration of the pass just as ifcvt does.If they ask > for crossjumping you should give them cro

Re: [PATCH] Fix -fcrossjumping at -O1 (PR rtl-optimization/48156)

2011-03-18 Thread Jakub Jelinek
LR should make no difference on the crossjumping). That said, I'm currently also bootstrapping/regtesting following patch just in case: 2011-03-18 Jakub Jelinek PR rtl-optimization/48156 * combine-stack-adj.c (rest_of_handle_stack_adjustments): Compute live problem

Re: Make C1X anonymous structs/unions follow N1549

2011-03-18 Thread Jakub Jelinek
On Fri, Mar 18, 2011 at 09:16:55PM +, Joseph S. Myers wrote: > This week's London WG14 meeting agreed to disallow the use of typedefs > in declaring anonymous structure and union fields, as per N1549. This > patch implements this, restricting the use of typedefs in this case to > -fms-extensio

Re: Can't use SImode as Pmode for x32

2011-03-18 Thread Jakub Jelinek
On Fri, Mar 18, 2011 at 03:32:45PM -0700, H.J. Lu wrote: > On Fri, Mar 18, 2011 at 3:18 PM, Richard Henderson wrote: > > On 03/18/2011 02:56 PM, H.J. Lu wrote: > >> X86 backend uses Pmode for hardware pointer size. Changes > >> it to 32bit for x32, which is really 64bit process, breaks many > >> a

Re: [Committed] S/390: Handle GOTOFF unspecs in delegitimize_address

2011-03-18 Thread Jakub Jelinek
On Fri, Mar 18, 2011 at 06:37:38PM +0100, Andreas Krebbel wrote: > Hi, > > the attached patch adds handling for GOTOFF unspecs to > delegitimize_address. > > A lot of "note: non-delegitimized UNSPEC 112" messages disappear with > this. However not all of them. Please look at http://gcc.gnu.org/

[PATCH] libstdc++ ABI issues with __int128

2011-03-19 Thread Jakub Jelinek
us, I believe we aren't exporting new _ZTS* symbols for some time, only _ZTI*, right? I'll try to post updated abilist files for i686/x86_64/powerpc{,64}/s390{,x}-linux once this is resolved. So here is a patch to fix that up. Ok for trunk/4.6? 2011-03-19 Jakub Jelinek

Re: [PATCH] libstdc++ ABI issues with __int128

2011-03-19 Thread Jakub Jelinek
On Sat, Mar 19, 2011 at 10:19:04AM +0100, Jakub Jelinek wrote: > On Wed, Mar 16, 2011 at 10:05:41AM -0700, Benjamin Kosnik wrote: > > > > Here's the 4_6-branch version, approved by Jakub. > > Comparing the additions in x86_64-linux libstdc++, I still see a cou

Re: [PATCH] Fix -fcrossjumping at -O1 (PR rtl-optimization/48156)

2011-03-19 Thread Jakub Jelinek
On Sat, Mar 19, 2011 at 08:08:48AM -0400, Kenneth Zadeck wrote: > > On 03/19/2011 05:19 AM, Paolo Bonzini wrote: > >On Fri, Mar 18, 2011 at 19:18, Kenneth Zadeck > >wrote: > >>yes, but i think that the reason this is a pr is that it seems to be needed > >>for correctness. > >Note that df_get_bb_

Re: Disallow redefinition of variably modified typedefs

2011-03-19 Thread Jakub Jelinek
On Sat, Mar 19, 2011 at 01:20:41PM +0100, Richard Guenther wrote: > On Sat, Mar 19, 2011 at 12:29 AM, Joseph S. Myers > wrote: > > This week's London WG14 meeting decided that typedef redefinition > > should not be allowed in the case of variably modified types.  This > > patch implements this, gi

Re: [PATCH] Fix -fcrossjumping at -O1 (PR rtl-optimization/48156)

2011-03-19 Thread Jakub Jelinek
On Sat, Mar 19, 2011 at 08:48:55AM -0400, Kenneth Zadeck wrote: > i think that there are two separate questions here: > > 1) should your original patch go in as you did it, or should it go > in with the last "return false" be an abort? bool df_get_bb_dirty (basic_block bb) { return bitmap_bit_p

Re: [PATCH] Fix -fcrossjumping at -O1 (PR rtl-optimization/48156)

2011-03-20 Thread Jakub Jelinek
tstrapped/regtested on x86_64-linux and i686-linux. Ok for trunk? 2011-03-20 Jakub Jelinek PR rtl-optimization/48156 * df-core.c (df_get_bb_dirty): Use df_lr if df_live is NULL, assume df and df_lr are not NULL. * gcc.dg/pr48156.c: New test. --- gcc/df-core.c.jj2

[PATCH] Fix shorten_compare (PR c/48197)

2011-03-20 Thread Jakub Jelinek
k for trunk/4.6.1? 2011-03-20 Jakub Jelinek PR c/48197 * c-common.c (shorten_compare): If primopN is first sign-extended to opN and then zero-extended to result type, set primopN to opN. * gcc.c-torture/execute/pr48197.c: New test. --- gcc/c-family/c-common

[PATCH] ENTRY_VALUE fixes (PR debug/48203)

2011-03-20 Thread Jakub Jelinek
W_OP_GNU_entry_value ops, as the registers aren't clobbered. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2011-03-20 Jakub Jelinek PR debug/48203 * cfgexpand.c (expand_debug_expr) : Only create ENTRY_VALUE if incoming or address of incoming&#x

Re: [PATCH] libstdc++ ABI issues with __int128

2011-03-20 Thread Jakub Jelinek
On Sun, Mar 20, 2011 at 01:58:24AM +0100, Benjamin Kosnik wrote: > 2011-03-19 Jakub Jelinek > > * config/abi/pre/gnu.ver (CXXABI_1.3): Don't export _ZT[IS][PK]*[no]. > (CXXABI_1.3.5): Export _ZTI[PK]*[no]. > > This looks good to me, nice catch. I'll f

[PATCH] Fix s390 delegitimize_address ICE (PR target/48213)

2011-03-20 Thread Jakub Jelinek
t be a big deal for the checking note in dwarf2out, because generally BLKmode isn't VALUE tracked. Ok for trunk/4.6? 2011-03-20 Jakub Jelinek PR target/48213 * config/s390/s390.c (s390_delegitimize_address): Don't call lowpart_subreg if orig_x has BLKmode.

Re: [PATCH] libstdc++ ABI issues with __int128

2011-03-21 Thread Jakub Jelinek
On Sun, Mar 20, 2011 at 01:58:24AM +0100, Benjamin Kosnik wrote: > 2011-03-19 Jakub Jelinek > > * config/abi/pre/gnu.ver (CXXABI_1.3): Don't export _ZT[IS][PK]*[no]. > (CXXABI_1.3.5): Export _ZTI[PK]*[no]. > > This looks good to me, nice catch. I'll f

<    1   2   3   4   5   6   7   8   9   10   >