Re: [Patch, fortran V2] PR fortran/93308/93963/94327/94331/97046 problems raised by descriptor handling

Hi Tobias, On 21/06/21 16:46, Tobias Burnus wrote: Well, as said: directly into the compiler where currently the call to libgomp is. > I don't think I understand were you mean. You don't mean the includes in "f95-lang.c" do you? Best regards, José Rui

Re: [Patch, fortran V2] PR fortran/93308/93963/94327/94331/97046 problems raised by descriptor handling

On 21/06/21 13:46, Tobias Burnus wrote: Hi José, (in principle, I'd like to have the libgfortran function moved to the compiler proper to avoid some issues, but that's admittedly a task independent of your work.) cfi_desc_to_gfc_desc and gfc_desc_to_cfi_desc from ISO_c_binding.c, right? Sinc

Re: [Patch, fortran V3] PR fortran/100683 - Array initialization refuses valid

Hi Tobias, On 21/06/21 12:37, Tobias Burnus wrote: Thus: Do you have a list of patches pending review? > https://gcc.gnu.org/pipermail/fortran/2021-April/055924.html https://gcc.gnu.org/pipermail/fortran/2021-April/055933.html https://gcc.gnu.org/pipermail/fortran/2021-June/056168.html http

[Patch, fortran V3] PR fortran/100683 - Array initialization refuses valid

Hi all! Update to a proposed patch to: PR100683 - Array initialization refuses valid due to more errors being found... Patch tested only on x86_64-pc-linux-gnu. Add call to simplify expression before parsing *and* check *appropriately* if the expression is still an array after simplification

[Patch, fortran V2] PR fortran/100097 PR fortran/100098 - [Unlimited] polymorphic pointers and allocatables have incorrect rank

Hi All! Proposed patch to: PR100097 - Unlimited polymorphic pointers and allocatables have incorrect rank PR100098 - Polymorphic pointers and allocatables have incorrect rank Patch tested only on x86_64-pc-linux-gnu. Version 2 no longer re-initializes explicit initialized variables, which a

PING: [Patch, fortran] PR fortran/96870 - Class name on error message

*PING* Forwarded Message Subject: [Patch, fortran] PR fortran/96870 - Class name on error message Date: Mon, 31 Aug 2020 16:09:32 + From: José Rui Faustino de Sousa To: fort...@gcc.gnu.org, gcc-patches@gcc.gnu.org Hi all! Proposed patch to PR96870 - Class name on error

PING: [Patch, fortran] PR fortran/96724 - Bogus warnings with the repeat intrinsic and the flag -Wconversion-extra

*PING* Forwarded Message Subject: [Patch, fortran] PR fortran/96724 - Bogus warnings with the repeat intrinsic and the flag -Wconversion-extra Date: Thu, 20 Aug 2020 16:52:10 + From: José Rui Faustino de Sousa To: fort...@gcc.gnu.org, gcc-patches@gcc.gnu.org Hi all

[Patch, fortran V2] PR fortran/93308/93963/94327/94331/97046 problems raised by descriptor handling

Hi all! Update to a proposed patch to: Bug 93308 - bind(c) subroutine changes lower bound of array argument in caller Bug 93963 - Select rank mishandling allocatable and pointer arguments with bind(c) Bug 94327 - Bind(c) argument attributes are incorrectly set Bug 94331 - Bind(C) corrupts arr

[Patch, fortran] PR fortran/94104 - Request for diagnostic improvement

Hi all! Proposed patch to: Bug 94104 - Request for diagnostic improvement Patch tested only on x86_64-pc-linux-gnu. Error message improvement. In Fortran 2008 actual arguments to procedures having a pointer, with intent attribute in, formal argument can also have the target attribute not jus

[Patch, fortran V2] PR fortran/100683 - Array initialization refuses valid

Hi all! Update to a proposed patch to: PR100683 - Array initialization refuses valid due to errors found by Dominique d'Humieres. Patch tested only on x86_64-pc-linux-gnu. Add call to simplify expression before parsing *and* check if the expression is still an array after simplification. T

PING: [Patch, fortran v2] PR fortran/92621 Problems with memory handling with allocatable intent(out) arrays with bind(c)

*PING* Forwarded Message Subject: [Patch, fortran v2] PR fortran/92621 Problems with memory handling with allocatable intent(out) arrays with bind(c) Date: Mon, 26 Apr 2021 11:21:25 + From: José Rui Faustino de Sousa To: fort...@gcc.gnu.org, gcc-patches@gcc.gnu.org Hi

[Patch, fortran] PR fortran/100948 - [12 Regression] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9069

Hi all! Proposed partial patch to: Bug 100948 - [12 Regression] ICE in gfc_conv_expr_val, at fortran/trans-expr.c:9069 Patch tested only on x86_64-pc-linux-gnu. Reuse previously calculated full string length to set string section default upper bound. This patch only fixes the ICE the code

Re: [Patch, fortran] PR fortran/101047/101048 Pointer explicit initialization

On 13/06/21 15:46, José Rui Faustino de Sousa wrote: Hi All! Proposed patch to: And again I forgot to add the patch... Sorry for the inconvenience. Best regards, José Rui diff --git a/gcc/fortran/class.c b/gcc/fortran/class.c index 93118ad..5670d18 100644 --- a/gcc/fortran/class.c +++ b

[Patch, fortran] PR fortran/101047/101048 Pointer explicit initialization

Hi All! Proposed patch to: Bug 101047 - Pointer explicit initialization fails Bug 101048 - Class pointer explicit initialization refuses valid Patch tested only on x86_64-pc-linux-gnu. This patch deals with implementation of explicit initialization for pointer variables. It basically relies

[Patch, fortran] PR fortran/100120/100816/100818/100819/100821 problems raised by aggregate data types

Hi all! Proposed patch to: Bug 100120 - associated intrinsic failure Bug 100816 - Wrong span on widechar Bug 100818 - A temporary is passed to associated Bug 100819 - Wrong code generation with unlimited polymorphic objects and character type Bug 100821 - Deferred character with wrong length

Re: [Patch, fortran] PR fortran/100683 - Array initialization refuses valid

Hi All! And yes I forgot the patch... Sorry... Best regards, José Rui On 19/05/21 17:09, José Rui Faustino de Sousa wrote: Hi all! Proposed patch to: PR100683 - Array initialization refuses valid Patch tested only on x86_64-pc-linux-gnu. Add call to simplify expression before parsing

[Patch, fortran] PR fortran/93308/93963/94327/94331/97046 problems raised by descriptor handling

Hi all! Proposed patch to: Bug 93308 - bind(c) subroutine changes lower bound of array argument in caller Bug 93963 - Select rank mishandling allocatable and pointer arguments with bind(c) Bug 94327 - Bind(c) argument attributes are incorrectly set Bug 94331 - Bind(C) corrupts array descripto

[Patch, fortran] PR fortran/100683 - Array initialization refuses valid

Hi all! Proposed patch to: PR100683 - Array initialization refuses valid Patch tested only on x86_64-pc-linux-gnu. Add call to simplify expression before parsing. Thank you very much. Best regards, José Rui Fortran: Fix bogus error gcc/fortran/ChangeLog: PR fortran/100683

[Patch, fortran v2] PR fortran/92621 Problems with memory handling with allocatable intent(out) arrays with bind(c)

Hi all! Proposed patch to: PR92621 - Problems with memory handling with allocatable intent(out) arrays with bind(c) Patch tested only on x86_64-pc-linux-gnu. The code currently generated tries to deallocate the undefined artificial cfi.n pointer before it is associated with the allocatable

[Patch, fortran] PR fortran/100245 - ICE on automatic reallocation

Hi All! Proposed patch to: PR100245 - ICE on automatic reallocation. Patch tested only on x86_64-pc-linux-gnu. Add an if clause for handling derived types in the left hand side. Thank you very much. Best regards, José Rui Fortran: Fix ICE with automatic reallocation [PR100136] gcc/fortran/

[Patch, fortran] PR fortran/82376 - Duplicate function call using -fcheck=pointer

Hi All! Proposed patch to: PR82376 - Duplicate function call using -fcheck=pointer Patch tested only on x86_64-pc-linux-gnu. Evaluate function result and then pass a pointer, instead of a reference to the function itself, thus avoiding multiple evaluations of the function. Thank you very mu

[Patch, fortran] PR fortran/100136 - ICE, regression, using flag -fcheck=pointer

Hi All! Proposed patch to: PR100136 - ICE, regression, using flag -fcheck=pointer Patch tested only on x86_64-pc-linux-gnu. Add handling for pointer expressions. Thank you very much. Best regards, José Rui Fortran: Fix ICE with -fcheck=pointer [PR100136] gcc/fortran/ChangeLog: PR

[Patch, fortran] PR fortran/100132 - Optimization breaks pointer association

Hi All! Proposed patch to: PR100132 - Optimization breaks pointer association. Patch tested only on x86_64-pc-linux-gnu. Correct pointer attributes when passing polymorphic pointers. Thank you very much. Best regards, José Rui Fortran: Fix function attributes [PR100132] gcc/fortran/ChangeL

[Patch, fortran v2] PR fortran/84006, PR fortran/100027 - ICE on storage_size with polymorphic argument

Hi All! Proposed patch to: PR84006 - [8/9/10/11 Regression] ICE in storage_size() with CLASS entity PR100027 - ICE on storage_size with polymorphic argument Patch tested only on x86_64-pc-linux-gnu. Add branch to if clause to handle polymorphic objects, not sure if I got all possible variation

Patch, fortran] PR fortran/100120 - associated intrinsic failure

Hi All! Proposed patch to: PR100120 - associated intrinsic failure Patch tested only on x86_64-pc-linux-gnu. Add code to ensure that pointers have the correct dynamic type. The patch depends on PR100097 and PR100098. Thank you very much. Best regards, José Rui Fortran: Fix associated intri

Patch, fortran] PR fortran/100103 - Automatic reallocation fails inside select rank

Hi All! Proposed patch to: PR100103 - Automatic reallocation fails inside select rank Patch tested only on x86_64-pc-linux-gnu. Add select rank temporary associated names as possible targets of automatic reallocation. The patch depends on PR100097 and PR100098. Thank you very much. Best r

Patch, fortran] PR fortran/100097 PR fortran/100098 - [Unlimited] polymorphic pointers and allocatables have incorrect rank

Hi All! Proposed patch to: PR100097 - Unlimited polymorphic pointers and allocatables have incorrect rank PR100098 - Polymorphic pointers and allocatables have incorrect rank Patch tested only on x86_64-pc-linux-gnu. Pointers, and allocatables, must carry TKR information even when undefined

[Patch, fortran] PR fortran/100094 - Undefined pointers have incorrect rank when using optimization

Hi All! Proposed patch to: PR100094 - Undefined pointers have incorrect rank when using optimization Patch tested only on x86_64-pc-linux-gnu. Pointers, and allocatables, must carry TKR information even when undefined. The patch adds code to initialize both pointers and allocatables element

[Patch, fortran] PR fortran/100029 - ICE on storage_size with polymorphic argument, PR fortran/100040 - Wrong code with intent out assumed-rank allocatable

Hi All! Proposed patch to: PR100040 - Wrong code with intent out assumed-rank allocatable PR100029 - ICE on subroutine call with allocatable polymorphic assumed-rank argument Patch tested only on x86_64-pc-linux-gnu. Made sure the code also recognized assumed-rank arrays as full arrays. Cha

[Patch, fortran] PR fortran/84006, PR fortran/100027 - ICE on storage_size with polymorphic argument

Hi All! Proposed patch to: PR84006 - [8/9/10/11 Regression] ICE in storage_size() with CLASS entity PR100027 - ICE on storage_size with polymorphic argument Patch tested only on x86_64-pc-linux-gnu. Add branch to if clause to handle polymorphic objects, not sure if I got all possible variation

[Patch, fortran] PR fortran/100024 PR fortran/100025 ICE on subroutine missing explicit interface

Hi all! Proposed patch to PR100024 & PR100025 - ICE on missing polymorphic argument. Patch tested only on x86_64-pc-linux-gnu. Remove assertion checking for possible assumed rank arrays and added an explicit error message. Change if clause to allow the handling of assumed-rank arrays as arra

Re: [Patch, fortran] PR fortran/100018 - ICE on missing polymorphic argument

On 10/04/21 17:37, Tobias Burnus wrote: And you need an additional single-line summary for git – which should be part of the patch submission. Fortran: Fix ICE due to referencing a NULL pointer [PR100018] gcc/fortran/ChangeLog: PR fortran/100018 * resolve.c: Add association check be

[Patch, fortran] PR fortran/100018 - ICE on missing polymorphic argument

Hi all! Proposed patch to PR100018 - ICE on missing polymorphic argument. Patch tested only on x86_64-pc-linux-gnu. Add association check before de-referencing pointer in order to avoid ICE. Thank you very much. Best regards, José Rui 2021-4-10 José Rui Faustino de Sousa gcc

[Patch, fortran] PR fortran/96870 - Class name on error message

Hi all! Proposed patch to PR96870 - Class name on error message. Patch tested only on x86_64-pc-linux-gnu. Make the error message more intelligible for the average user. Thank you very much. Best regards, José Rui 2020-8-21 José Rui Faustino de Sousa gcc/fortran/ChangeLog

[Patch, fortran] PR fortran/95352 - ICE on select rank with assumed-size selector and lbound intrinsic

-8-21 Steve Kargl PR fortran/95352 * simplify.c (simplify_bound_dim): Add check for NULL pointer before trying to access structure member. 2020-8-21 José Rui Faustino de Sousa PR fortran/95352 * PR95352.f90: New test. diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c index

Re: [Patch, fortran, v2] PR fortran/96728 - Fatal Error: Reading module inquiry functions on assumed-rank

Hi all! Exactly the same thing, only actually including the patch this time. Sorry for the mishap. Thank you very much. Best regards, José Rui On 20/08/20 19:33, José Rui Faustino de Sousa wrote: Hi all! Proposed patch to PR96728 - Fatal Error: Reading module inquiry functions on assumed

[Patch, fortran] PR fortran/94110 - Passing an assumed-size to an assumed-shape argument should be rejected

passed an assumed-size array formal argument when raising an error. Thank you very much. Best regards, José Rui 2020-8-20 José Rui Faustino de Sousa PR fortran/94110 * interface.c (gfc_compare_actual_formal): Add code to also raise the actual argument cannot be an assumed-size array error

[Patch, fortran] PR fortran/96728 - Fatal Error: Reading module inquiry functions on assumed-rank

arrays, the reading the module will fail. So the patch adds code to handle signed integers. Thank you very much. Best regards, José Rui 2020-8-20 José Rui Faustino de Sousa PR fortran/96728 * module.c (module_peek_char): Peek ahead function. (parse_integer): Add code for parsing signed

[Patch, fortran] PR fortran/96727 - ICE with character length specified using specification function on assumed-rank array

José Rui Faustino de Sousa PR fortran/96727 * expr.c (gfc_check_init_expr): Add default error message for the AS_ASSUMED_RANK case. 2020-8-20 José Rui Faustino de Sousa PR fortran/96727 * PR96727.f90: New test. diff --git a/gcc/fortran/expr.c b/gcc/fortran/expr.c index 6707ca5..aecbe46

[Patch, fortran] PR fortran/96726 - ICE with user defined specification function on assumed-rank array

Rui Faustino de Sousa PR fortran/96726 * expr.c (check_references): Change different relational operator to less-than operator to avoid infinite loop. 2020-8-20 José Rui Faustino de Sousa PR fortran/96726 * PR96726.f90: New test. diff --git a/gcc/fortran/expr.c b/gcc/fortran/expr.c index

[Patch, fortran] PR fortran/96724 - Bogus warnings with the repeat intrinsic and the flag -Wconversion-extra

-8-20 José Rui Faustino de Sousa PR fortran/96724 * iresolve.c (gfc_resolve_repeat): Force conversion to gfc_index_integer_kind before the call to gfc_multiply. 2020-8-20 José Rui Faustino de Sousa PR fortran/96724 * repeat_8.f90.f90: New test. diff --git a/gcc/fortran/iresolve.c b/gcc

[Patch, fortran] PR fortran/94022 - Array slices of assumed-size arrays

not get improperly reset to -1 to mark it has an assumed size array. Best regards, José Rui 2020-6-3 José Rui Faustino de Sousa PR fortran/94022 * trans-expr.c (gfc_conv_procedure_call): In the case of assumed-size arrays ensure that the reference is to a full array. 2020-6-3 José Rui

[Patch, fortran] PR fortran/95331 - Unlimited polymorphic arrays have wrong bounds

Best regards, José Rui 2020-5-26 José Rui Faustino de Sousa PR fortran/95331 * trans-array.c (gfc_conv_array_ref): For class array dummy arguments use the transformed descriptor in sym->backend_decl instead of the original descriptor. 2020-5-26 José Rui Faustino de Sousa PR fort

[Patch, fortran] PR fortran/52351, 85868 Wrong array section bounds when passing to an intent-in pointer dummy

descriptors indexing (hopefully) fixing the wrong offsets generated. Thank you very much. Best regards, José Rui 2020-5-25 José Rui Faustino de Sousa PR fortran/85868 * trans-array.c (gfc_conv_expr_descriptor) Enable the creation of a new descriptor with the correct one based indexing for

[Patch, fortran] PR fortran/66833,67938,95214 ICE on using assumed rank character array

-19 José Rui Faustino de Sousa PR fortran/95214 * trans-expr.c (gfc_maybe_dereference_var): Add assumed-rank to character dummy arguments list of possible attributes. 2020-5-19 José Rui Faustino de Sousa PR fortran/95214 * PR95214.f90: New test. diff --git a/gcc/fortran/trans-expr.c b

Re: [Patch v2, fortran] PR fortran/90350 - ubound ICE on assumed size array even though explicit bound is specified

Hi Thomas, On 21/04/20 16:38, Thomas Koenig wrote: Do you have commit privileges? It not, I can commit it for you. No i do not. I would be grateful if you could. Best regards, José Rui

[Patch v2, fortran] PR fortran/90350 - ubound ICE on assumed size array even though explicit bound is specified

Hi again! Proposed patch to Bug 90350 - ubound ICE on assumed size array even though explicit bound is specified Patch tested only on x86_64-pc-linux-gnu. Best regards, José Rui 2020-4-19 José Rui Faustino de Sousa PR fortran/90350 * simplify.c (simplify_bound): In the case of assumed

Re: [Patch, fortran] PR fortran/90350 - ubound ICE on assumed size array even though explicit bound is specified

Hi Thomas! > ? In other words, maybe a check on the upper bound > of the last dimension would be better? > You mean enforcing: C928 (R921) The second subscript shall not be omitted from a subscript-triplet in the last dimension of an assumed-size array. right? If I have correctly understood

[Patch, fortran] PR fortran/90350 - ubound ICE on assumed size array even though explicit bound is specified

are explicit-shape arrays not whatever that was sectioned. But, although this pattern of problem shows up in the code in other places, it may be more trouble than it is worth... Thank you very much. Best regards, José Rui 2020-4-19 José Rui Faustino de Sousa PR fortran/90350 * simplify.c

[Patch, fortran] PR fortran/94327 and PR fortran/94331 Bind(C) problems

, José Rui 2020-3-25 José Rui Faustino de Sousa PR fortran/94331 * trans-decl.c (convert_CFI_desc): Only overwrite the array descriptor if the dummy argument has the pointer or allocatable attribute set and not if it has the value attribute set or if it is intent in. 2020-3-25 José Rui

[Patch, fortran] PR fortran/93963 Select rank mishandling allocatable and pointer arguments with bind(c)

. Best regards, José Rui 2020-2-27 José Rui Faustino de Sousa PR fortran/93963 * trans-stmt.c (gfc_trans_select_rank_cases): Add if conditional short circuiting the evaluation of rank for allocatable and pointer arguments. PR fortran/93963 * ISO_Fortran_binding.c (cfi_desc_to_gfc_desc

[Patch, fortran] PR fortran/93957 - [10 Regression] ICE (regression) passing assumed rank arrays with bind(c)

" to the definition of "alloc_comp_or_fini". Instead of only accepting BT_DERIVED it will now also accept BT_CLASS types. It seems to be missing but I may be wrong. Thank you very much. Best regards, José Rui 2020-2-27 José Rui Faustino de Sousa PR fortra

Re: [Patch, fortran] PR fortran/92621 Problems with memory handling with allocatable intent(out) arrays with bind(c)

On 21/02/20 12:38, Tobias Burnus wrote: Hmm, that sounds like papering over a real bug. It is possible, I tried using DECL_INITIAL to nullify cfi.n but it did not made any difference. I tried to play with optimization and up to -O1 it does not seem to crash but it always seems to crash at

[Patch, fortran] PR fortran/92621 Problems with memory handling with allocatable intent(out) arrays with bind(c)

regards, José Rui 2020-2-21 José Rui Faustino de Sousa PR fortran/92621 * trans-expr.c (gfc_conv_gfc_desc_to_cfi_desc): Add code to deallocate allocatable intent(out) dummy array arguments, slightly rearrange code. (gfc_conv_procedure_call): Split if conditional in two branches removes

Re: [Patch, fortran] PR fortran/92142 - CFI_setpointer corrupts descriptor

Hi, On 17/10/19 17:29, Tobias Burnus wrote: If you generate to stdout/stderr like in this case, I think it makes sense to also check for this output using "{dg-output …}". Added the suggested check and a few touches to comments and the error message. that might be a bug in the C code of

[Patch, fortran] PR fortran/92142 - CFI_setpointer corrupts descriptor

the pointer to whatever is the target's attribute corrupting the descriptor. Thank you very much. Best regards, José Rui 2019-10-17 José Rui Faustino de Sousa PR fortran/92142 * ISO_Fortran_binding.c (CFI_setpointer): Add check to verify if the object being set (result) is rea