+## libraries are not created on a Solaris build. All other library
> +## combinations are created by default.
> +
> +# Uncomment to temporarily avoid building big endian and profiling libraries
> during a Windows build.
> +#ifeq ($(DEV_HOST_OS), win32)
> +#BUILD_BE_MULTILIB ?= 0
> +#BUILD_PG_MULTILIB ?= 0
> +#endif
I don't know where DEV_HOST_OS is supposed to come from, but this doesn't
appear to make much sense for FSF GCC anyway. If you want options to have
various possible sets of multilibs, model them on e.g. SH
--with-multilib-list rather than having this Nios II-specific approach.
--
Joseph S. Myers
jos...@codesourcery.com
ame.
> + void *fnptr,
> + void *chainptr)
> +{
> + unsigned int fn = (unsigned int)fnptr;
> + unsigned int chain = (unsigned int)chainptr;
Missing spaces in casts.
> + .file "crtn.asm"
Such .file directives in libgcc assembly sources should generally be
avoided; see <http://gcc.gnu.org/ml/gcc-patches/2008-07/msg00123.html> for
rationale.
--
Joseph S. Myers
jos...@codesourcery.com
On Tue, 16 Apr 2013, Sriraman Tallam wrote:
> Ok, it is on by default now. There is a way to turn it off, with
> -mno-generate-builtins.
Any new option needs documenting in invoke.texi.
--
Joseph S. Myers
jos...@codesourcery.com
arn calls,
> which, in fact, also fixes a bug: we don't want to actually emit such warnings
> for -Wpedantic -Wno-pointer-arith (as would happen before and after the
> trivial tweak above)
The C changes are OK.
--
Joseph S. Myers
jos...@codesourcery.com
" at the end of each ChangeLog entry).
--
Joseph S. Myers
jos...@codesourcery.com
* config/arm/arm-tables.opt: Regenerate.
> * config/arm/arm-cores.def: Add cortex-a53.
This patch is missing an update to the list of valid ARM -mcpu= arguments
in invoke.texi.
--
Joseph S. Myers
jos...@codesourcery.com
ion is actually going to be of a static array itself.
--
Joseph S. Myers
jos...@codesourcery.com
nts have been
addressed. But this looks like the sort of thing I was expecting for
cleaning up the built-in function handling.
--
Joseph S. Myers
jos...@codesourcery.com
it's valid in the caller but not the
callee. If it's invalid in the caller as well, neither should check
(except maybe in an assertion if felt appropriate in a particular case).
--
Joseph S. Myers
jos...@codesourcery.com
cture has a static type other than "tree",
specific to the particular case in question; it may be an ad hoc type in
GCC, or use GCC-specific infrastructure such as vec.h, or standard C++
library features where there aren't problems with interaction with garbage
collection. If in doubt about how to represent something without using
TREE_LIST, post details of the particular datastructure and how it is used
to the gcc@ list.
TREE_LISTs have TYPE, CHAIN, VALUE and PURPOSE pointers as well as a
TREE_CODE. It's rare for all of these to be used, so they are generally
particularly memory-inefficient.
--
Joseph S. Myers
jos...@codesourcery.com
the same except that C++ disallows decrement
operators (prefix and postfix --) on bool and C allows them. (I don't
know what C++ specifies regarding bool bit-fields or whether there are any
incompatibilities there, but for non-bit-field objects you shouldn't have
problems.)
--
Joseph S. Myers
jos...@codesourcery.com
pe,
> tree rhs,
>enum tree_code coder;
>tree rname = NULL_TREE;
>bool objc_ok = false;
> -
>if (errtype == ic_argpass)
> {
>tree selector;
Avoid spurious changes like this not related to the substance of the
patch.
> + if (flag_enable_cilkplus && contains_array_notation_expr (cond))
> +{
> + error_at (start_locus, "array notation expression cannot be used in a "
> + "loop's condition");
> + return;
Use %' for English apostrophes in diagnostics, so that a proper apostrophe
rather than neutral vertical ' can be used in appropriate locales.
> + error_at (start_locus, "array notation expression cannot be used in a "
> + "loop's increment expression.");
Likewise, and remove the trailing ".".
--
Joseph S. Myers
jos...@codesourcery.com
, tree stride, tree type)
> +{
> + tree array_ntn_tree = NULL_TREE;
> + size_t stride_rank = 0, length_rank = 0, start_rank = 0;
> +
> + if (!TREE_TYPE (start_index) || !INTEGRAL_TYPE_P (TREE_TYPE (start_index)))
I'd expect the argument would have to be an expression, so would always
have a TYPE and the !TREE_TYPE (start_index) check should be unnecessary.
If it is needed, explain further in the comment at the start of the
function. Likewise for other checks for NULL types in this function.
> +{
> + error_at (loc,
> + "start-index of array notation triplet is not an integer.");
Diagnostic should not end with ".".
> + error_at (loc, "length of array notation triplet is not an integer.");
Likewise.
> + error_at (loc, "stride of array notation triplet is not an integer.");
Likewise.
> + error_at (loc, "rank of an array notation triplet's start-index is not
> "
> + "zero.");
Likewise.
> + error_at (loc, "rank of an array notation triplet's length is not
> zero.");
Likewise.
> + error_at (loc, "rank of array notation triplet's stride is not zero.");
Likewise.
That's a coding style review of the first half or so of the patch, more
later
--
Joseph S. Myers
jos...@codesourcery.com
On Mon, 4 Mar 2013, Joey Ye wrote:
> + char *new_spec = (char *)xmalloc (len + number_of_space + 1);
Space in cast between "(char *)" and "xmalloc". OK with that change.
--
Joseph S. Myers
jos...@codesourcery.com
On Fri, 1 Mar 2013, Tobias Burnus wrote:
> Joseph S. Myers wrote:
> > OK, though for the libiberty patch it would be good if someone can find
> > the make-obstacks-texi.sh script referred to in libiberty.texi, check it
> > in and get obstacks.texi exactly in sync with the
On Mon, 4 Mar 2013, Jakub Jelinek wrote:
> 2013-03-04 Jakub Jelinek
>
> PR bootstrap/56509
> * opts.c (opts_obstack, opts_concat): Moved to...
> * opts-common.c (opts_obstack, opts_concat): ... here.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
g;
As discussed above, not needed.
> + for (j=0, k=0; j<=len; j++, k++)
Spaces around "=" and "<=".
> + if (orig[j] == ' ' || orig[j] == '\t') new_spec[k++] = '\\';
Put the "if" both on a separate line.
> + else return orig;
Put the "else" body on a separate line.
--
Joseph S. Myers
jos...@codesourcery.com
the output of that script
run on current glibc sources.
--
Joseph S. Myers
jos...@codesourcery.com
t should be passed?
--
Joseph S. Myers
jos...@codesourcery.com
t; where appropriate and avoid leaking memory.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
tant times the size of the command line, is that to
free data you'd then need to keep track of what was allocated and what was
pointing into argv, or strdup everywhere a pointer into argv is used, and
probably wouldn't actually end up saving any memory.)
--
Joseph S. Myers
jos...@codesourcery.com
gument in question rather
than e.g. to the end of the function containing the problem call?)
--
Joseph S. Myers
jos...@codesourcery.com
gfc_warning ("TODO: type-bound defined assignment(s) at %L not "
"done because multiple part array references would "
"occur in intermediate expressions.", &(*code)->loc);
return;
--
Joseph S. Myers
jos...@codesourcery.com
of how the path, before the patch,
got processed so that the spaces were wrongly interpreted. That might
help make clearer whether the interface to this new function is actually
correct, since the subsequent operations on the return value should act as
an inverse to the operation carried o
n the preprocessor needs to
handle multiple precisions to deal with such types in preprocessor
expressions.
--
Joseph S. Myers
jos...@codesourcery.com
n't have any error/warning attributes those with STRING_CST arguments.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
OK.
--
Joseph S. Myers
jos...@codesourcery.com
in
stage 1), and given how it's likely that such patches may interact and
that comments from review of one patch may point out things you need to
fix in later patches as well, it's not clear how useful sending a long
patch series at one go will be.
--
Joseph S. Myers
jos...@codesourcery.com
I intend to look at this once we're back in development stage 1 (for GCC
4.9).
--
Joseph S. Myers
jos...@codesourcery.com
ror is right, initialization of nested flexible array
> member is what is happening in the testcase and is invalid.
OK. I agree that test is invalid.
--
Joseph S. Myers
jos...@codesourcery.com
t;
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2013-01-14 Jakub Jelinek
>
> PR tree-optimization/48766
> * opts.c (common_handle_option): For -fwrapv disable -ftrapv, for
> -ftrapv disable -fwrapv.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
/
#define ASM_OUTPUT_CASE_END(FILE, NUM, JUMPTABLE) \
--
Joseph S. Myers
jos...@codesourcery.com
nd changes are OK. Properly diagnostic messages inside ? :
conditionals should be marked up with G_() to ensure that both cases are
extracted for translation, though in this case it doesn't matter much
given that the message wording should stay identical to other copies of
the same messages.
--
Joseph S. Myers
jos...@codesourcery.com
On Mon, 7 Jan 2013, Richard Sandiford wrote:
> "Joseph S. Myers" writes:
> > On Sun, 6 Jan 2013, Richard Sandiford wrote:
> >
> >> Anyway, here's my attempt a script to convert to ranges and, if enabled,
> >> to include the current year. The sc
and at this development stage I think it will need to wait
until after 4.8 branches.
--
Joseph S. Myers
jos...@codesourcery.com
_dir): Also search multilib from multilib_reuse.
> * gcc/genmultilib (tmpmultilib3): Refactor code.
> (tmpmultilib4): Ditto.
> (multilib_reuse): New multilib argument.
This patch is OK.
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 19 Dec 2012, H.J. Lu wrote:
> +#ifdef CROSS_DIRECTORY_STRUCTURE
> + = concat(target_machine, "-", ld_suffixes[i], NULL);
Missing space before '('.
The patch is OK with that fixed.
--
Joseph S. Myers
jos...@codesourcery.com
t --version notices should just say 2013
(including e.g. that in fixincludes/mkheaders.in).
--
Joseph S. Myers
jos...@codesourcery.com
On Wed, 26 Dec 2012, Alexander Ivchenko wrote:
> The attached patch is indended to add the target hook for indicating
> the support of ifunc on target.
That's not a hook, it's a target macro. What is the rationale for this
needing to be a target macro instead of a target hoo
2-12/msg00484.html>, I
don't see the need for the variables named with Var in common.opt, and I'd
think proper help text would be better than using Undocumented.
--
Joseph S. Myers
jos...@codesourcery.com
n system.h and moving
the Linux implementation of the hook from builtins.c to some
Linux-specific file since you can't assume OPTION_GLIBC or OPTION_BIONIC
are defined for other targets.
--
Joseph S. Myers
jos...@codesourcery.com
ser_asm_statement): Adjust callers.
> * c-typeck.c (build_asm_expr): Call c_fully_fold on inputs
> and outputs here, and call default_function_array_conversion
> on inputs that don't need to be addressable.
>
> * c-c++-common/pr55619.c: New test.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
mvl and mvr types.
>
> * gcc.dg/pr39464.c: New test.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
We only care rule that has concrete multilib.
"care about", I think, but this sentence still doesn't really make sense
to me. What are the cases that aren't being cared about here, and why are
they valid inputs? Surely, given a proper MULTILIB_REUSE setting, every
rule in that setting should do something meaningful and rules that don't
should result in errors?
--
Joseph S. Myers
jos...@codesourcery.com
h a macro from fp-bit. As I noted in
<http://gcc.gnu.org/ml/gcc-patches/2012-03/msg00819.html>, I believe all
the support in fp-bit for the IRIX variant of IBM long double can also be
removed, and the associated code in real.[ch].
--
Joseph S. Myers
jos...@codesourcery.com
itecture, I guess the macro choosing a hook implementation would get
defined in .h files rather than directly in .c.)
--
Joseph S. Myers
jos...@codesourcery.com
nstead
> of onlya8.
This ChangeLog entry doesn't appear to mention the arm.opt change.
Furthermore, the patch seems to be missing any .texi change to document
the option; any new option needs documentation. You are also missing
testcases for the testsuite to verify that both
ersion of the patch, with
self-contained description / rationale.
--
Joseph S. Myers
jos...@codesourcery.com
t_value, tree arith_type)
The comment needs updating to explain the new parameter.
--
Joseph S. Myers
jos...@codesourcery.com
seem to be needed in my
final testing.
--
Joseph S. Myers
jos...@codesourcery.com
allow for big-endian, and use a different name in that
case?
--
Joseph S. Myers
jos...@codesourcery.com
d/regtested on x86_64-linux and i686-linux, ok for
> trunk?
OK.
--
Joseph S. Myers
jos...@codesourcery.com
.h or other architecture-specific code. Most of the
extra complexity in glibc is to get it from libc without depending on libm
(since fegetround is in libm), but libquadmath depends on libm anyway.
--
Joseph S. Myers
jos...@codesourcery.com
On Thu, 15 Nov 2012, Matthias Klose wrote:
> Am 14.11.2012 23:41, schrieb Joseph S. Myers:
> > Your t-linux setting fails to allow for the possibility of the compiler
> > being configured to default to soft-float (whether --with-float=soft, or
> > --with-cpu etc. for a
multiarch name.
--
Joseph S. Myers
jos...@codesourcery.com
re need different multiarch names; you need to
avoid using a name for one on a compiler configured for the other. (I
think any configuration will always be --with-arch=m68k or --with-arch=cf
so you should only need to consider M68K_ARCH rather than having
per-multilib settings.)
--
Jo
e correct when that definition
is added.)
--
Joseph S. Myers
jos...@codesourcery.com
,
> -fno-PIE the compiler should act as though only the last of those
> options were specified. That follows the usual formulat in which the
> last option wins.
>
> This patch implements that. Bootstrapped and tested on
> x86_64-unknown-linux-gnu. OK for mainline?
OK.
--
Joseph S. Myers
jos...@codesourcery.com
the common toplevel to that scheme as well.)
That way, you don't have a toplevel change that needs merging to the src
repository for every individual change to the systems supported in a
particular subdirectory.
--
Joseph S. Myers
jos...@codesourcery.com
to work with a
cross-GDB and cross-compiler.
--
Joseph S. Myers
jos...@codesourcery.com
in/sh".
Suppose /bin/sh is not a POSIX shell but the user sets CONFIG_SHELL to
something else (which is a POSIX shell). Will SHELL in the makefile get
set to the POSIX shell the user specified as CONFIG_SHELL? That's what's
needed to be able to use POSIX shell features in this script.
--
Joseph S. Myers
jos...@codesourcery.com
genmultilib (combo_to_dir): New function.
> (options_output): New function.
> (MULTILIB_REUSE): New argument.
> * Makefile.in (s-mlib): Add a new argument MULTILIB_REUSE.
> * gcc.c (multilib_reuse): New spec.
> (set_multilib_dir): Use multilib_reuse.
Documentation chan
On Sat, 3 Nov 2012, Andi Kleen wrote:
> "Joseph S. Myers" writes:
> >>
> >> 2012-10-31 Andi Kleen
> >>
> >>* g++.dg/fno-instrument-function.C: Add.
> >>* gcc.dg/fno-instrument-function.c: Add.
> >
> > You have a
/testsuite:
>
> 2012-10-31 Andi Kleen
>
> * g++.dg/fno-instrument-function.C: Add.
> * gcc.dg/fno-instrument-function.c: Add.
You have a C++ test but no corresponding C++ front-end change; how does
that work?
> +Link Time Optimization (LTO) to override the effe
that would be quite hard.)
--
Joseph S. Myers
jos...@codesourcery.com
On Sat, 27 Oct 2012, Manuel L?pez-Ib??ez wrote:
> On 19 October 2012 18:17, Joseph S. Myers wrote:
> > On Wed, 17 Oct 2012, Manuel L?pez-Ib??ez wrote:
> >
> >> documentation but I can also implement -Wformat=0 being an alias for
> >> -Wno-format and -Wformat=1
ries.
* Introducing a known bug in one patch in the series, where a subsequent
patch in the series is the fix, unless the fix really depends on
intermediate patches in the series
--
Joseph S. Myers
jos...@codesourcery.com
l
still make sense for non-glibc or older-glibc systems, but hopefully the
implementations can be closer to the glibc versions then. And supporting
the various parts of the floating-point TS in glibc would be a lot of
work.)
--
Joseph S. Myers
jos...@codesourcery.com
m glibc as well - strtod in particular has had major changes in
glibc since it was last updated.
--
Joseph S. Myers
jos...@codesourcery.com
should include the changes to
install.texi to document those options for people building GCC.
--
Joseph S. Myers
jos...@codesourcery.com
On Tue, 30 Oct 2012, Tom Tromey wrote:
> This patch adds a @direntry for gcov.
>
> I noticed that it was missing today, when I tried to find the gcov
> manual from the info "dir" node. Then I found out that I had filed PR
> 50899 for this ages ago.
>
> Ok
handled as
such, and include that header in the testcase; there are several existing
examples of this in gcc.dg.
--
Joseph S. Myers
jos...@codesourcery.com
t not int to measure that size. If you were measuring something
on the target, you might need HOST_WIDE_INT (for example, a compiler on a
32-bit host can reasonably build objects for a 64-bit target that declare
arrays with more than 2^31 elements, so size_t is not the right type to
use i
your ASM_SPEC and LINK_SPEC, such as
%{v}, %{version:-v}, %{b}, %{Wl,*:%*}., %{!dynamic-linker:...}. Remove
them.
--
Joseph S. Myers
jos...@codesourcery.com
If you need special t-* logit for fp-bit.c / dp-bit.c, rather than being
able to use t-fdpbit, then you need comments explaining why the special
logic rather than the generic code is used.
--
Joseph S. Myers
jos...@codesourcery.com
Same diagnostic comment regarding one fatal_error call here; in addition,
diagnostic functions should not be called directly from .md files at all,
because .md files aren't processed by exgettext to extract messages for
translation.
--
Joseph S. Myers
jos...@codesourcery.com
Diagnostics should not end with '.' (or '\n', in some cases here); also
avoid starting with a capital letter in cases such as "Operand".
--
Joseph S. Myers
jos...@codesourcery.com
ize limit is 400 kB, not 100 kB. Hopefully that means you don't need
to compress so many bits and can attach more as plain patches for future
revisions.
--
Joseph S. Myers
jos...@codesourcery.com
On Tue, 23 Oct 2012, Joern Rennecke wrote:
> + tm_file="dbxelf.h elfos.h linux.h ${tm_file}"
Should be using gnu-user.h linux.h glibc-stdint.h, not linux.h on its own.
--
Joseph S. Myers
jos...@codesourcery.com
On Tue, 23 Oct 2012, Manuel López-Ibáñez wrote:
> The problem is how to represent that Wformat-y2k is enabled by
> -Wformat=X with X >= 2, while Wformat-zero-length is enabled by X >=1.
>
> One possiblity is to allow to specify a condition directly:
I guess that's re
ically or dynamically linked. This model is not fully implemented and
> +mostly treated as "small".
Say @samp{small} instead of using "" quotes in Texinfo sources.
--
Joseph S. Myers
jos...@codesourcery.com
Ping^3. This patch
<http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01907.html> (non-C parts) is
still pending review.
--
Joseph S. Myers
jos...@codesourcery.com
later point is at
which you check for such errors - but in any case, you need testcases for
these diagnostics on those cases to show that they aren't being lost.
In invoke.texi you have:
+@opindex flag_enable_cilkplus
But @opindex is for the user-visible options, not for internal variables.
an error with -Werror=return-local-addr. I've added
> two tests checking the -Werror form works.
The C front-end changes are OK.
--
Joseph S. Myers
jos...@codesourcery.com
at=
should take an arbitrary integer level (of which at present all those
above 2 are equivalent to 2, just as -O for n > 3 is equivalent to
-O3).
--
Joseph S. Myers
jos...@codesourcery.com
zers. But since the _set structures generally correspond to what
was set directly, whereas implicit setting by another option also replaces
the -1 value, this might only work given the extension of _set structures
to record the distance between the option passed by the user and the one
set, no
pilers without any need to
link in any stubs.
> The few additional tree nodes needed for UPC are defined
> in a language dependent tree definition file. The UPC-specific
Whatever those get gimplified to needs to be language-independent (that
is, handled after gimplification entirely by language-independent parts of
the compiler).
--
Joseph S. Myers
jos...@codesourcery.com
options.
Given that existing practice is passing pointers around, I'd think that's
appropriate for any new such functions / macros, unless and until we have
some clear notion of when functionality should or should not be a member
function of gcc_options.
--
Joseph S. Myers
jos...@codesourcery.com
et_flags that refer to global
options to end up not being lvalues at all. That helps ensure that option
settings are only modified in limited places that have options pointers.
It would be nice eventually for such things as "optimize" and "target"
attributes to be able to swap options structures, and to work closer to
how options on the command line are processed - for that, you want careful
control on what places actually modify options at all.
--
Joseph S. Myers
jos...@codesourcery.com
t-set-parameter): Use EnabledBy.
> (Wunused-parameter): Likewise.
> * opts.c (finish_options): Do not handle them explicitly.
> * opt-functions.awk (search_var_name): New.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
.c (c_common_handle_option): Do not set them here. Add
> comment.
> (c_common_post_options): Likewise.
> testsuite/
> * gcc.dg/Wstrict-overflow-24.c: New.
OK.
--
Joseph S. Myers
jos...@codesourcery.com
* Target changes, split out per target.
* Changes to existing C front-end files (including c-family).
* Changes to any other front ends, split out by front end.
* New front-end files.
* Changes to the language and target independent compiler (including build
system code).
* Library.
* Compil
indentation also looks suspicious - look at
the @@ -8859,6 +9048,23 @@ declspecs_add_qual hunk, for example, where
inconsistent indentation reveals that you are indenting with spaces in
some places, except for one line using a TAB (all new lines should be
indented with TABs for every 8 spaces).
--
Joseph S. Myers
jos...@codesourcery.com
rangement to be an option to the C front end, I
expect you shouldn't need upc/Make-lang.in either.)
--
Joseph S. Myers
jos...@codesourcery.com
On Mon, 15 Oct 2012, Gary Funck wrote:
> On 10/15/12 17:06:28, Joseph S. Myers wrote:
> > On Mon, 15 Oct 2012, Gary Funck wrote:
> > > Various UPC language related checks and operations
> > > are called in the "C" front-end and middle-end.
> > &g
Tested on x86_64-suse-linux, OK for mainline?
OK.
--
Joseph S. Myers
jos...@codesourcery.com
cks that return early for C (if needed).
--
Joseph S. Myers
jos...@codesourcery.com
Ping^2. This patch
<http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01907.html> (non-C parts) is
still pending review.
--
Joseph S. Myers
jos...@codesourcery.com
ION_* for such bits.
I don't know if with C++ it's possible to keep the names the same *and*
ensure that compile time errors occur if bits from different variables are
used together or a bit is used with the wrong variable *and* avoid any
other issues occurring as a consequence of such changes.
--
Joseph S. Myers
jos...@codesourcery.com
fused with -gdwarf-2. I don't think such cryptic forms should be
encouraged.
> Wstrict-aliasing 2
Ambiguous with the existing -Wstrict-aliasing option followed by a linker
input file called 2.
--
Joseph S. Myers
jos...@codesourcery.com
ere is some autoconf configuration about whether to
include a header, it's generally preferred to keep down the number of
places with such a conditional on host features (encapsulating whatever
features the header provides in some way so that other code can use them
unconditionally).
--
Joseph S. Myers
jos...@codesourcery.com
701 - 800 of 1676 matches
Mail list logo
