Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

2013-11-15 Thread Joshua J Cogliati
small nit for one ChangeLog entry, expressed below. If nobody objects in the next 48 hours, I'd say this is OK to commit with the nit fixed. I am not seeing your name in the MAINTAINERS file. Have you filed copyright assignment to the FSF and do you have it all sorted? Joshua J

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

2013-11-01 Thread Joshua J Cogliati
that are warned about by -Wfloat-conversion On 10/28/2013 02:50 AM, Dodji Seketeli wrote: Hello Joshua, Joshua J Cogliati jrinc...@yahoo.com writes: I am not certain that c.opt was modified correctly. I don't see any problem with the c.opt part. So unless another maintainer says

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

2013-10-27 Thread Joshua J Cogliati
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 == Administrivia == This is my first patch. I have emailed in the signed copyright transfer documents already. Several versions of this patch have been sent to the mailing list already. I believe that I have incorporated all comments into the

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

2013-10-22 Thread Joshua J Cogliati
by -Wfloat-conversion On 10/18/2013 09:21 AM, Joseph S. Myers wrote: On Fri, 18 Oct 2013, Joshua J Cogliati wrote: This patch does not change any of the non-commented c and c++ code. It changes the dg comments. Example: - fsi (3.1f); /* { dg-warning conversion } */ + fsi (3.1f); /* { dg

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

2013-10-18 Thread Joshua J Cogliati
On 10/14/2013 05:34 PM, Joseph S. Myers wrote: On Mon, 14 Oct 2013, Dodji Seketeli wrote: This patch has passes the existing -Wconversion testcases. It modifies Wconversion-real.c, Wconversion-real-integer.c and pr35635.c to be more specific If the patch passes existing tests, I'd be

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

2013-10-15 Thread Joshua J Cogliati
are welcome, and thank you for looking at it and commenting on it. Joshua J Cogliati jrinc...@yahoo.com writes: [...] A split out patch to make the floating conversions explicit is attached at the PR 53001 page, but is not included in this patch. It'd be nice to sent that split out patch

[PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

2013-10-13 Thread Joshua J Cogliati
Changes compared to previous version of patch: This patch only includes -Wfloat-conversion in -Wconversion, it does not include it in -Wextra It also changes several testcases to use -Wfloat-conversion instead of -Wconversion A split out patch to make the floating conversions explicit is attached

Patch to split out new warning flag for floating point conversion

2013-10-09 Thread Joshua J Cogliati
== Administrivia == This is my first patch. I have emailed in the signed copyright transfer documents already. == Description == This patch is a fix for Bug 53001 As required by the C and C++ standards, gcc automatically converts floating point numbers to lower precision or integer values.