Arsen Arsenović <ar...@aarsen.me> writes: > Evening! > > This patchset recovers support for building the toolchain tree with > in-tree libiconv being used for host modules and gettext. As spotted by > Kévin Le Gouguec <legoug...@adacore.com>, I accidentally removed this > functionality earlier. > > This patchset includes the patch sent as: > > https://inbox.sourceware.gcc-patches/20231221193243.368541-1-ar...@aarsen.me/ > > ... and so, supersedes that patchset. > > For the in-tree case, the old patch functionality was restored and > rebased on top of current iconv.m4. Of course, this does not work for > gettext, an out-of-tree lib depending on the in-tree libiconv, so, for > that case, we needed to provide the right information to configure, and > suppress logic in iconv.m4 using cache vars. > > Build-tested on arm64-apple-darwin21.6.0, and I intend to do further > testing tomorrow. > > OK for trunk? It would be good to get these patches into GCC 14. > > I apologize for being quite late with delivering these, I have, > unfortunately, been busied by various external factors. Hopefully, it > is not too late yet.
FWIW, I apologize too for not taking a stab at the fix; on our end, we pondered this briefly and figured we had no compelling reason to continue relying on in-tree libiconv builds, so we tweaked our packaging recipes to configure --with-libiconv-prefix and that was that. Thanks for finding the time to work on this!
