Re: [PATCH] libstdc++: remove unused variables

Recently merged by 86558afc09e65b172377d4e759b00094dd985e8a. Thanks! On Mon, 24 Aug 2020 at 13:26, Krystian Kuźniarek < krystian.kuznia...@gmail.com> wrote: > Hi, > > A description of the problem/bug and how your patch addresses it: > I've got a small patch for -Wunused-variable in system headers

Re: [PATCH] libstdc++: remove an ignored qualifier on function return type

Yeah, that's true. Ok, it's not applicable then. Thanks! On Thu, 29 Oct 2020 at 18:18, Jonathan Wakely wrote: > On Fri, 28 Aug 2020 at 07:56, Krystian Kuźniarek via Libstdc++ > wrote: > > > > > So then you need to produce a changelog entry by hand. > > I had this problem on some old Ubuntu 18.0

Re: [PATCH] libstdc++: remove an ignored qualifier on function return type

Actually ChangeLog also uses tabs, so it should be: libstdc++-v3/ChangeLog: * include/std/variant: Fix -Wignored-qualifiers in system headers. On Fri, 28 Aug 2020 at 08:55, Krystian Kuźniarek < krystian.kuznia...@gmail.com> wrote: > > So then you need to produce a changelog ent

Re: [PATCH] libstdc++: remove an ignored qualifier on function return type

> So then you need to produce a changelog entry by hand. I had this problem on some old Ubuntu 18.04. Anyway, here's new ChangeLog: libstdc++-v3/ChangeLog: * include/std/variant: Fix -Wignored-qualifiers in system headers. >That doesn't test this header at all. It do

Re: [PATCH] libstdc++: mark variables as possibly unused

>Test suite confirmation: >All tests pass. Tested on both Manjaro and some Ubuntu 18.04 with gcc10 and gcc8 respectively. Jonathan, one more thing. I hope it's what you asked for cause all I did was: make bootstrap make check On Fri, 28 Aug 2020 at 08:32, Krystian Kuźniarek < krystian.kuznia...@g

Re: [PATCH] libstdc++: mark variables as possibly unused

Ok, so here it is. New diff: diff --git a/libstdc++-v3/include/bits/atomic_base.h b/libstdc++-v3/include/bits/atomic_base.h index 015acef83c4..c4a763aae5c 100644 --- a/libstdc++-v3/include/bits/atomic_base.h +++ b/libstdc++-v3/include/bits/atomic_base.h @@ -231,7 +231,8 @@ _GLIBCXX_BEGIN_NAMESPACE

[PATCH] libstdc++: mark variables as possibly unused

Hi, First of all, sorry, I must have sent it as quoted-printable so spaces and tabs are preserved. A description of the problem/bug and how your patch addresses it: I've got a small patch for -Wunused-variable and -Wunused-parameter in system headers. These are needed either for: 1) __glibcxx_ass

[PATCH] libstdc++: remove unused variables

Hi, A description of the problem/bug and how your patch addresses it: I've got a small patch for -Wunused-variable in system headers. These aren't needed (i.e. no preprocessor conditions are there). Testcases: N/A, it's only a warning. ChangeLog: Sorry, contrib/mklog.py didn't quite work for me.

[PATCH] libstdc++: remove an ignored qualifier on function return type

Hi, First of all, sorry, I must have sent it as quoted-printable so spaces and tabs are preserved. A description of the problem/bug and how your patch addresses it: I've got a small patch for -Wignored-qualifiers in system headers. Testcases: N/A, it's only a warning. ChangeLog: Sorry, contrib/

[PATCH] libstdc++: fix misleading indentation

Hi, First of all, sorry, I must have sent it as quoted-printable so spaces and tabs are preserved. A description of the problem/bug and how your patch addresses it: I've got a small patch for -Wmisleading-indentation in system headers. Testcases: N/A, it's only a warning. ChangeLog: Sorry, cont

[PATCH] libstdc++: add parentheses around assignments used as truth values

Hi, A description of the problem/bug and how your patch addresses it: I've got a small patch for -Wparentheses in system headers. Testcases: N/A, it's only a warning. ChangeLog: Sorry, contrib/mklog.py didn't quite work for me. For some reason after instruction in line 129: "diff = PatchSet(data