Re: [hsa 0/10] Merge of HSA branch

Hi, On Mon, Dec 07, 2015 at 12:46:45PM +0100, Jakub Jelinek wrote: > On Mon, Dec 07, 2015 at 12:17:58PM +0100, Martin Jambor wrote: > > Because I have not been able to come up with any solution to failing > > libgomp/testsuite/libgomp.c++/target-2.C, I have disabled use of > >

[PR 68064] Testcase and an assert for an already fixed bug

kes a big difference for debugging). I have tossed this into a bootstrap and test run on an x86_64-linux and found no issues. I believe the patch is quite obvious and so will go ahead and commit it to trunk. Thanks, Martin Add asssert and testcase for PR 68064 2015-12-09 Martin J

Re: ipa-cp heuristics fixes

On Thu, Dec 10, 2015 at 05:56:26PM +0100, Jan Hubicka wrote: > > Is this really necessary, is it not enough to remove the assignment to > > ret below? If the parameter is not used, devirtualization time bonus, > > which you then rely on estimate_local_effects, should be zero for it. > > > > It is

[PR 66616] Check for thunks when adding extra constants to clones

Hi, PR 66616 happens because in find_more_scalar_values_for_callers_subset we do not do the same thunk checks like we do in propagate_constants_accross_call. I am in the process of bootstrapping and testing the following patch to fix it. OK if it passes? Thanks, Martin 2015-12-11 Martin

Re: ipa-cp heuristics fixes

Hi, On Fri, Dec 11, 2015 at 10:20:20PM +0100, Jan Hubicka wrote: > Actually I added > if (!ipa_is_param_used (info, i)) > > continue; > > shortcut to gather_context_independent_v

[PR 68851] Do not collect thunks in callect_callers

vector in that method (which is only used by IPA-CP at this one spot and IPA-SRA so it should be fine). Bootstrapped and tested on x86_64-linux. OK for trunk? And perhaps for the gcc-5 branch too? Thanks, Martin 2015-12-14 Martin Jambor PR ipa/68851 * cgraph.c

Re: [PATCH 4/5] Fix intransitive comparison in compare_access_positions

Hi, On Thu, Dec 17, 2015 at 12:02:11PM +0300, Yury Gribov wrote: > Another intransitive comparison in reload_pseudo_compare_func. Buggy > scenario: > 1) A and B are ints of equal presion so we return 0 > 2) C is REAL and thus can compare differently to A and B > > Cc-ing Martin who's the original

Re: [hsa 5/10] OpenMP lowering/expansion changes (gridification)

something for another patch. - "griddim" was changed to "_griddim_" at three places - I fixed formatting in all the suggested ways. Thanks, Martin 2015-12-16 Martin Jambor gcc/ * builtin-types.def: Removed a blank line. * gimple-low.c (lower_stmt)

[PATCH 0/4] Merge from HSA branch to trunk

and because I have the authority to self-approve the last one so although any comments are of course welcome, review of it is not strictly required. More details are in the individual email messages. Thanks, Martin Martin Jambor (4): Remove HSA build dependence HSA specific built-ins

[PATCH 1/4] Remove build dependence on HSA run-time

this change as the HSA maintainer or not but since Richi has seen the patch he put into the SUSE package, I hope it is not controversial. The patch has passed bootstrap and checking on x86_64-linux. OK for trunk? Thanks Martin 2016-11-11 Martin Liska Martin Jambor

[PATCH 3/4] OpenMP lowering changes from the hsa branch

ather late submission, they should not affect non-HSA code generation in any way (and apart from the optimization group stuff, really only two hunks even touch it, I believe). Thanks, Martin 2016-11-11 Martin Jambor gcc/ * dumpfile.h (OPTGROUP_OPENMP): Define. *

[PATCH 2/4] HSA specific built-ins

. OK for trunk? Thanks, Martin 2016-11-11 Martin Jambor gcc/ * hsa-builtins.def: New file. * Makefile.in (BUILTINS_DEF): Add hsa-builtins.def dependency. * builtins.def: Include hsa-builtins.def. (DEF_HSA_BUILTIN): New macro. fortran/ * f95-lang.c

[PATCH 4/4] Back-end and IPA bits of hsa branch merge

am going to approve this after the previous two patches are approved by others, but if anybody has any comment or suggestion, I will be glad to know. Thanks, Martin 2016-11-11 Martin Jambor Martin Liska * hsa.h (hsa_bb): Add method method append_phi

[PATCH] Add map clauses to libgomp test device-3.f90

scalars (i.e. firstprivate, as opposed to tofrom in 4.0) and the test itself needs to be fixed in the following way. OK for trunk? Thanks, Martin 2016-11-11 Martin Jambor * device-3.f90 (e_57_3): Add a mapping clause to target construct. diff --git a/libgomp/testsuite

[hsa branch] Move hsa headers to plugin libgomp directory

Hi, this is one of the last two commits to the hsa branch I made while preparing the merge to trunk, it moves headers generated from HSA documentation to the plugin directory. Committed to the HSA branch, it is part of the posted patches merging it to trunk. Thanks, Martin 2016-11-12 Martin

[hsa-branch] Replace all omp references of GPGPU with HSA grid

s part of the posted patches merging it to trunk. Thanks, Martin 2016-11-12 Martin Jambor gcc/ * omp-low.c (grid references): Replace GPGPU in the function comment with a reference to HSA grids. (grid_dist_follows_simple_pattern): Likewise. (grid_dist_fo

Re: [PATCH 1/4] Remove build dependence on HSA run-time

Hi, On Fri, Nov 18, 2016 at 11:23:10AM +0100, Jakub Jelinek wrote: > On Sun, Nov 13, 2016 at 08:02:41PM +0100, Martin Jambor wrote: > > @@ -143,6 +240,12 @@ init_enviroment_variables (void) > > suppress_host_fallback = true; > >else > > sup

Re: [PATCH 2/4] HSA specific built-ins

On Fri, Nov 18, 2016 at 11:27:24AM +0100, Jakub Jelinek wrote: > On Sun, Nov 13, 2016 at 08:39:35PM +0100, Martin Jambor wrote: > > Hello, > > > > this patch adds a small file hsa-builtins.def which defines a few > > builtins that I then use in OpenMP lowering and e

Re: [PATCH 3/4] OpenMP lowering changes from the hsa branch

Hi, On Fri, Nov 18, 2016 at 11:38:56AM +0100, Jakub Jelinek wrote: > On Sun, Nov 13, 2016 at 10:42:01PM +0100, Martin Jambor wrote: > > + size_t collapse = gimple_omp_for_collapse (for_stmt); > > + struct omp_for_data_loop *loops > > += (struct omp_for_data_lo

Re: [PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

Hi, On Fri, Nov 18, 2016 at 12:38:18PM +1100, kugan wrote: > Hi, > > I was relying on ipa_get_callee_param_type to get type of parameter and then > convert arguments to this type while computing jump functions. However, in > cases like shown in PR78365, ipa_get_callee_param_type, instead of givin

[PR 70965] Schedule extra pass_rebuild_cgraph_edges

pass is never nice, this is a consequence of splitting pass_build_ssa_passes out of early optimization passes so that pass_chkp can be in between. The patch below fices the ICE in PR 70965 and has passed bootstrap and testing on x86_64-linux. OK for trunk? Thanks, Martin 2016-11-24 Martin

Re: [PATCH] Fix PR78515

Hi, On Fri, Nov 25, 2016 at 12:01:38PM +0100, Richard Biener wrote: > > I am testing the following to beat some sanity into > compute_complex_assign_jump_func. That the function does not handle ternary operations (did we have them since the beginning?) is clearly my fault and the patch is fine.

[RFC] Assert DECL_ABSTRACT_ORIGIN is different from the decl itself

CE is better tan that even for users. What do you think? Would it be reasonable for trunk even now or should I queue it for the next stage1? Thanks, Martin gcc/cp/ 2016-11-28 Martin Jambor * error.c (dump_decl): Add an assert that DECL_ABSTRACT_ORIGIN is not the decl itself. ---

Re: [RFC] Assert DECL_ABSTRACT_ORIGIN is different from the decl itself

Hi Jeff, On Mon, Nov 28, 2016 at 08:46:05AM -0700, Jeff Law wrote: > On 11/28/2016 07:27 AM, Martin Jambor wrote: > > Hi, > > > > one of a number of symptoms of an otherwise unrelated HSA bug I've > > been debugging today is gcc crashing or hanging in the C++ pr

Re: [RFC] Assert DECL_ABSTRACT_ORIGIN is different from the decl itself

Hi, On Tue, Nov 29, 2016 at 10:17:02AM -0700, Jeff Law wrote: > On 11/29/2016 03:13 AM, Richard Biener wrote: > > On Mon, Nov 28, 2016 at 6:28 PM, Martin Jambor wrote: > > > Hi Jeff, > > > > > > On Mon, Nov 28, 2016 at 08:46:05AM -0700, Jeff Law wrote: &g

Fix PR fortran/71688

linux, is it OK for trunk and (after a while) for all active release branches? Thanks, Martin 2016-06-29 Martin Jambor PR fortran/71688 * trans-decl.c (gfc_generate_function_code): Use get_create rather than create to get a call graph node. testsuite/ gfortr

Re: [PATCH] disable IPA-cp cloning for functions with target_clones attribute

Hi, On Fri, Jun 24, 2016 at 01:41:05PM -0700, Evgeny Stupachenko wrote: > Hi, > > Fix ICE when IPA-cp and target_clones are applied to the same function. > Is the patch ok for trunk? I can't approve anything but since I wrote most of IPA-CP, it may count that I am fine with the patch. However,

Re: [PATCH] disable IPA-cp cloning for functions with target_clones attribute

Hi Jeff, On Wed, Jul 13, 2016 at 08:46:35AM -0600, Jeff Law wrote: > On 07/12/2016 03:31 AM, Martin Jambor wrote: > > Hi, > > > > On Fri, Jun 24, 2016 at 01:41:05PM -0700, Evgeny Stupachenko wrote: > > > Hi, > > > > > > Fix ICE when IPA-cp an

Re: [RFC][IPA-VRP] Add support for IPA VRP in ipa-cp/ipa-prop

Hi, thanks for working on extending IPA-CP in this way. I do have a few comments though: On Fri, Jul 15, 2016 at 02:46:50PM +1000, kugan wrote: > Hi, > > This patch extends ipa-cp/ipa-prop infrastructure to handle propagation of > VR. > Thanks, > > Kugan > > gcc/testsuite/ChangeLog: > > 2016

Ping: Fix PR fortran/71688

Ping (this time also CCing fort...@gcc.gnu and Honza). I really think this should be backported to 4.9 in time for the last release. Thanks, Martin - Original message from Martin Jambor - Date: Thu, 30 Jun 2016 11:13:17 +0200 From: Martin Jambor To: GCC Patches Subject: Fix PR

Re: [PATCH GCC]Remove support for -funsafe-loop-optimizations

Hi, On Mon, Jul 18, 2016 at 11:28:48AM -0400, NightStrike wrote: > Well, one thing to note is that the warning is an easy way to get a > notice of a possible missed optimization (and I have many more > occurrences of it in a particular code base that I use). If the > warning is highlighted potent

Re: [PATCH GCC/03]New option warning missed optimization on loops whose counter may overflow

On Thu, Jul 21, 2016 at 04:50:31PM +, Bin Cheng wrote: > Hi, > This patch adds new option -Wmissed-loop-optimizations warning on loops whose > counter may overflow, as well as makes -Wunsafe-loop-optimizations an alias > to the new option. > Bootstrap and test on x86_64 ongoing. Is it OK? I

Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.

Hi, sorry for the delay. Couple of weeks ago, I have cloned the github repo, lookaed at the diff against the trunk and reviewed that, which resulted in the following pile of notes. I hope they will be at least mostly understandable, if a little bit disorganized and perhaps sometimes inconsistent

Re: [RFC] Handle unary pass-through jump functions for ipa-vrp

Hi, On Tue, Oct 25, 2016 at 10:18:25AM +1100, kugan wrote: > Hi, > > Attached RFC patch handles unary pass-through jump functions for ipa-vrp > such that in the following case: > > int bar (int j) > { > foo (~j); > foo (abs (j)); > foo (j); > return 0; > } Thanks for working on this. A

Re: [ipa-vrp] ice in set_value_range

Hi, On Fri, Oct 28, 2016 at 01:58:13PM +1100, kugan wrote: > > Do I understand it correctly that extract_range_from_unary_expr deals > > with any potential type conversions better (compared to what you did > > before here)? > > Yes, this can be wrong at times too as reported in > https://gcc.gnu.

[PATCH] Print repeated rtl vector elements in a nicer way

following patch which just prints how many times a given value occurs. Honza has asked me yesterday to submit this hunk upstream so here it is. It has passed bootstrap and testing on x86_64-linux and aarch64-linux, OK for trunk? Thanks, Martin 2016-11-02 Jan Hubicka Martin Jambor

Re: [RFC] Handle unary pass-through jump functions for ipa-vrp

Hi, On Fri, Oct 28, 2016 at 02:03:47PM +1100, kugan wrote: > > ...snip... > > I have also separated the constant parameter conversion out and posted as > https://gcc.gnu.org/ml/gcc-patches/2016-10/msg02309.html. This is now > handling just unary pass-through jump functions. > > Bootstrapped and

Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.

Hi Pekka, On Sat, Oct 29, 2016 at 02:58:29PM +0300, Pekka Jääskeläinen wrote: > Hi Martin, > > Thanks for the comments and suggestions. Replies inline: > > On Thu, Oct 20, 2016 at 6:10 PM, Martin Jambor wrote: > > - Still quite few things need to be d

[PATCH] Remove a FIXME from verify_type_variant

trunk? Thanks, Martin 2016-11-03 Martin Jambor * tree.c (verify_type_variant): Use pointer comparison to check that TYPE_SIZE_UNIT match. --- gcc/tree.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/gcc/tree.c b/gcc/tree.c index 56cc653

Re: [PATCH] Print repeated rtl vector elements in a nicer way

On Thu, Nov 03, 2016 at 05:43:50PM +0100, Bernd Schmidt wrote: > On 11/03/2016 05:35 PM, Martin Jambor wrote: > > > > * print-rtl.c (print_rtx_operand_codes_E_and_V): Print how many times > > an element is repeated istead of printing each repeated element. >

[hsa-branch] Append UID to local variable names

, will include it in the merge to trunk too. Thanks, Martin 2016-11-07 Martin Jambor * hsa-gen.c (hsa_get_declaration_name): Append UID to local variable names. --- gcc/hsa-gen.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/gcc/hsa

[hsa-branch] Remove superfluous lastprivate check

, Martin 2016-11-07 Martin Jambor * omp-low.c (grid_target_follows_gridifiable_pattern): Do not check for lastprivate clause on teams construct. --- gcc/omp-low.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/gcc/omp-low.c b/gcc/omp-low.c index ac87a91..65b0ddc

[PATCH] A special predicate for type size equality

ot-so-good-idea-after-all :-) Bootstrapped and tested on x86_64-linux. Is it a good idea? OK for trunk? Thanks, Martin 2016-11-03 Martin Jambor * fold-const.c (type_sizes_equal_p): New function. * fold-const.h (type_sizes_equal_p): Declare. * ipa-dev

Re: [PATCH 3/4, libgomp] Resolve deadlock on plugin exit, HSA plugin parts

Hi, On Sat, Apr 16, 2016 at 03:38:57PM +0800, Chung-Lin Tang wrote: > Hi Martin, the attached patch reverts that queue_callback() change, and adds > some more descriptions in the comments to reflect the bool return changes. > Please see if they are acceptable. > If the rest of the patch-set is a

[PATCH] Verify __builtin_unreachable and __builtin_trap are not called with arguments

x86_64-linux (with all languages and Ada) and have also run a C, C++ and Fortran LTO bootstrap with the patch on the same architecture. OK for trunk? Thanks, Martin 2016-04-20 Martin Jambor * tree-cfg.c (verify_gimple_call): Check that calls to __builtin_unreachable or

Re: [PATCH] Verify __builtin_unreachable and __builtin_trap are not called with arguments

Hi, On Fri, Apr 22, 2016 at 09:24:31PM +0200, Richard Biener wrote: > On April 22, 2016 7:04:31 PM GMT+02:00, Martin Jambor wrote: > >Hi, > > > >this patch adds verification that __builtin_unreachable and > >__builtin_trap are not called with arguments. The problem

[PATCH] Verify that context of local DECLs is the current function

a SSA_NAME_IN_FREE_LIST when such an SSA_NAME is a base of a MEM_REF so I added that check too. Bootstrapped and tested on x86_64-linux, OK for trunk? Thanks, Martin 2016-04-21 Martin Jambor * tree-cfg.c (verify_var_parm_result_decl): New function. (verify_address): Call it

Re: [PATCH] Verify that context of local DECLs is the current function

Hi, On Tue, Apr 26, 2016 at 10:58:22AM +0200, Richard Biener wrote: > On Mon, Apr 25, 2016 at 3:22 PM, Martin Jambor wrote: > > Hi, > > > > the patch below moves an assert from expand_expr_real_1 to gimple > > verification. It triggers when we do a sloppy job o

[PR 70646] Store size to inlining predicate conditions

it for aggregate values. Bootstrapped, lto-bootstrapped and tested on x86_64-linux without any issues. OK for trunk and all active release branches? (4.9 still is active, right?) Thanks, Martin 2016-04-20 Martin Jambor PR ipa/70646 * ipa-inline.h (condition): New field

[PATCH] Respect --param ipa-max-agg-items=0

. Bootstrapped and lto-bootstrapped on x86_64-linux. OK for trunk? OK for all active release branches? Thanks, Martin 2016-04-18 Martin Jambor PR ipa/70646 * ipa-prop.c (determine_locally_known_aggregate_parts): Bail out early if parameter PARAM_IPA_MAX_AGG_ITEMS is

[PATCH 1/3] Indirect inlining of targets from references of global constants

on if we know that the parameter in question points to a constant variable. If this is deemed a god approach, we will probably want to add a similar bit to inlining conditions. Bootstrapped, lto-bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2016-05-11 Martin J

[PATCH 2/3] Const parameters are always unmodified

2016-05-10 Martin Jambor * ipa-prop.c (parm_preserved_before_stmt_p): Return true for loads from TREE_READONLY parameters. --- gcc/ipa-prop.c | 5 + 1 file changed, 5 insertions(+) diff --git a/gcc/ipa-prop.c b/gcc/ipa-prop.c index afbc32b..7d869ed 100644 --- a/gcc/ipa

[PATCH 3/3] Allow constant global VAR_DECLs in constant jump functions

? Thanks, Martin 2016-05-11 Martin Jambor PR ipa/69708 * ipa-cp.c (ipa_get_jf_pass_through_result): Allow non-ip constant input for NOP_EXPR pass-through functions. * ipa-prop.c (ipa_compute_jump_functions_for_edge): Allow aggregate global constant

Re: [patch] Fix PR tree-optimization/70884

rom doing anything for both testcases (PR 70884 and PR 70919). I have started a bootstrap and testing on x86_64 and i686 only a few moments ago but it would be great if someone also tried on an architecture for which the constant-pool SRA enhancement was intended, just

[PR 70857] Copy RESULT_DECL of HSA outlined kernel function

chokes on it. Bootstrapped and tested on x86_64 with hsa enabled. OK for trunk and the gcc-6 branch? Thanks, Martin 2016-05-12 Martin Jambor PR hsa/70857 * omp-low.c (grid_expand_target_grid_body): Copy RESULT_DECL of the outlined kernel function. --- gcc/omp-low.c

Re: [PATCH] Avoid out of scope access in hsa-dump.c

Hi, On Sun, Jul 22 2018, Bernd Edlinger wrote: > Hi, > > this fixes an use of a buffer after the block scope > in hsa-dump.c: "buf" is assigned to "name" and used after > the scope ends in a fprintf. > > I have not done any real checks, except boot-strapping with > all languages. > Is it OK for tr

[PR 80689] Copy small aggregates element-wise

be grateful for any comments, eventually I'd like to get approval to commit it to trunk. Thanks, Martin 2018-07-10 Martin Jambor PR target/80689 * tree-sra.h: New file. * ipa-prop.h: Moved declaration of build_ref_for_offset to tree-sra.h. * expr.c:

[PATCH] [C] Warn when calculating abs(unsigned_value)

moment is implicit), if someone really used it for some bit-tricks. Bootstrapped and tested on x86_64-linux, also with make info. What do you think, is this a good idea? Is it perhaps OK for trunk? Thanks, Martin 2018-08-14 Martin Jambor * doc/invoke.texi (Warning Options): Document

Re: [PATCH] Detect not-cloned new/delete operators in DCE.

Hi, unfortunately I cannot look into the problem now and I don't have my phone set up to review patches in a sane way, but to answer your question below... On Tue, Aug 06 2019, Martin Liška wrote: > On 8/6/19 2:42 PM, Martin Liška wrote: ... >> Hm, strange that the ISRA clones don't have n->cl

Re: [PATCH] Builtin function roundeven folding implementation

Hi Tejas, On Wed, Aug 14 2019, Tejas Joshi wrote: > Hi. > Here is a clean patch that does not fold roundeven resulting for > integer type and the conditions for folding functions > round/ceil/floor/roundeven and trunc only checks for signaling NaN. wouldn't checking for *signalling* NaNs mean usi

[PATCH 0/4] True IPA reimplementation of IPA-SRA (v4)

rm/ipa-sra). Thanks in advance for any questions, comments and suggestions, Martin 2019-08-20 Martin Jambor * coretypes.h (cgraph_edge): Declare. * ipa-param-manipulation.c: Rewrite. * ipa-param-manipulation.h: Likewise. * Makefile.in (GTFILES): Added ipa-param-mani

[PATCH 1/4] Remove old IPA-SRA, introduce tree-sra.h

This patch removes the old IPA-SRA. Please see the covert letter for more information about the whole patch-set. Martin 2019-07-23 Martin Jambor * dbgcnt.def: Remove eipa_sra. * passes.def: Remove old IPA-SRA. * tree-pass.h (make_pass_early_ipa_sra): Remove

[PATCH 3/4] New IPA-SRA implementation

the whole patch-set for more information. This is mostly only a rebase on the current trunk of the earlier submission, the only functional change is that the pass does not clone when all the work (unused parameter removal) has already been done by IPA-CP. Martin 2019-08-20 Martin Jambor

[PATCH 4/4] Modifications to the testsuite

n the options of an LTO testcase, that is the only change compared to the previous submission. Martin 2019-08-20 Martin Jambor * g++.dg/ipa/pr81248.C: Adjust dg-options and dump-scan. * gcc.dg/ipa/ipa-sra-1.c: Likewise. * gcc.dg/ipa/ipa-sra-10.c: Likewise. * gcc.dg/ip

Re: [PATCH] Builtin function roundeven folding implementation

Hi, On Wed, Aug 21 2019, Joseph Myers wrote: > On Wed, 21 Aug 2019, Martin Jambor wrote: > >> Hi Tejas, >> >> On Wed, Aug 14 2019, Tejas Joshi wrote: >> > Hi. >> > Here is a clean patch that does not fold roundeven resulting for >> > in

Re: [PATCH] Builtin function roundeven folding implementation

Hi, On Wed, Aug 21 2019, Joseph Myers wrote: > On Wed, 21 Aug 2019, Martin Jambor wrote: > >> - I have listed roundeven variants in extend.texi. If I did not find >> the right spot, I will gladly move to a more appropriate one. > > I don't think they

Re: [PATCH] i386: Roundeven expansion for SSE4.1+

Hi, On Wed, Jul 31 2019, Uros Bizjak wrote: > On Wed, Jul 31, 2019 at 7:51 AM Tejas Joshi wrote: >> >> Hi. >> >> > > * gcc.target/i386/avx-vround-roundeven-1.c: New test. >> > > * gcc.target/i386/avx-vround-roundeven-2.c: New test. >> > >> > roundss and roundsd are sse4_1 instructions, al

Re: [PATCH] Builtin function roundeven folding implementation

Hi, On Fri, Aug 23 2019, Tejas Joshi wrote: > Hi, > This is a full patch for the roundeven variants along with > documentation and additional testcases. The following code also > conforms to GNU's coding standards. > > Thanks, > Tejas > > 2019-08-22 Tejas Jos

[wwwdocs] Reflect __builtin_roundeven in gcc-10/changes.html

Hi Gerald, would the following be a good way to state in changes.html that we can fold __builtin_roundeven and expand it on an x86? Thanks, Martin Index: gcc-10/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-10/changes.html

[PR 91468] Small fixes in ipa-cp.c and ipa-prop.c

) merge_agg_lats_step contains a redundant condition too, but this one is an important correctness invariant, so I strengthened the already existing checking assert afterwards to be a normal assert. Passed bootstrap and testing on x86_64-linux. OK for trunk? Thanks, Martin 2019-08-26 Martin Jambor

[PR 91579] Avoid creating redundant PHI nodes in tail-call pass

ed by the following patch which just adds a bitmap to remember where there are non-default-defs passed to a tail-recursive call and then creates phi nodes only for such parameters. It has passed bootstrap and testing on x86_64-linux. OK for trunk? Martin 2019-08-28 Martin Jambor

Re: [PR 91579] Avoid creating redundant PHI nodes in tail-call pass

Hi, On Thu, Aug 29 2019, Richard Biener wrote: > On Thu, Aug 29, 2019 at 11:04 AM Martin Jambor wrote: >> >> Hi, >> >> when turning a tail-recursive call into a loop, the tail-call pass >> creates a phi node for each gimple_reg function parameter that has any &

Re: [PATCH] Setup predicate for switch default case in IPA (PR ipa/91089)

Hi, On Fri, Jul 12 2019, Feng Xue OS wrote: > IPA does not construct executability predicate for default case of switch > statement. > So execution cost of default case is not properly evaluated in IPA-cp, this > might > prevent function clone for function containing switch statement, if certain

Re: [PATCH] Generalized predicate/condition for parameter reference in IPA (PR ipa/91088)

Hi, On Fri, Jul 12 2019, Feng Xue OS wrote: > Current IPA-cp only generates cost-evaluating predicate for conditional > statement like > "if (param cmp const_val)", it is too simple and conservative. This patch > generalizes the > process to handle the form as T(param), a mathematical transforma

Re: [PATCH] Generalized predicate/condition for parameter reference in IPA (PR ipa/91088)

Hi, On Fri, Aug 30 2019, Feng Xue OS wrote: >> (It's a bad idea to make ChangeLog entries part of the patch, it won't >> apply to anyone, not even to you nowadays. ) > Got it. Will not include this kind of info in later patches. > >> I understand describing these things is difficult, but flatten i

Re: [PATCH] Handle loop fields in IPA ICF (PR ipa/90555).

Hi, On Tue, May 28 2019, Jakub Jelinek wrote: > On Tue, May 28, 2019 at 01:29:54PM +0200, Martin Liška wrote: >> Yes, makes sense. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ok, thanks. > >> > BTW, unrelated to this patch, what does ICF do if e.g. SSA_NAME_PT

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

;> > I see no reason why we should not constant propagate the return value. >> >> Indeed a good example. Make it work and add it to the testsuite ;) > > I think Martin Jambor is working on it. One needs -fno-tree-sra to > get this optimized :) > Othewise we punt

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

Hi, (now even including gcc-patches mailing list which we managed to drop again and Honza whom I forgot to CC the last time) On Thu, Jun 06 2019, Richard Biener wrote: > yOn Tue, 4 Jun 2019, Martin Jambor wrote: >> >> @@ -1822,9 +1863,19 @@ build_ref_for_model (location_t

Re: [PATCH V4] Find constant definition for by-ref argument using dominance information (PR ipa/90401)

Hi, On Thu, Jun 13 2019, Richard Biener wrote: > On Tue, Jun 11, 2019 at 4:22 AM Feng Xue OS > wrote: >> >> > For future reference, there should be two spaces at the end of the sentence >> > before */. You can use gcc/contrib/check_GNU_style.sh foo.patch to catch >> > stuff like this before pos

[PR 90889] Fix IPA-CP topological sorting

m now running LTO bootstrap and testing with all languages, OK if it passes? Thanks, Martin 2019-06-17 Martin Jambor PR ipa/90889 * ipa-cp.c (ignore_edge_p): Do not ignore edges when only the caller does not have flag_ipa_cp set. --- gcc/ipa-cp.c | 1 - 1 file chang

[PR 90939] Remove outdated assert in ipcp_bits_lattice::meet_with

GCC 9 and 8? Thanks, Martin 2019-06-24 Martin Jambor PR ipa/90939 * ipa-cp.c (ipcp_bits_lattice::meet_with): Remove assert. testsuite/ * g++.dg/lto/pr90939_[01].C: New test. --- gcc/ipa-cp.c | 1 - gcc/testsuite/g++.dg/lto/pr90939_0.C

Re: [PATCH] Remove quite obvious dead assignments.

Hi, On Wed, Jun 26 2019, Martin Liška wrote: > Hi. > > I've spent some with clang-static-analyzer and I analyzed the warnings > reported. > As always wit analyzers, majority of the issues are false positives, however > it caught > couple of real issues: > > https://gcc.gnu.org/bugzilla/show_bug.

Re: [PATCH] True IPA reimplementation of IPA-SRA

Hi, On Thu, Jun 13 2019, Jan Hubicka wrote: > Hi, > i read all changes except for ipa-sra itself. Here are some comments, > I will look at the remaining file next. > > Honza > > > diff --git a/gcc/cgraph.h b/gcc/cgraph.h > index 9a19d83fffb..3f838c08e76 100644 > --- a/gcc/cgraph.h > +++ b/gcc/cgr

Re: [PATCH] Construct ipa_reduced_postorder always for overwritable (PR ipa/89009).

Hi, On Mon, Feb 11 2019, Jan Hubicka wrote: >> Hi. >> >> IPA pure const should always construct ipa_reduced_postorder with >> possibility to cross AVAIL_INTERPOSABLE boundary. The pass itself >> can then properly stop propagation on these symbols. >> >> The patch is pre-approved by Honza. >> Pat

Re: [wwwdocs, doc] List -Wabsolute-value in gcc-9/changes.html

Hi Gerald and Martin, On Mon, Jan 28 2019, Gerald Pfeifer wrote: > Hi Martin, > > On Sat, 26 Jan 2019, Martin Jambor wrote: >>> What is a "wrong absolute value function"? That might be good to >>> show by means of an example? (Also in invoke.texi, wh

Re: [omp] Move NE_EXPR handling to omp_adjust_for_condition

Ping please, the issue is now PR 89302. Thanks, Martin On Fri, Feb 01 2019, Martin Jambor wrote: > Hi, > > even after the two previous HSA fixes, there is still one remining > libgomp failure in the testsuite when run on an HSA-enabled APU. The > problem is that grid calculatio

[PR 89330] Avoid adding dead speculative edges to inlinig heap

nonsensical edges in the heap. But in that case I'd add the assert in the next stage1. Bootstrapped and tested on x86_64-linux. IIUC, Martin even LTO-bootstrapped it. OK for trunk? Thanks, Martin 2019-02-15 Martin Jambor PR ipa/89330 * ipa-inline.c (can_inline_edge_p): Move

[PR 89209] Avoid segfault in a peculiar corner case in SRA

However, I have not managed to quickly create a testcase that would lead to it.. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2019-02-15 Martin Jambor PR tree-optimization/89209 * tree-sra.c (create_access_replacement): New optional parameter

Re: [PATCH, stage1] Construct ipa_reduced_postorder always for overwritable (PR ipa/89009).

Hi, On Tue, Feb 19 2019, Martin Liška wrote: > On 2/14/19 11:19 AM, Jan Hubicka wrote: >> ... >> Next stage1 we should also teach the callback to ignore edges of calls >> that are not being optimized. > > I'm sending patch for that. ... > gcc/ChangeLog: > > 2019-02-19 Martin Liska > >

Re: [wwwdocs, doc] List -Wabsolute-value in gcc-9/changes.html

Hi, On Wed, Feb 13 2019, Martin Jambor wrote: > Hi Gerald and Martin, > > On Mon, Jan 28 2019, Gerald Pfeifer wrote: >> Hi Martin, >> >> On Sat, 26 Jan 2019, Martin Jambor wrote: >>>> What is a "wrong absolute value function"? That might be go

[PR 87525] Zero local estimated benefit for cloning extern inline function

-25 Martin Jambor PR lto/87525 * ipa-cp.c (perform_estimation_of_a_value): Account zero time benefit for extern inline functions. testsuite/ * gcc.dg/ipa/ipcp-5.c: New test. --- gcc/ipa-cp.c | 17 gcc/testsuite/gcc.dg/ipa

[PR 85762, 87008, 85459] Relax MEM_REF check in contains_vce_or_bfcref_p

patch has passed bootstrap and testing on x86_64-linux and aarch64-linux, testing and bootstrap on i686-linux and ppc64le-linux are in progress. OK for trunk and then later on for the branch? Thanks, Martin 2019-03-01 Martin Jambor PR tree-optimization/85762 PR tree-optimiz

[PR 88235] Relax cgraph_node::clone_of_p to also look through former clones

on x86_64-linux, OK for trunk? OK for gcc-7-branch and gcc-8-branch too if a backport is straightforward (I have not tried yet) and it passes testing there too? Thanks, Martin 2019-03-05 Martin Jambor PR ipa/88235 * cgraph.h (cgraph_node): New inline method former_thunk_p

Re: [PR 85762, 87008, 85459] Relax MEM_REF check in contains_vce_or_bfcref_p

Hi, sorry for a somewhat long turnaround... On Tue, Mar 05 2019, Richard Biener wrote: > On Tue, 5 Mar 2019, Richard Biener wrote: > >> On Tue, 5 Mar 2019, Martin Jambor wrote: >> > @@ -1165,14 +1165,9 @@ contains_vce_or_bfcref_p (const_tree ref) >> >

Re: [PR 85762, 87008, 85459] Relax MEM_REF check in contains_vce_or_bfcref_p

l too. Thanks, Martin 2019-03-08 Martin Jambor PR tree-optimization/85762 PR tree-optimization/87008 PR tree-optimization/85459 * tree-sra.c (contains_vce_or_bfcref_p): New parameter, set the bool it points to if there is a type changing MEM_REF. Adjus

[PATCH] Fix dumping of "former thunk" info in cgraph dump

fomrer_thunk_p() looks at. Therefore I consider the following patch pre-approved and will commit it in a few moments (it has passed bootstrap and testing on an x86_64-linux machine). Thanks, Martin 2019-03-11 Martin Jambor * cgraph.c (cgraph_node::dump): Dump more info for former thunks

[PR 89546] Add forgotten requeing in propagate_subaccesses_across_link

RHS of some other assignment are re-queued. Well, it turns out I forgot to add that to one spot where that has to be done. Fixed with the patch below. Bootstrapped and tested on x86_64-linux. OK for trunk and gcc 8? Thanks, Martin 2019-03-14 Martin Jambor PR tree-optimization/89546

Re: Add a loop versioning pass

Hi, On Wed, Nov 28 2018, Richard Sandiford wrote: >>> The pass gives a 7.6% improvement on Cortex-A72 for 554.roms_r at -O3 >>> and a 2.4% improvement for 465.tonto. I haven't found any SPEC tests >>> that regress. >>> >>> Sizewise, there's a 10% increase in .text for both 554.roms_r and >>> 465

Re: [PING v2][PATCH] Make function clone name numbering independent.

Hi, On Tue, Sep 04 2018, Michael Ploujnikov wrote: > > I've tried building with numbered_clone_function_name replaced by > suffixed_function_name and with --enable-offload-targets=hsa and > didn't see any errors in gomp.exp. I don't have a readily available > HSA setup so if you could do a quick t

[PR 87615] Limit AA walking in hopefully all of IPA summary generation

os in -ftime-reportbut we still do not reach the 40 second compile time we get with -fno-ipa-cp -fno-inline. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2018-12-06 Martin Jambor PR ipa/87615 * ipa-prop.h (struct ipa_func_body_info): Replaced field aa_w

<    1   2   3   4   5   6   7   8   9   10   >