[PATCH v2] [testsuite] Fixup dg-options in {gcc, g++, gfortran}.dg/vect.exp tests

2024-03-13 Thread Maxim Kuvyrkov
Changes in v2: - Better changelog entry. - NFC. This patch has been tested on - aarch64-linux-gnu - arm-linux-gnueabihf (VFP, NEON disabled by default), - arm-none-eabi (Soft-FP) with the following [expected] differences in the test results: - FAIL now PASS [FAIL => PASS]: Execut

Re: [PATCH] [testsuite] Fixup dg-options in {gcc, g++, gfortran}.dg/vect.exp tests

2024-03-13 Thread Maxim Kuvyrkov
> On Mar 13, 2024, at 15:25, Richard Earnshaw > wrote: > > > > On 13/03/2024 10:58, Maxim Kuvyrkov wrote: >> This patch has been tested on >> - aarch64-linux-gnu >> - arm-linux-gnueabihf (VFP, NEON disabled by default), >> - arm-none-eabi (Soft-FP) &g

[PATCH] [testsuite] Fixup dg-options in {gcc, g++, gfortran}.dg/vect.exp tests

2024-03-13 Thread Maxim Kuvyrkov
This patch has been tested on - aarch64-linux-gnu - arm-linux-gnueabihf (VFP, NEON disabled by default), - arm-none-eabi (Soft-FP) with the following [expected] differences in the test results: - FAIL now PASS [FAIL => PASS]: Executed from: gcc:gcc.dg/vect/vect.exp gcc:gcc.dg/v

Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-03-01 Thread Maxim Kuvyrkov
> On Feb 29, 2024, at 21:59, Richard Earnshaw (lists) > wrote: > > On 29/02/2024 17:55, Andrew Pinski (QUIC) wrote: >>> -Original Message- >>> From: Maxim Kuvyrkov >>> Sent: Thursday, February 29, 2024 9:46 AM >>> To: Andrew Pins

Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-29 Thread Maxim Kuvyrkov
> On Feb 29, 2024, at 21:35, Andrew Pinski (QUIC) > wrote: > > > >> -Original Message- >> From: Evgeny Karpov >> Sent: Thursday, February 29, 2024 8:46 AM >> To: Andrew Pinski >> Cc: Richard Sandiford ; gcc- >> patc...@gc

Re: [PATCH v1 00/13] Add aarch64-w64-mingw32 target

2024-02-21 Thread Maxim Kuvyrkov
Hi Evgeny, Great job! For reference, here is a test build of this patch series using Linaro Toolchain CI: https://ci.linaro.org/view/tcwg-build/job/tcwg_gnu_mingw_build--master-woa64-build/9/artifact/artifacts/ -- Maxim Kuvyrkov https://www.linaro.org > On Feb 21, 2024, at 21:47, Evg

Re: [PATCH] tree-optimization/113576 - non-empty latch and may_be_zero vectorization

2024-01-25 Thread Maxim Kuvyrkov
tional-options "-march=skylake-avx512" } */ Please adjust the testcase; this fails on non-x86_64 targets, see [1] and [2]. [1] https://patchwork.sourceware.org/project/gcc/patch/20240124144159.51c503858...@sourceware.org/ [2] https://ci.linaro.org/job/tcwg_gcc_check--master-aarch

[PATCH] Make gcc.target/arm/bics_3.c testcase a bit more generic [PR113542]

2024-01-25 Thread Maxim Kuvyrkov
After fwprop improvement in r14-8319-g86de9b66480, codegen in bics_3.c test changed from "bics" to "bic" instruction, with the overall instruction stream remaining at the same quality. This patch makes the scan-assembler directive accept both "bics" and "bic". BEFORE r14-8319-g86de9b66480:

Re: [PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2024-01-17 Thread Maxim Kuvyrkov
> On Jan 17, 2024, at 19:05, Maxim Kuvyrkov wrote: > >> On Jan 17, 2024, at 19:02, Richard Biener wrote: >> >> On Wed, Jan 17, 2024 at 8:39 AM Maxim Kuvyrkov >> wrote: >>> >>>> On Jan 17, 2024, at 10:51, Richard Biener >>>> wr

[PATCH v1] Fix compare-debug bootstrap failure

2024-01-17 Thread Maxim Kuvyrkov
... caused by scheduler fix for PR96388 and PR111554. This patch adjusts decision sched-deps.cc:find_inc() to use length of dependency lists sans any DEBUG_INSN instructions. gcc/ChangeLog: * haifa-sched.cc (dep_list_size): Make global. * sched-deps.cc (find_inc): Use instead of

Re: [PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2024-01-17 Thread Maxim Kuvyrkov
> On Jan 17, 2024, at 19:02, Richard Biener wrote: > > On Wed, Jan 17, 2024 at 8:39 AM Maxim Kuvyrkov > wrote: >> >>> On Jan 17, 2024, at 10:51, Richard Biener >>> wrote: >>> >>> On Tue, Jan 16, 2024 at 3:52 PM Jeff Law wrote: >>

Re: [PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2024-01-16 Thread Maxim Kuvyrkov
> On Jan 17, 2024, at 10:51, Richard Biener wrote: > > On Tue, Jan 16, 2024 at 3:52 PM Jeff Law wrote: >> >> >> >> On 1/15/24 05:56, Maxim Kuvyrkov wrote: >>> Hi Vladimir, >>> Hi Jeff, >>> >>> Richard and Alexander have re

Re: [PATCH v3 8/8] Improve logging of scheduler dependency analysis context

2024-01-15 Thread Maxim Kuvyrkov
Dear scheduler maintainers, Gentle ping. This patch improves debugging output, it does not touch scheduling logic. On Wed, 22 Nov 2023 at 15:15, Maxim Kuvyrkov wrote: > Scheduler dependency analysis uses two main data structures: > 1. reg_pending_* data contains effects of INSN

Re: [PATCH v3 7/8] Improve logging of register data in scheduler dependency analysis

2024-01-15 Thread Maxim Kuvyrkov
Dear scheduler maintainers, Gentle ping. This patch improves debugging output, it does not touch scheduling logic. On Wed, 22 Nov 2023 at 15:15, Maxim Kuvyrkov wrote: > Scheduler dependency analysis uses two main data structures: > 1. reg_pending_* data contains effects of INSN

Re: [PATCH v3 6/8] sched_deps.cc: Simplify initialization of dependency contexts

2024-01-15 Thread Maxim Kuvyrkov
Dear scheduler maintainers, Gentle ping. This is a trivial cleanup. On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > gcc/ChangeLog: > > * sched-deps.cc (init_deps, init_deps_reg_last): Simplify. > (free_deps): Remove useless code. > --- > gcc/

Re: [PATCH v3 5/8] Add a bit more logging scheduler's dependency analysis

2024-01-15 Thread Maxim Kuvyrkov
Dear scheduler maintainers, Gentle ping. This is a trivial patch, which makes debugging sched-deps.cc slightly more enjoyable. On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > gcc/ChangeLog: > > * sched-deps.cc (sd_add_dep, find_inc): Add logging about >

Re: [PATCH v3 4/8] Improve and fix sched-deps.cc: dump_dep() and dump_lists().

2024-01-15 Thread Maxim Kuvyrkov
Dear scheduler maintainers, Gentle ping. This patch is borderline trivial and affects only the lucky few who debug sched-deps.cc code. OK to merge? On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > Better propagate flags from dump_lists() into dump_dep() and > add a missing

Re: [PATCH v3 3/8] Simplify handling of INSN_ and EXPR_LISTs in sched-rgn.cc

2024-01-15 Thread Maxim Kuvyrkov
Dear RTL maintainers, Gently ping. This patch adds a couple of new functions to lists.cc, which then are used to simplify logic in the scheduler. OK to merge? On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > This patch simplifies logic behind deps_join(), which will be > importa

Re: [PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2024-01-15 Thread Maxim Kuvyrkov
Hi Vladimir, Hi Jeff, Richard and Alexander have reviewed this patch and [I assume] have no further comments. OK to merge? On Wed, 22 Nov 2023 at 15:14, Maxim Kuvyrkov wrote: > This patch avoids sched-deps.cc:find_inc() creating exponential number > of dependencies, which become memo

[PATCH v3 7/8] Improve logging of register data in scheduler dependency analysis

2023-11-22 Thread Maxim Kuvyrkov
Scheduler dependency analysis uses two main data structures: 1. reg_pending_* data contains effects of INSN on the register file, which is then incorporated into ... 2. deps_desc object, which contains commulative information about all instructions processed from deps_desc object's initializa

[PATCH v3 4/8] Improve and fix sched-deps.cc: dump_dep() and dump_lists().

2023-11-22 Thread Maxim Kuvyrkov
Better propagate flags from dump_lists() into dump_dep() and add a missing "]" in dump_lists(). gcc/ChangeLog: * sched-deps.cc (DUMP_DEP_PRO): Improve comment. (dump_dep_flags): Remove. (DUMP_LISTS_SIZE, DUMP_LISTS_DEPS, DUMP_LISTS_ALL): Continue numbering from DUM

[PATCH v3 3/8] Simplify handling of INSN_ and EXPR_LISTs in sched-rgn.cc

2023-11-22 Thread Maxim Kuvyrkov
This patch simplifies logic behind deps_join(), which will be important for the upcoming improvements of sched-deps.cc logging. The only functional change is that when deps_join() is called with empty state for the 2nd argument, it will not reverse INSN_ and EXPR_LISTs in the 1st argument. Before

[PATCH v3 8/8] Improve logging of scheduler dependency analysis context

2023-11-22 Thread Maxim Kuvyrkov
Scheduler dependency analysis uses two main data structures: 1. reg_pending_* data contains effects of INSN on the register file, which is then incorporated into ... 2. deps_desc object, which contains commulative information about all instructions processed from deps_desc object's initializa

[PATCH v3 2/8] Unify implementations of print_hard_reg_set()

2023-11-22 Thread Maxim Kuvyrkov
We currently have 3 implementations of print_hard_reg_set() (all with the same name!) in ira-color.cc, ira-conflicts.cc, and sel-sched-dump.cc. This patch generalizes implementation in ira-color.cc, and uses it in all other places. The declaration is added to hard-reg-set.h. The motivation for t

[PATCH v3 6/8] sched_deps.cc: Simplify initialization of dependency contexts

2023-11-22 Thread Maxim Kuvyrkov
gcc/ChangeLog: * sched-deps.cc (init_deps, init_deps_reg_last): Simplify. (free_deps): Remove useless code. --- gcc/sched-deps.cc | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc index 2a87158ba4b..e0d3c97d935

[PATCH v3 5/8] Add a bit more logging scheduler's dependency analysis

2023-11-22 Thread Maxim Kuvyrkov
gcc/ChangeLog: * sched-deps.cc (sd_add_dep, find_inc): Add logging about dependency creation. --- gcc/sched-deps.cc | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc index 4d357079a7a..2a87158b

[PATCH v3 0/8] Avoid exponential behavior in scheduler and better logging

2023-11-22 Thread Maxim Kuvyrkov
g/bugzilla/show_bug.cgi?id=111554 Maxim Kuvyrkov (8): sched-deps.cc (find_modifiable_mems): Avoid exponential behavior Unify implementations of print_hard_reg_set() Simplify handling of INSN_ and EXPR_LISTs in sched-rgn.cc Improve and fix sched-deps.cc: dump_dep() and dump_lists(). Add a bit mo

[PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-22 Thread Maxim Kuvyrkov
This patch avoids sched-deps.cc:find_inc() creating exponential number of dependencies, which become memory and compilation time hogs. Consider example (simplified from PR96388) ... === sp=sp-4 // sp_insnA mem_insnA1[sp+A1] ... mem_insnAN[sp+AN] sp=sp-4 // sp_insnB mem_insnB1[sp+B1] ... mem_insnBM[

Re: [PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-21 Thread Maxim Kuvyrkov
> On Nov 20, 2023, at 20:30, Alexander Monakov wrote: > > > On Mon, 20 Nov 2023, Maxim Kuvyrkov wrote: > >>> On Nov 20, 2023, at 17:52, Alexander Monakov wrote: >>> >>> >>> On Mon, 20 Nov 2023, Maxim Kuvyrkov wrote: >>> >>

Re: [PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-20 Thread Maxim Kuvyrkov
> On Nov 20, 2023, at 17:45, Richard Biener wrote: > > On Mon, Nov 20, 2023 at 2:42 PM Maxim Kuvyrkov > wrote: >> >>> On Nov 20, 2023, at 17:09, Richard Biener >>> wrote: >>> >>> On Mon, Nov 20, 2023 at 1:08 PM Maxim Kuvyrkov >>&

[PATCH v2] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-20 Thread Maxim Kuvyrkov
This patch avoids sched-deps.cc:find_inc() creating exponential number of dependencies, which become memory and compilation time hogs. Consider example (simplified from PR96388) ... === sp=sp-4 // sp_insnA mem_insnA1[sp+A1] ... mem_insnAN[sp+AN] sp=sp-4 // sp_insnB mem_insnB1[sp+B1] ... mem_insnBM[

Re: [PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-20 Thread Maxim Kuvyrkov
> On Nov 20, 2023, at 17:52, Alexander Monakov wrote: > > > On Mon, 20 Nov 2023, Maxim Kuvyrkov wrote: > >> This patch avoids sched-deps.cc:find_inc() creating exponential number >> of dependencies, which become memory and compilation time hogs. >> Consider

Re: [PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-20 Thread Maxim Kuvyrkov
> On Nov 20, 2023, at 17:09, Richard Biener wrote: > > On Mon, Nov 20, 2023 at 1:08 PM Maxim Kuvyrkov > wrote: >> >> This patch avoids sched-deps.cc:find_inc() creating exponential number >> of dependencies, which become memory and compilation time hogs. >&g

[PATCH 1/1] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-20 Thread Maxim Kuvyrkov
This patch avoids sched-deps.cc:find_inc() creating exponential number of dependencies, which become memory and compilation time hogs. Consider example (simplified from PR96388) ... === sp=sp-4 // sp_insnA mem_insnA1[sp+A1] ... mem_insnAN[sp+AN] sp=sp-4 // sp_insnB mem_insnB1[sp+B1] ... mem_insnBM[

[PATCH 0/1] Avoid exponential behavior in scheduler and better logging

2023-11-20 Thread Maxim Kuvyrkov
logging patches to be published, as it'll take me another week to clean them up. [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96388 [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111554 Maxim Kuvyrkov (1): sched-deps.cc (find_modifiable_mems): Avoid exponential behavior gc

Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273]

2023-11-09 Thread Maxim Kuvyrkov
save the state of DFA before the initial advance_one_cycle(), and then restore it if no real insns have been scheduled. Kind regards, -- Maxim Kuvyrkov https://www.linaro.org > On Nov 8, 2023, at 06:49, Kewen.Lin wrote: > > Hi, > > Gentle ping this: > > https://gc

[PATCH v2] Format gotools.sum closer to what DejaGnu does

2023-11-03 Thread Maxim Kuvyrkov
extract values, and gotools.sum provided "Running ". Note that libgo.sum, which also uses Makefile logic to generate DejaGnu-like output, already has "..." suffix. gotools/ChangeLog: * Makefile.am: Update "Running ..." output * Makefile.i

Re: [PATCH] Format gotools.sum closer to what DejaGnu does

2023-11-02 Thread Maxim Kuvyrkov
> On Nov 2, 2023, at 21:02, rep.dot@gmail.com wrote: > > Hi Maxim! > > Many thanks for the patch! Quick question below.. > > On 2 November 2023 13:48:55 CET, Maxim Kuvyrkov > wrote: >> ... to restore compatability with validate_failures.py . >> The t

Re: [PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

2023-11-02 Thread Maxim Kuvyrkov
Patch proposed at https://gcc.gnu.org/pipermail/gcc-patches/2023-November/635000.html -- Maxim Kuvyrkov https://www.linaro.org > On Sep 27, 2023, at 18:47, Maxim Kuvyrkov wrote: > > Hi Bernhard, > > Thanks, I meant to fix this, but forgot. > > The underlying problem he

[PATCH] Format gotools.sum closer to what DejaGnu does

2023-11-02 Thread Maxim Kuvyrkov
... to restore compatability with validate_failures.py . The testsuite script validate_failures.py expects "Running ..." to extract values, and gotools.sum provided "Running ". Note that libgo.sum, which also uses Makefile logic to generate DejaGnu-like output, already has "..." suffix. gotools

Re: [PATCH v2] ARM: Block predication on atomics [PR111235]

2023-10-03 Thread Maxim Kuvyrkov
Cauldron presentation. "Green/Red" in patchwork mean the usual PASS/FAIL. It's only in post-commit CI in jenkins interface green and red mean something different. -- Maxim Kuvyrkov https://www.linaro.org

Re: [PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

2023-09-27 Thread Maxim Kuvyrkov
t; . My preferred way of fixing this is to make go's testsuite print out "..." . We have a similar patch for glibc [1]. [1] https://sourceware.org/pipermail/libc-alpha/2023-June/148702.html -- Maxim Kuvyrkov https://www.linaro.org > On Sep 26, 2023, at 19:46, Bernhard Reutner

Re: PATCH v6 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces.

2023-09-18 Thread Maxim Kuvyrkov via Gcc-patches
://patchwork.sourceware.org/project/gcc/patch/5ad7cdca-63e1-73af-b38d-d58898e21...@linux.ibm.com/ [2] https://patchwork.sourceware.org/project/gcc/patch/65ed79a3-9964-dd50-39cb-98d5dbc72...@linux.ibm.com/ -- Maxim Kuvyrkov https://www.linaro.org > On Sep 18, 2023, at 09:59, Ajit Agarwal via

Re: [Linaro-TCWG-CI] gcc patch #75674: FAIL: 68 regressions

2023-09-12 Thread Maxim Kuvyrkov via Gcc-patches
ist/ [2] https://sourceware.org/bugzilla/show_bug.cgi?id=29713 Thanks! -- Maxim Kuvyrkov https://www.linaro.org > On Sep 12, 2023, at 02:58, ci_not...@linaro.org wrote: > > Dear contributor, our automatic CI has detected problems related to your > patch(es). Please find some details below

Re: [PATCH v6 0/4] P1689R5 support

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
al compiler error: Segmentation fault) FAIL: g++.dg/modules/map-2.C -std=c++2b (test for excess errors) === Thanks, -- Maxim Kuvyrkov https://www.linaro.org > > [P1689R5]: https://isocpp.org/files/papers/P1689R5.html > > I've also added patches to include imported module

Re: [PATCH] analyzer: Standalone OOB-warning [PR109437, PR109439]

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
, line 17) FAIL: g++.dg/analyzer/pr100244.C -std=c++17 (test for warnings, line 17) FAIL: g++.dg/analyzer/pr100244.C -std=c++20 (test for warnings, line 17) === gcc tests === Running gcc:gcc.dg/analyzer/analyzer.exp ... FAIL: gcc.dg/analyzer/pr101962.c (test for warnings, line 19) Thanks, -

Re: [PATCH] Handle FMA friendly in reassoc pass

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
chmarks. Hi Cui, I'm seeing a 4% slowdown on 436.cactusADM from SPEC CPU2006 on aarch64-linux-gnu (Cortex-A57) when compiling with "-O2 -flto". All other benchmarks seem neutral to this patch, and I didn't observe the slow down with plain -O2 no-LTO or with -O3. I

Re: [committed] libstdc++: Fix code size regressions in std::vector [PR110060]

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
at has SPEC CPU2017 license, and I can post details to you privately. Kind regards, -- Maxim Kuvyrkov https://www.linaro.org > On Jun 1, 2023, at 19:09, Jonathan Wakely via Gcc-patches > wrote: > > Tested powerpc64le-linux. Pusshed to trunk. > > -- >8 -- > > M

Re: [r14-1579 Regression] FAIL: gfortran.dg/gomp/target-update-1.f90 -O scan-tree-dump gimple "#pragma omp target update to\\(c \\[len: [0-9]+\\]\\) to\\(present:a \\[len: [0-9]+\\]\\) to\\(e \\[len:

2023-06-07 Thread Maxim Kuvyrkov via Gcc-patches
(e [len: 4]) from(d [len: 4]) from(present:b [len: 4000]) Let me know if you need any help in troubleshooting this. -- Maxim Kuvyrkov https://www.linaro.org > On Jun 7, 2023, at 02:50, haochen.jiang via Gcc-patches > wrote: > > On Linux/x86_64, > > 4ede915d5dde935a16df2c

Re: [PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

2023-06-05 Thread Maxim Kuvyrkov via Gcc-patches
> On Jun 3, 2023, at 19:17, Jeff Law wrote: > > On 6/2/23 09:20, Maxim Kuvyrkov via Gcc-patches wrote: >> This patch adds tracking of current testsuite "tool" and "exp" >> to the processing of .sum files. This avoids aliasing between >> tests from

Re: [pushed] analyzer: implement various atomic builtins [PR109015]

2023-06-05 Thread Maxim Kuvyrkov via Gcc-patches
Hi David, Hm, I'm seeing this failure only in pre-commit testing, but I don't see it in our post-commit testing of gcc:master. Does this patch rely on your other patch committed just before this one? -- Maxim Kuvyrkov https://www.linaro.org > On Jun 3, 2023, at 09:23, Maxim Ku

Re: [pushed] analyzer: implement various atomic builtins [PR109015]

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
/results.compare/*view*/ Thanks! -- Maxim Kuvyrkov https://www.linaro.org > On Jun 2, 2023, at 17:32, David Malcolm via Gcc-patches > wrote: > > This patch implements many of the __atomic_* builtins from > sync-builtins.def as known_function subclasses within the analyzer. &g

[PATCH 12/12] [contrib] validate_failures.py: Ignore stray filesystem paths in results

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This patch simplifies comparison of results that have filesystem paths. E.g., (assuming different values of ): Running /home/user/gcc-N/gcc/testsuite/gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp ... ERROR: tcl error sourcing /home/user/gcc-N/gcc/testsuite/gcc.target/aarch64/sve/acle/aa

[PATCH 08/12] [contrib] validate_failures.py: Support "$tool:" prefix in exp names

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
From: Christophe Lyon This makes it easier to extract the $tool:$exp pair when iterating over failures/flaky tests, which, in turn, simplifies re-running testsuite parts that have unexpected failures or passes. --- contrib/testsuite-management/validate_failures.py | 8 +--- 1 file changed, 5

[PATCH 11/12] [contrib] validate_failures.py: Add "--expiry_date YYYYMMDD" option

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This option sets "today" date to compare expiration entries against. Setting expiration date into the future allows re-detection of flaky tests and creating fresh entries for them before the current flaky entries expire. --- .../testsuite-management/validate_failures.py | 24 +-- 1

[PATCH 09/12] [contrib] validate_failures.py: Improve error output

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
From: Thiago Bauermann - Print message in case of broken sum file error. - Print error messages to stderr. The script's stdout is, usually, redirected to a file, and error messages shouldn't go there. --- contrib/testsuite-management/validate_failures.py | 5 - 1 file changed, 4 insertion

[PATCH 07/12] [contrib] validate_failures.py: Use exit code "2" to indicate regression

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
... in the results. Python exits with code "1" on exceptions and internal errors, which we use to detect failure to parse results. --- contrib/testsuite-management/validate_failures.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/testsuite-management/validate_failur

[PATCH 05/12] [contrib] validate_failures.py: Add more verbosity levels

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
... to control validate_failures.py output --- .../testsuite-management/validate_failures.py | 82 +++ 1 file changed, 46 insertions(+), 36 deletions(-) diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management/validate_failures.py index 1bd09e

[PATCH 06/12] [contrib] validate_failures.py: Be more stringent in parsing result lines

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
Before this patch we would identify malformed line "UNRESOLVEDTest run by tcwg-buildslave on Mon Aug 23 10:17:50 2021" as an interesting result, only to fail in TestResult:__init__ due to missing ":" after UNRESOLVED. This patch makes all places that parse result lines use a single compiled regex.

[PATCH 02/12] [contrib] validate_failures.py: Support expiry attributes in manifests

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
--- contrib/testsuite-management/validate_failures.py | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management/validate_failures.py index 94ba2e58b51..7351ba120b7 100755 --- a/contrib/testsuite-m

[PATCH 03/12] [contrib] validate_failures.py: Read in manifest when comparing build dirs

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This allows comparison of two build directories with a manifest listing known flaky tests on the side. --- contrib/testsuite-management/validate_failures.py | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/contrib/testsuite-management/validate_failures.py b/cont

[PATCH 10/12] [contrib] validate_failures.py: Add new option --invert_match

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This option is used to detect flaky tests that FAILed in the clean build (or manifest), but PASSed in the current build (or manifest). The option inverts output logic similar to what "-v/--invert-match" does for grep. --- .../testsuite-management/validate_failures.py | 34 +-- 1 f

[PATCH 04/12] [contrib] validate_failures.py: Simplify GetManifestPath()

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
... and don't require a valid build directory when no data from it is necessary. --- contrib/testsuite-management/validate_failures.py | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management

[PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This patch adds tracking of current testsuite "tool" and "exp" to the processing of .sum files. This avoids aliasing between tests from different testsuites with same name+description. E.g., this is necessary for testsuite/c-c++-common, which is ran for both gcc and g++ "tools". This patch chang

[contrib] Extend and improve validate_failures.py

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This patch series extends and improves validate_failures.py script to provide a powerful tool to handle DejaGnu test results in automated CI environment. Linaro TCWG uses validate_failures.py to ... - compare test results without human oversight, - detect unexpected FAILs vs baseline, - detect une

Re: [PATCH] Couple of debug dump improvements to scheduler (no code-gen changes)

2021-08-17 Thread Maxim Kuvyrkov via Gcc-patches
On Fri, 30 Aug 2019 at 01:57, Jeff Law wrote: > On 8/29/19 9:44 AM, Maxim Kuvyrkov wrote: > > Hi, > > > > The first patch adds ranking statistics for autoprefetcher heuristic. > > > > The second one makes it easier to diff scheduler debug dumps by adding &

Re: [PR91598] Improve autoprefetcher heuristic in haifa-sched.c

2021-08-17 Thread Maxim Kuvyrkov via Gcc-patches
inor > codesize differences). So I think your proposed patch is OK as is. > > Cheers, > Wilco > > -- Maxim Kuvyrkov www.linaro.org 0001-Improve-autoprefetcher-heuristic-partly-fix-regressi.patch Description: Binary data

Re: disable -Warray-bounds in libgo (PR 101374)

2021-07-09 Thread Maxim Kuvyrkov via Gcc-patches
nst U_8 * newval, U_8 *ptr); #define __kernel_cmpxchg64 (*(__kernel_cmpxchg64_t *) 0x0f60) /* Kernel helper for memory barrier. */ typedef void (__kernel_dmb_t) (void); #define __kernel_dmb (*(__kernel_dmb_t *) 0x0fa0) /* Kernel helper page version number. */ #define __kernel_helper_version (*(unsigned int *)0x0ffc) === -- Maxim Kuvyrkov https://www.linaro.org

Re: [r12-2132 Regression] FAIL: g++.dg/warn/Warray-bounds-20.C -std=gnu++98 note (test for warnings, line 55) on Linux/x86_64

2021-07-09 Thread Maxim Kuvyrkov via Gcc-patches
0.C -std=gnu++2a note (test for warnings, > line 38) > FAIL: g++.dg/warn/Warray-bounds-20.C -std=gnu++2a note (test for warnings, > line 55) > FAIL: g++.dg/warn/Warray-bounds-20.C -std=gnu++98 note (test for warnings, > line 38) > FAIL: g++.dg/warn/Warray-bounds-20.C -std=

[PATCH] [contrib] Remove broken compareSumTests3 script

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
Hi Matthew, Hi Sebastian, This patch removes compareSumTests3, which appears to be broken. It tries to call compareSumFiles(), which is nowhere to be found and was never present in the GCC repo. OK to remove? Regards, -- Maxim Kuvyrkov https://www.linaro.org 0001-contrib-Remove-broken

Re: [PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
> On Jul 2, 2021, at 5:44 PM, Christophe Lyon > wrote: > > > > On Fri, Jul 2, 2021 at 4:29 PM Jakub Jelinek via Gcc-patches > wrote: > On Fri, Jul 02, 2021 at 05:20:33PM +0300, Maxim Kuvyrkov wrote: > > Hi Jakub, > > > > Thanks for helping m

[PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
Hi Jakub, Thanks for helping me on IRC with debugging testsuite problems. Does this write up look good? Regards, -- Maxim Kuvyrkov https://www.linaro.org 0001-Add-description-of-how-testsuite-parallelization-wor.patch Description: Binary data

Re: [PATCH] Avoid loading an undefined value in the ranger_cache constructor.

2021-06-17 Thread Maxim Kuvyrkov via Gcc-patches
> On 16 Jun 2021, at 20:14, Andrew MacLeod wrote: > > On 6/16/21 5:41 AM, Maxim Kuvyrkov wrote: >> >>> + m_new_value_p = state; >>> + return ret; >>> } >>>// Dump the caches for basic block BB to file F. >> Thanks, >> >

Re: [PATCH] tree-optimization PR/101014 - Limit new value calculations to first order effects.

2021-06-16 Thread Maxim Kuvyrkov via Gcc-patches
> > -void > -ranger_cache::enable_new_values () > -{ > - m_new_value_p = true; > -} > - > -// Disable new value querying. > - > -void > -ranger_cache::disable_new_values () > +bool > +ranger_cache::enable_new_values (bool state) > { > - m_new_value_p

Re: [PATCH] middle-end/94188 fix fold of addr expression generation

2020-03-18 Thread Maxim Kuvyrkov via Gcc-patches
r: in gen_movsi, at config/arm/arm.md:6291 00:01:29 make[2]: *** [sound/drivers/serial-u16550.o] Error 1 Would you please investigate? Let me know if you need any help reproducing the problem. Kernel’s build line is (assuming cross-compilation): make CC=/path/to/arm-linux-gnueabihf-gcc

Re: One more patch for PR91333

2020-02-18 Thread Maxim Kuvyrkov
> On Feb 18, 2020, at 6:30 PM, Vladimir Makarov wrote: > > On 2/17/20 10:08 AM, Maxim Kuvyrkov wrote: >> Hi Vladimir, >> >> This patch increases code size at -Os on arm-linux-gnueabihf by 1% (with no >> code-size reductions) on several SPEC CPU2006

Re: One more patch for PR91333

2020-02-17 Thread Maxim Kuvyrkov
,99183,99863 Could you look into whether these regressions can be avoided? Thanks, -- Maxim Kuvyrkov https://www.linaro.org > On Feb 2, 2020, at 7:46 PM, Vladimir Makarov wrote: > > The previous patch for > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91333 > > resulted

Re: [PATCH] simplify-rtx: Extend (truncate (*extract ...)) fold [PR87763]

2020-02-03 Thread Maxim Kuvyrkov
these can be avoided? [Let me know if you need help reproducing this problem.] Thank you, -- Maxim Kuvyrkov https://www.linaro.org > On Jan 27, 2020, at 7:41 PM, Richard Sandiford > wrote: > > In the gcc.target/aarch64/lsl_asr_sbfiz.c part of this PR, we have: > > Fa

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-09-13 Thread Maxim Kuvyrkov
> On Aug 24, 2019, at 12:30 AM, Joseph Myers wrote: > > On Fri, 23 Aug 2019, Maxim Kuvyrkov wrote: > >> I propose that we switch to gcc-pretty.git repository, because it has >> accurate Committer and Author fields. Developer names and email >> addresses are extr

Re: [PR91598] Improve autoprefetcher heuristic in haifa-sched.c

2019-08-29 Thread Maxim Kuvyrkov
> On Aug 29, 2019, at 7:29 PM, Richard Biener > wrote: > > On August 29, 2019 5:40:47 PM GMT+02:00, Maxim Kuvyrkov > wrote: >> Hi, >> >> This patch tweaks autoprefetcher heuristic in scheduler to better group >> memory loads and stores together. &

[PATCH] Couple of debug dump improvements to scheduler (no code-gen changes)

2019-08-29 Thread Maxim Kuvyrkov
Hi, The first patch adds ranking statistics for autoprefetcher heuristic. The second one makes it easier to diff scheduler debug dumps by adding more context lines for diff at clock increments. OK to commit? -- Maxim Kuvyrkov www.linaro.org 0002-Add-missing-entry-for-rank_for_schedule

[PR91598] Improve autoprefetcher heuristic in haifa-sched.c

2019-08-29 Thread Maxim Kuvyrkov
etcher-friendly schedule we should prioritize "irrelevant" instructions before memory writes. Obvious patch to implement the above is attached. It brings 70% of regressed performance on this testcase back. OK to commit? Regards, -- Maxim Kuvyrkov www.linaro.org 0001-Imp

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-08-22 Thread Maxim Kuvyrkov
> On Aug 6, 2019, at 12:32 PM, Maxim Kuvyrkov wrote: > ... > I've setup uploads and updates of fully converted GCC history (all branches > and all tags) in 3 flavors. These will be updated roughly hourly. > > 1. https://git-us.linaro.org/people/maxim-kuvyrkov/gcc-pretty

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-08-06 Thread Maxim Kuvyrkov
> On Aug 5, 2019, at 11:24 AM, Maxim Kuvyrkov wrote: > > >> On Aug 2, 2019, at 11:41 AM, Maxim Kuvyrkov >> wrote: >> >>> On Aug 1, 2019, at 11:43 PM, Jason Merrill wrote: >>> > ... >>>> Unfortunately, current mirror does no

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-08-05 Thread Maxim Kuvyrkov
> On Aug 2, 2019, at 11:41 AM, Maxim Kuvyrkov wrote: > >> On Aug 1, 2019, at 11:43 PM, Jason Merrill wrote: >> ... >>> Unfortunately, current mirror does not and could not account for rewrites >>> of SVN commit log messages. For trunk the histories o

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-08-02 Thread Maxim Kuvyrkov
> On Aug 2, 2019, at 2:06 PM, Richard Biener wrote: > > On Fri, Aug 2, 2019 at 1:01 PM Martin Liška wrote: >> >> On 8/2/19 12:54 PM, Maxim Kuvyrkov wrote: >>>> On Aug 2, 2019, at 1:26 PM, Martin Liška wrote: >>>> >>>> On 8/2/19 10:41

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-08-02 Thread Maxim Kuvyrkov
> On Aug 2, 2019, at 11:35 AM, Maxim Kuvyrkov wrote: > >> On Jul 22, 2019, at 12:05 PM, Maxim Kuvyrkov >> wrote: >> > ... >>>>> As far as GCC conversion goes, below is what I plan to do and what not to >>>>> do. This is based

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-08-02 Thread Maxim Kuvyrkov
> On Aug 2, 2019, at 1:26 PM, Martin Liška wrote: > > On 8/2/19 10:41 AM, Maxim Kuvyrkov wrote: >> In the end, I don't care much to which version of the repo we switch, as >> long as we switch. > > Hi Maxim. > > I really appreciate that you've been w

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-08-02 Thread Maxim Kuvyrkov
> On Aug 1, 2019, at 11:43 PM, Jason Merrill wrote: > > On Mon, Jul 22, 2019 at 5:05 AM Maxim Kuvyrkov > wrote: >> >>> On Jul 16, 2019, at 5:14 PM, Maxim Kuvyrkov >>> wrote: >>> >>>> On Jul 16, 2019, at 3:34 PM, Jason Merrill

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-08-02 Thread Maxim Kuvyrkov
> On Jul 22, 2019, at 12:05 PM, Maxim Kuvyrkov > wrote: > ... >>>> As far as GCC conversion goes, below is what I plan to do and what not to >>>> do. This is based on comments from everyone in this thread: >>>> >>>> 1. Construct G

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-07-22 Thread Maxim Kuvyrkov
> On Jul 16, 2019, at 5:14 PM, Maxim Kuvyrkov wrote: > >> On Jul 16, 2019, at 3:34 PM, Jason Merrill wrote: >> >> On Tue, Jul 16, 2019 at 12:18 PM Maxim Kuvyrkov >> wrote: >>> >>> Hi Everyone, >>> >>> I've been swamped

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-07-19 Thread Maxim Kuvyrkov
> On Jul 16, 2019, at 5:14 PM, Maxim Kuvyrkov wrote: > >> On Jul 16, 2019, at 3:34 PM, Jason Merrill wrote: >> ... >> >>> b. Re-write tags/ branches into annotated tags. Note that tags/* are >>> included into history of several branches via merge or

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-07-16 Thread Maxim Kuvyrkov
> On Jul 16, 2019, at 3:34 PM, Jason Merrill wrote: > > On Tue, Jul 16, 2019 at 12:18 PM Maxim Kuvyrkov > wrote: >> >> Hi Everyone, >> >> I've been swamped with other projects for most of June, which gave me time >> to digest all the feedba

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-07-16 Thread Maxim Kuvyrkov
import process because the tool gives only SVN committer ID without much else. We could do much better by matching SVN committer ID with person's name in the map file, and then searching for person's current-at-the-time email address in the commit diff. I.e., mkuvyrkov -> Maxi

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-28 Thread Maxim Kuvyrkov
these scripts to satisfy my own curiosity, and to give GCC community another option to choose from for the final migration. If by end of Summer 2019 we have 2-3 git repos to choose from, then we are likely to push GCC [kicking and screaming] into 2010's by the end of this decade. --

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Maxim Kuvyrkov
> On May 17, 2019, at 4:07 PM, Jason Merrill wrote: > > On Tue, May 14, 2019 at 12:11 PM Maxim Kuvyrkov > wrote: >> >> This patch adds scripts to contrib/ to migrate full history of GCC's >> subversion repository to git. My hope is that these scripts wi

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Maxim Kuvyrkov
try that. > > Is it desired for the transition to use the author map? Do we want it? IIUC, the downside is that converted repo will not match current git mirror unless we do log re-writing, which would add extra info on the side. -- Maxim Kuvyrkov www.linaro.org

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-17 Thread Maxim Kuvyrkov
> On May 17, 2019, at 2:06 AM, Joseph Myers wrote: > > On Tue, 14 May 2019, Maxim Kuvyrkov wrote: > >> The scripts convert svn history branch by branch. They rely on git-svn >> on convert individual branches. Git-svn is a good tool for converting >> indivi

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Maxim Kuvyrkov
keep in the new repo. With git, we can always split away unneeded history by removing unnecessary branches and tags and re-packing the repo. We can equally easily bring that history back if we change our minds. -- Maxim Kuvyrkov www.linaro.org

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Maxim Kuvyrkov
vn branches, and I would appreciate a list of svn branches in GCC's repo that caused problems. It would be best to double-check conversion of these branches for any artifacts. Regards, -- Maxim Kuvyrkov www.linaro.org

  1   2   3   4   >