Re: PATCH v6 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces.

2023-09-18 Thread Maxim Kuvyrkov via Gcc-patches
Hi Ajit, Is this patch supposed to be applied on top of another patch? As is, this patch fails build on AArch64 and AArch32, and Linaro TCWG CI have sent notifications about the failures for v5 [1] and v6 [2] of this patch to you. Did you receive the notifications? Kind regards, [1]

Re: [Linaro-TCWG-CI] gcc patch #75674: FAIL: 68 regressions

2023-09-12 Thread Maxim Kuvyrkov via Gcc-patches
Hi Everyone, Normally, notifications from Linaro TCWG precommit CI are sent only to patch author and patch submitter. In this case the sender was rewritten to "Benjamin Priour via Gcc-patches ", which was detected by Patchwork [1] as patch submitter. Hi Mark, Is "From:" re-write on

Re: [PATCH v6 0/4] P1689R5 support

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
> On Jun 7, 2023, at 00:50, Ben Boeckel via Gcc-patches > wrote: > > Hi, > > This patch series adds initial support for ISO C++'s [P1689R5][], a > format for describing C++ module requirements and provisions based on > the source code. This is required because compiling C++ with modules is >

Re: [PATCH] analyzer: Standalone OOB-warning [PR109437, PR109439]

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
> On Jun 6, 2023, at 15:48, Benjamin Priour via Gcc-patches > wrote: > > From: Benjamin Priour > > This patch enchances -Wanalyzer-out-of-bounds that is no longer paired > with a -Wanalyzer-use-of-uninitialized-value on out-of-bounds-read. > > This also fixes PR analyzer/109437. > Before

Re: [PATCH] Handle FMA friendly in reassoc pass

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
> On May 25, 2023, at 03:30, Cui, Lili via Gcc-patches > wrote: > > From: Lili Cui > > Make some changes in reassoc pass to make it more friendly to fma pass later. > Using FMA instead of mult + add reduces register pressure and insruction > retired. > > There are mainly two changes > 1. Put

Re: [committed] libstdc++: Fix code size regressions in std::vector [PR110060]

2023-06-08 Thread Maxim Kuvyrkov via Gcc-patches
Hi Jonathan, Interestingly, this increases code-size of -O3 code on aarch64-linux-gnu on SPEC CPU2017's 641.leela_s benchmark [1]. In particular, FastBoard::get_nearby_enemies() grew from 1444 to 2212 bytes. This seems like a corner-case; the rest of SPEC CPU2017 is, mostly, neutral to this

Re: [r14-1579 Regression] FAIL: gfortran.dg/gomp/target-update-1.f90 -O scan-tree-dump gimple "#pragma omp target update to\\(c \\[len: [0-9]+\\]\\) to\\(present:a \\[len: [0-9]+\\]\\) to\\(e \\[len:

2023-06-07 Thread Maxim Kuvyrkov via Gcc-patches
Hi Tobias, We are also seeing this failure on arm-linux-gnueabihf. It seems the problem is different order of variables in output: - c a e d b versus expected - c a e b d This is tree-dump output on arm-linux-gnueabihf: #pragma omp target update to(c [len: 4]) to(present:a [len: 4000])

Re: [PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

2023-06-05 Thread Maxim Kuvyrkov via Gcc-patches
> On Jun 3, 2023, at 19:17, Jeff Law wrote: > > On 6/2/23 09:20, Maxim Kuvyrkov via Gcc-patches wrote: >> This patch adds tracking of current testsuite "tool" and "exp" >> to the processing of .sum files. This avoids aliasing between >> tests from

Re: [pushed] analyzer: implement various atomic builtins [PR109015]

2023-06-05 Thread Maxim Kuvyrkov via Gcc-patches
Hi David, Hm, I'm seeing this failure only in pre-commit testing, but I don't see it in our post-commit testing of gcc:master. Does this patch rely on your other patch committed just before this one? -- Maxim Kuvyrkov https://www.linaro.org > On Jun 3, 2023, at 09:23, Maxim Kuvyrkov

Re: [pushed] analyzer: implement various atomic builtins [PR109015]

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
Hi David, The new test ICEs the compiler on aarch64-linux-gnu [1]. Would you please investigate? Running gcc:gcc.dg/analyzer/analyzer.exp ... FAIL: gcc.dg/analyzer/atomic-builtins-qemu-sockets.c (internal compiler error: in validate, at analyzer/store.cc:1329) FAIL:

[PATCH 12/12] [contrib] validate_failures.py: Ignore stray filesystem paths in results

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This patch simplifies comparison of results that have filesystem paths. E.g., (assuming different values of ): Running /home/user/gcc-N/gcc/testsuite/gcc.target/aarch64/sve/acle/aarch64-sve-acle-asm.exp ... ERROR: tcl error sourcing

[PATCH 08/12] [contrib] validate_failures.py: Support "$tool:" prefix in exp names

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
From: Christophe Lyon This makes it easier to extract the $tool:$exp pair when iterating over failures/flaky tests, which, in turn, simplifies re-running testsuite parts that have unexpected failures or passes. --- contrib/testsuite-management/validate_failures.py | 8 +--- 1 file changed,

[PATCH 11/12] [contrib] validate_failures.py: Add "--expiry_date YYYYMMDD" option

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This option sets "today" date to compare expiration entries against. Setting expiration date into the future allows re-detection of flaky tests and creating fresh entries for them before the current flaky entries expire. --- .../testsuite-management/validate_failures.py | 24 +--

[PATCH 09/12] [contrib] validate_failures.py: Improve error output

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
From: Thiago Bauermann - Print message in case of broken sum file error. - Print error messages to stderr. The script's stdout is, usually, redirected to a file, and error messages shouldn't go there. --- contrib/testsuite-management/validate_failures.py | 5 - 1 file changed, 4

[PATCH 07/12] [contrib] validate_failures.py: Use exit code "2" to indicate regression

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
... in the results. Python exits with code "1" on exceptions and internal errors, which we use to detect failure to parse results. --- contrib/testsuite-management/validate_failures.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 05/12] [contrib] validate_failures.py: Add more verbosity levels

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
... to control validate_failures.py output --- .../testsuite-management/validate_failures.py | 82 +++ 1 file changed, 46 insertions(+), 36 deletions(-) diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management/validate_failures.py index

[PATCH 06/12] [contrib] validate_failures.py: Be more stringent in parsing result lines

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
Before this patch we would identify malformed line "UNRESOLVEDTest run by tcwg-buildslave on Mon Aug 23 10:17:50 2021" as an interesting result, only to fail in TestResult:__init__ due to missing ":" after UNRESOLVED. This patch makes all places that parse result lines use a single compiled

[PATCH 02/12] [contrib] validate_failures.py: Support expiry attributes in manifests

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
--- contrib/testsuite-management/validate_failures.py | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management/validate_failures.py index 94ba2e58b51..7351ba120b7 100755 ---

[PATCH 03/12] [contrib] validate_failures.py: Read in manifest when comparing build dirs

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This allows comparison of two build directories with a manifest listing known flaky tests on the side. --- contrib/testsuite-management/validate_failures.py | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/contrib/testsuite-management/validate_failures.py

[PATCH 10/12] [contrib] validate_failures.py: Add new option --invert_match

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This option is used to detect flaky tests that FAILed in the clean build (or manifest), but PASSed in the current build (or manifest). The option inverts output logic similar to what "-v/--invert-match" does for grep. --- .../testsuite-management/validate_failures.py | 34 +-- 1

[PATCH 04/12] [contrib] validate_failures.py: Simplify GetManifestPath()

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
... and don't require a valid build directory when no data from it is necessary. --- contrib/testsuite-management/validate_failures.py | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/contrib/testsuite-management/validate_failures.py

[PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This patch adds tracking of current testsuite "tool" and "exp" to the processing of .sum files. This avoids aliasing between tests from different testsuites with same name+description. E.g., this is necessary for testsuite/c-c++-common, which is ran for both gcc and g++ "tools". This patch

[contrib] Extend and improve validate_failures.py

2023-06-02 Thread Maxim Kuvyrkov via Gcc-patches
This patch series extends and improves validate_failures.py script to provide a powerful tool to handle DejaGnu test results in automated CI environment. Linaro TCWG uses validate_failures.py to ... - compare test results without human oversight, - detect unexpected FAILs vs baseline, - detect

Re: [PATCH] Couple of debug dump improvements to scheduler (no code-gen changes)

2021-08-17 Thread Maxim Kuvyrkov via Gcc-patches
Hi Jeff, I've forgotten to commit these patches when they were approved 2 years ago. They still apply cleanly to the current mainline and I've retested them (bootstrap+regtest) on aarch64-linux-gnu and arm-linux-gnueabihf with no regressions. I'll commit these shortly. Regards, On Fri, 30 Aug

Re: [PR91598] Improve autoprefetcher heuristic in haifa-sched.c

2021-08-17 Thread Maxim Kuvyrkov via Gcc-patches
Hi All, I've forgotten to commit this patch when it was approved 2 years ago. It still applies cleanly to the current mainline and I've retested it (bootstrap+regtest) on aarch64-linux-gnu and arm-linux-gnueabihf with no regressions. I'll commit this shortly. Regards, On Tue, 3 Sept 2019 at

Re: disable -Warray-bounds in libgo (PR 101374)

2021-07-09 Thread Maxim Kuvyrkov via Gcc-patches
> On 9 Jul 2021, at 09:16, Richard Biener via Gcc-patches > wrote: > > On Thu, Jul 8, 2021 at 8:02 PM Martin Sebor via Gcc-patches > wrote: >> >> Hi Ian, >> >> Yesterday's enhancement to -Warray-bounds has exposed a couple of >> issues in libgo where the code writes into an invalid constant

Re: [r12-2132 Regression] FAIL: g++.dg/warn/Warray-bounds-20.C -std=gnu++98 note (test for warnings, line 55) on Linux/x86_64

2021-07-09 Thread Maxim Kuvyrkov via Gcc-patches
> On 9 Jul 2021, at 02:35, sunil.k.pandey via Gcc-patches > wrote: > > On Linux/x86_64, > > a110855667782dac7b674d3e328b253b3b3c919b is the first bad commit > commit a110855667782dac7b674d3e328b253b3b3c919b > Author: Martin Sebor > Date: Wed Jul 7 14:05:25 2021 -0600 > >Correct

[PATCH] [contrib] Remove broken compareSumTests3 script

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
Hi Matthew, Hi Sebastian, This patch removes compareSumTests3, which appears to be broken. It tries to call compareSumFiles(), which is nowhere to be found and was never present in the GCC repo. OK to remove? Regards, -- Maxim Kuvyrkov https://www.linaro.org

Re: [PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
> On Jul 2, 2021, at 5:44 PM, Christophe Lyon > wrote: > > > > On Fri, Jul 2, 2021 at 4:29 PM Jakub Jelinek via Gcc-patches > wrote: > On Fri, Jul 02, 2021 at 05:20:33PM +0300, Maxim Kuvyrkov wrote: > > Hi Jakub, > > > > Thanks for helping me on IRC with debugging testsuite problems.

[PATCH] Add description of how testsuite parallelization works

2021-07-02 Thread Maxim Kuvyrkov via Gcc-patches
Hi Jakub, Thanks for helping me on IRC with debugging testsuite problems. Does this write up look good? Regards, -- Maxim Kuvyrkov https://www.linaro.org 0001-Add-description-of-how-testsuite-parallelization-wor.patch Description: Binary data

Re: [PATCH] Avoid loading an undefined value in the ranger_cache constructor.

2021-06-17 Thread Maxim Kuvyrkov via Gcc-patches
> On 16 Jun 2021, at 20:14, Andrew MacLeod wrote: > > On 6/16/21 5:41 AM, Maxim Kuvyrkov wrote: >> >>> + m_new_value_p = state; >>> + return ret; >>> } >>>// Dump the caches for basic block BB to file F. >> Thanks, >> >> -- >> Maxim Kuvyrkov >> https://www.linaro.org >> > Let me know

Re: [PATCH] tree-optimization PR/101014 - Limit new value calculations to first order effects.

2021-06-16 Thread Maxim Kuvyrkov via Gcc-patches
> On 15 Jun 2021, at 00:07, Andrew MacLeod via Gcc-patches > wrote: > > As mentioned in the Text from the PR: > > "When a range is being calculated for an ssa-name, the propagation process > often goes along back edges. These back edges sometime require other > ssa-names which have not be

Re: [PATCH] middle-end/94188 fix fold of addr expression generation

2020-03-18 Thread Maxim Kuvyrkov via Gcc-patches
> On 17 Mar 2020, at 17:40, Richard Biener wrote: > > > This adds a missing type conversion to build_fold_addr_expr and adjusts > fallout - build_fold_addr_expr was used as a convenience to build an > ADDR_EXPR but some callers do not expect the result to be simplified > to something else. >