On 05/29/2018 11:25 AM, Mike Gulick wrote:
> On 03/04/2018 02:27 PM, Mike Gulick wrote:
>>
>>
>> On 02/09/2018 05:54 PM, Mike Gulick wrote:
>>> Hi David,
>>>
>>> Here is a new version of the linemap patch (see my earlier emails for an
>>&g
On 11/13/18 3:12 PM, David Malcolm wrote:
> On Tue, 2018-11-13 at 14:54 -0500, Mike Gulick wrote:
>> 2018-11-13 Mike Gulick
>
> [...]
>
>> * gcc/diagnostic-core.h (num_digits): Add extern definition.
>
> FWIW you moved the decl to diagnostic.h, but didn&
2018-11-26 Mike Gulick
PR preprocessor/83173
* gcc/input.c (dump_location_info): Dump reason and
included_from fields from line_map_ordinary struct. Fix
indentation when location > 5 digits.
* libcpp/location-example.txt: Update example
-fd
On 11/26/18 8:29 PM, David Malcolm wrote:
> On Mon, 2018-11-26 at 22:17 +0000, Mike Gulick wrote:
>> On 11/13/18 3:12 PM, David Malcolm wrote:
>>> On Tue, 2018-11-13 at 14:54 -0500, Mike Gulick wrote:
>>>> 2018-11-13 Mike Gulick
>>>
>>> [...]
On 11/27/18 9:27 AM, David Malcolm wrote:
[...]
>
> I can commit them for you if you like. Please can you repost the
> latest version of the patches as one kit, for clarity, so I can commit
> them.
>
Do you want me to repost them as a patch series, or as a single patch?
> Thanks
> Dave
>
2018-11-27 Mike Gulick
PR preprocessor/83173
* libcpp/files.c (_cpp_stack_include): Check if
line_table->highest_location is past current line before
decrementing.
---
libcpp/files.c | 32 +++-
1 file changed, 23 insertions(+)
2018-11-27 Mike Gulick
PR preprocessor/83173
* gcc.dg/plugin/location-overflow-test-pr83173.c: New test.
* gcc.dg/plugin/location-overflow-test-pr83173.h: Header for
pr83173.c.
* gcc.dg/plugin/location-overflow-test-pr83173-1.h: Header for
2018-11-27 Mike Gulick
PR preprocessor/83173
* gcc/input.c (dump_location_info): Dump reason and
included_from fields from line_map_ordinary struct. Fix
indentation when location > 5 digits.
* libcpp/location-example.txt: Update example
-fd
On 11/27/18 11:07 AM, David Malcolm wrote:
> On Tue, 2018-11-27 at 09:53 -0500, Mike Gulick wrote:
>> 2018-11-27 Mike Gulick
>>
>> PR preprocessor/83173
>> * libcpp/files.c (_cpp_stack_include): Check if
>> line_table->highest_
ase let me know if you have any feedback, and how I should
proceed. I do not have gcc contributor paperwork in place, as I believe
that needs to be initiated by a maintainer, but I do have an employer
disclaimer already approved, so the process should be simple.
Thanks,
Mike
Mike Gulick (3):
PR pr
2018-10-31 Mike Gulick
PR preprocessor/83173
* libcpp/files.c (_cpp_stack_include): Check if
line_table->highest_location is past current line before
decrementing.
---
libcpp/files.c | 32 +++-
1 file changed, 23 insertions(+)
2018-10-31 Mike Gulick
PR preprocessor/83173
* gcc.dg/plugin/location-overflow-test-pr83173.c: New test.
* gcc.dg/plugin/location-overflow-test-pr83173.h: Header for
pr83173.c.
* gcc.dg/plugin/location-overflow-test-pr83173-1.h: Header for
2017-10-31 Mike Gulick
PR preprocessor/83173
* gcc/input.c (dump_location_info): Dump reason and
included_from fields from line_map_ordinary struct. Fix
indentation when location > 5 digits.
* libcpp/location-example.txt: Update example
-fd
On 11/2/18 5:13 PM, David Malcolm wrote:
> On Thu, 2018-11-01 at 11:56 -0400, Mike Gulick wrote:
>> 2018-10-31 Mike Gulick
>>
>> PR preprocessor/83173
>> * libcpp/files.c (_cpp_stack_include): Check if
>> line_table->highest_
On 11/2/18 5:04 PM, David Malcolm wrote:
> On Thu, 2018-11-01 at 11:56 -0400, Mike Gulick wrote:
>> 2017-10-31 Mike Gulick
>>
>> PR preprocessor/83173
>> * gcc/input.c (dump_location_info): Dump reason and
>> included_from fields fr
On 11/12/18 7:56 PM, David Malcolm wrote:
> On Mon, 2018-11-12 at 21:13 +0000, Mike Gulick wrote:
>> On 11/2/18 5:04 PM, David Malcolm wrote:
>>> On Thu, 2018-11-01 at 11:56 -0400, Mike Gulick wrote:
>>>> 2017-10-31 Mike Gulick
>>>>
>>&
2018-11-13 Mike Gulick
PR preprocessor/83173
* gcc/input.c (dump_location_info): Dump reason and
included_from fields from line_map_ordinary struct. Fix
indentation when location > 5 digits.
* libcpp/location-example.txt: Update example
-fd
On 01/12/2018 06:16 PM, David Malcolm wrote:
> On Fri, 2017-12-01 at 17:57 -0500, Mike Gulick wrote:
>> I've come up with some patches that fix PR preprocessor/83173, which
>> I reported
>> a couple of weeks ago.
>>
>> The first patch is a test case.
On 01/14/2018 12:16 PM, Mike Gulick wrote:
> On 01/12/2018 06:16 PM, David Malcolm wrote:
[snip]
>>
>> I was going to suggest renaming your new test to e.g.
>> location-overflow-test-pr83173.c
>> so that it matches the glob in those comments, but given that you ref
ternal-locations output to include the reason and included_from fields
from the line_map_ordinary data structure. I aos fixed an issue with the output
alignment. I found this useful when evaluating these changes.
Thanks,
Mike
From e3f23f66ad18598fc21a9223b7f29572a14d1588 Mon Sep 17 00:00:00
On 02/09/2018 05:54 PM, Mike Gulick wrote:
> Hi David,
>
> Here is a new version of the linemap patch (see my earlier emails for an
> updated
> version of the test code).
Hi David,
Just wondering if you have had a chance to look at these updated patches
yet. Let me know
ases. Both of these pass the gcc/g++ test suites with no regressions.
Thanks in advance for the review/feedback!
-Mike
>From 6ff0068284c346c8db08c4b6b4d9a66d8464aeac Mon Sep 17 00:00:00 2001
From: Mike Gulick
Date: Thu, 30 Nov 2017 18:35:48 -0500
Subject: [PATCH 1/2] PR preprocessor/83173: New
22 matches
Mail list logo
