Re: Verify package integrity of downloaded prerequisites (partially fixes 61439)

2016-10-24 Thread Moritz Klammler
Jeff Law writes: > On 10/24/2016 02:44 AM, Richard Biener wrote: >> On Fri, Oct 7, 2016 at 3:10 PM, Moritz Klammler wrote: >>> I would like to bump my patch that makes the >>> `contrib/download_prerequisites` script verify the checksums of the >>> downloaded

PING: Verify package integrity of downloaded prerequisites

2016-10-24 Thread Moritz Klammler
I would like to ping this patch of mine: https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00486.html Thank you.

Re: Verify package integrity of downloaded prerequisites (partially fixes 61439)

2016-10-07 Thread Moritz Klammler
I would like to bump my patch that makes the `contrib/download_prerequisites` script verify the checksums of the downloaded packages and augments it with a few additional options. All feedback I have received has been incorporated. Is it okay like this? Below is again the latest iteration of the

Re: [RFC] Update gmp/mpfr/mpc minimum versions

2016-09-22 Thread Moritz Klammler
Martin Sebor writes: > [...] > >> In-tree only the versions that download_prerequisite picks are >> tested and guaranteed to work. > > I was made aware today that my recent patch for pr49905 broke > bootstrap with MPFR 2.4: > > https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01507.html > > In lig

Re: Verify package integrity of downloaded prerequisites (partially fixes 61439)

2016-09-14 Thread Moritz Klammler
Joseph Myers writes: > On Wed, 14 Sep 2016, Moritz Klammler wrote: > >> Ok, I didn't know about the workflow. Do you think I should dike the >> `--strip-sums` option out again then? > > I don't see any use for such an option. Anyone changing the versions >

Re: Verify package integrity of downloaded prerequisites (partially fixes 61439)

2016-09-14 Thread Moritz Klammler
Joseph Myers writes: > On Wed, 14 Sep 2016, Moritz Klammler wrote: > >> be cleaner to only include those checksums that are actually needed. On >> the other hand, it means an increased maintenance burden each time the >> version of the dependency is changed. In order to

Re: Verify package integrity of downloaded prerequisites (partially fixes 61439)

2016-09-14 Thread Moritz Klammler
Richard Biener writes: > On Tue, Sep 13, 2016 at 6:01 PM, Joseph Myers wrote: >> On Tue, 13 Sep 2016, Moritz Klammler wrote: >> >>> I have made an actual diff now, containing also the checksum files. >>> I >> >> I don't think checksums of lots

Re: Verify package integrity of downloaded prerequisites (partially fixes 61439)

2016-09-13 Thread Moritz Klammler
Joseph Myers writes: > On Sun, 11 Sep 2016, Moritz Klammler wrote: > >> gmp='gmp-4.3.2.tar.bz2' >> mpfr='mpfr-2.4.2.tar.bz2' >> mpc='mpc-0.8.1.tar.gz' >> isl='isl-0.15.tar.bz2' > > These are not the versions used in t

Re: [PATCH] Optimise the fpclassify builtin to perform integer operations when possible

2016-09-12 Thread Moritz Klammler
Tamar Christina writes: > Hi All, > > This patch adds an optimized route to the fpclassify builtin > for floating point numbers which are similar to IEEE-754 in format. > > [...] I might be the least competent person on this list to review this patch but nevertheless read it out of interest and

Verify package integrity of downloaded prerequisites (partially fixes 61439)

2016-09-11 Thread Moritz Klammler
There is a long-standing [bug report](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61439) pointing out that the `download_prerequisites` script doesn't verify the integrity of the packages it downloads. The original bug report is only concerned about stability but for me, this is first and foremos