RE: [PATCH] PR preprocessor/60723 - missing system-ness marks for macro

2014-07-10 Thread Nicholas Ormrod
The fact that extra line directives are inserted around built-in tokens isn't ideal, but I must concur with Dodji's assessment that such a fix belongs in a separate patch. The purpose of this patch is to resolve a discrepancy between integrated-cpp and non-integrated-cpp. The locations of

RE: [PATCH] PR preprocessor/60723 - missing system-ness marks for macro

2014-07-03 Thread Nicholas Ormrod
Hello Dodji, I found time this morning to run your changes through our system. I patched our gcc-4.8.1 with your latest change, and ran it through our folly testsuite. One thing that I immediately noticed was that this increased the preprocessed size substantially. When preprocessing my

RE: [PATCH, cpp] Fix line directive bug

2014-06-21 Thread Nicholas Ormrod
Hello all, (Re-adding gcc-patches, since it got dropped and missed six emails) === CPP FEATURE SUGGESTION === Adding line directives inside of a macro expansion to differentiate between system tokens and user tokens is a valid solution. As Manuel pointed out, there would need to be many line

[PATCH, cpp] Fix line directive bug‏

2014-06-11 Thread Nicholas Ormrod
the changes are in, the original test numbers are unchanged, but the new test case generates two expected passes. Details: 2014-06-10 Nicholas Ormrod nicholas.orm...@hotmail.com PR preprocessor/60723 * input.h: Add LOCATION_* macro for sysp * c-family/c-ppoutput.c (print_line_1): Use