Re: [PATCH 1/2 v3] Ada: Synchronized private extensions are always limited

2023-09-18 Thread Richard Wai
Hi Marc, Indeed I have read and accept the terms of the DCO. Please proceed to apply these changes at your convenience. Thanks for helping me get these committed! Richard Wai > On Sep 18, 2023, at 04:31, Marc Poulhiès wrote: > > > Hello Richard, > >> I have added the

Re: [PATCH 2/2 v3] Ada: Finalization of constrained subtypes of unconstrained synchronized private extensions

2023-09-18 Thread Richard Wai
Thanks for that! Richard > On Sep 18, 2023, at 09:43, Arnaud Charlet wrote: > >> Thanks for finding that! I have made the recommended change and attached the >> revised patch, which is also rebased on trunk. >> >> Additionally, I have added the “Signed-off-by” tag for legal compliance to >>

[PATCH 1/2 v3] Ada: Synchronized private extensions are always limited

2023-09-17 Thread Richard Wai
ce of “limited”. gcc/ada/ * sem_ch3.adb (Build_Derived_Record_Type): Treat presence of keyword “synchronized” the same as “limited” when determining if a private extension is limited. Signed-off-by: Richard Wai mailto:rich...@annexi-strayline.com>> -- End change log entry

Re: [PATCH 2/2 v3] Ada: Finalization of constrained subtypes of unconstrained synchronized private extensions

2023-09-17 Thread Richard Wai
): Handle cases where the underlying non-constrained parent type is a concurrent type, and adjust the designated type to be the corresponding record’s class-wide type. Signed-off-by: Richard Wai mailto:rich...@annexi-strayline.com>> -- End change log entry – See you at the next meeting!

[PING][PATCH 2/2 v2] Ada: Finalization of constrained subtypes of unconstrained synchronized private extensions

2023-09-12 Thread Richard Wai
> On Aug 23, 2023, at 10:24, Richard Wai wrote: > > Somehow an error worked its way into the original diff (the diff itself), > making the previous patch fail to apply. > > Fixed version attached. > > Richard Wai > ANNEXI-STRAYLINE > > From: Ri

[PATCH 1/2 v2] Ada: Synchronized private extensions are always limited

2023-09-12 Thread Richard Wai
Hi Arno, No worries, and sorry for the trouble. I’m going to try using a different client for the gcc mailing list, it doesn’t seem to like Outlook. Thanks for catching that mistake! Please advise how I can get this patch actually applied, given my lack of commit privilege. Revised patch atta

[PATCH 2/2 v2] Ada: Finalization of constrained subtypes of unconstrained synchronized private extensions

2023-08-23 Thread Richard Wai
Somehow an error worked its way into the original diff (the diff itself), making the previous patch fail to apply. Fixed version attached. Richard Wai ANNEXI-STRAYLINE From: Richard Wai Sent: Thursday, August 10, 2023 1:27 AM To: 'gcc-patches@gcc.gnu.org' Cc: 

[PING][PATCH 1/2] Ada: Synchronized private extensions are always limited

2023-08-23 Thread Richard Wai
From: Richard Wai Sent: Thursday, August 10, 2023 12:55 AM To: 'gcc-patches@gcc.gnu.org' Cc: 'Eric Botcazou' ; 'Arnaud Charlet' ; 'Stephen Baird' Subject: [PATCH 1/2] Ada: Synchronized private extensions are always limited GNAT currently conside

[PATCH 2/2] Ada: Finalization of constrained subtypes of unconstrained synchronized private extensions

2023-08-09 Thread Richard Wai
(test for warnings, line 42) === gnat Summary === # of expected passes 3401 # of unexpected failures 4 # of expected failures 23 # of unsupported tests 10 gnatmake ver

[PATCH 1/2] Ada: Synchronized private extensions are always limited

2023-08-09 Thread Richard Wai
3402 # of unexpected failures4 # of expected failures 23 # of unsupported tests 10 gnatmake version 14.0.0 20230809 (experimental) Richard Wai ANNEXI-STRAYLINE ada-synchronized-private-types-are-limited.patch Description: Binary data

RE: [PATCH] Ada: hashed container Cursor type predefined equality non-conformance

2021-04-06 Thread Richard Wai
Pinging this.. > -Original Message- > From: Richard Wai > Sent: March 16, 2021 2:19 PM > To: 'gcc-patches@gcc.gnu.org' > Cc: 'Arnaud Charlet' ; 'Bob Duff' > > Subject: RE: [PATCH] Ada: hashed container Cursor type predefined equali

RE: [PATCH] Ada: hashed container Cursor type predefined equality non-conformance

2021-03-16 Thread Richard Wai
Just a note that I do not have write access, so I will need someone who does to commit this patch, if approved. Richard > -Original Message- > From: Richard Wai > Sent: March 11, 2021 9:13 AM > To: 'Arnaud Charlet' > Cc: 'gcc-patches@gcc.gnu.org' ;

RE: [PATCH] Ada: hashed container Cursor type predefined equality non-conformance

2021-03-11 Thread Richard Wai
Here is the amended commit log: -- Ada: Ensure correct predefined equality behavior for Cursor objects of hashed containers. 2021-03-11 Richard Wai gcc/ada/ * libgnat/a-cohase.ads (Cursor): Synchronize comments for the Cursor type definition to be consistent with identical

RE: [PATCH] Ada: hashed container Cursor type predefined equality non-conformance

2021-03-10 Thread Richard Wai
> And the commit log will look like: > > 2021-03-09 Richard Wai > > gcc/ada/ > * libgnat/... > > gcc/testsuite/ > * gnat.dg/containers2.adb: ... > > Your patch is OK with these changes, thanks. Understood! Thanks for that. Richard

RE: [PATCH] Ada: hashed container Cursor type predefined equality non-conformance

2021-03-10 Thread Richard Wai
> -Original Message- > From: Arnaud Charlet > Sent: March 10, 2021 10:23 AM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org; 'Bob Duff' ; Arnaud > Charlet > Subject: Re: [PATCH] Ada: hashed container Cursor type predefined equality > non-conformanc

RE: [PATCH] Ada: hashed container Cursor type predefined equality non-conformance

2021-03-10 Thread Richard Wai
Arno, I appologise for making a mess of this final step. I have leared the errors of my ways. Below are the change log entries for this patch: gcc/ada/Changelog: 2021-03-09 Richard Wai * libgnat/a-cohase.ads (Cursor): Synchronize comments for the Cursor type definition to

RE: [PATCH v2] Ada: hashed container Cursor type predefined equality non-conformance

2021-03-10 Thread Richard Wai
Please disregard this v2 patch. V1 is the correct patch. Change log entries to be added for V1, to follow. Richard > -Original Message- > From: Richard Wai > Sent: March 9, 2021 4:26 PM > To: 'Arnaud Charlet' > Cc: 'gcc-patches@gcc.gnu.org' ; 

[PATCH v2] Ada: hashed container Cursor type predefined equality non-conformance

2021-03-09 Thread Richard Wai
lpful approach. Cheers, Richard > -Original Message- > From: Arnaud Charlet > Sent: March 9, 2021 10:51 AM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org; 'Bob Duff' ; Arnaud > Charlet > Subject: Re: [PATCH] Ada: hashed container Cursor type p

RE: [PATCH] Ada: hashed container Cursor type predefined equality non-conformance

2021-03-09 Thread Richard Wai
component. * testsuite/gnat.dg/containers2.adb: New regression test to ensure that all hashed containers obey predefined equality requirements for Cursor objects. --- > -----Original Message- > From: Richard Wai > Sent: March 9, 2021 10:35 AM > To: 'Arnaud Charlet' >

RE: [PATCH] Ada: hashed container Cursor type predefined equality non-conformance

2021-03-09 Thread Richard Wai
d equality requirements for Cursor objects. --- Thanks for your speedy review! Richard > -Original Message- > From: Arnaud Charlet > Sent: March 9, 2021 3:12 AM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org; Arnaud Charlet ; Bob > Duff > Subject: Re: [PATCH] Ad

[PATCH] Ada: hashed container Cursor type predefined equality non-conformance

2021-03-05 Thread Richard Wai
a new regression test case is added that checks for this issue among all four of the hashed container packages. This was successfully bootstrapped and tested on trunk, x86_64-unknown-freebsd12.2. Cheers, Richard Wai ANNEXI-STRAYLINE container_cursor_equality_20210304.patch Description: Binary data

RE: [PATCHv2] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-11 Thread Richard Wai
> -Original Message- > From: Eric Botcazou > Sent: March 11, 2020 6:16 AM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCHv2] Ada: gcc-interface: fixed assertion for aliased entities > > > Thanks for the analysis and the fix. This

[PATCHv2] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-10 Thread Richard Wai
ted from trunk on x86_64-unknown-freebsd12.1. Cheers, Richard Wai ANNEXI-STRAYLINE > -Original Message- > From: Eric Botcazou > Sent: March 7, 2020 5:48 AM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Ada: gcc-interface: fixed assertion for al

RE: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-04 Thread Richard Wai
> -Original Message- > From: Eric Botcazou > Sent: March 4, 2020 6:18 AM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities > > > I'll have to look into this.. Any p

RE: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-03 Thread Richard Wai
Richard Wai Managing Director T. 416.316.9806 > -Original Message- > From: Eric Botcazou > Sent: March 3, 2020 3:50 PM > To: Richard Wai > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Ada: gcc-interface: fixed assertion for aliased entities > > >

[PATCH] Ada: gcc-interface: fixed assertion for aliased entities

2020-03-03 Thread Richard Wai
name of the entity and set up the line number and filename of Thanks, Richard Wai ANNEXI-STRAYLINE