Re: RFC: [PATCH,ARM] Fix 56110

2013-02-28 Thread Tilman Sauerbeck
Tilman Sauerbeck [2013-02-24 17:00]: > Richard Earnshaw [2013-02-20 11:00]: > > On 19/02/13 22:26, Tilman Sauerbeck wrote: > > >I don't get why relaxing the restrictions for the > > >andsi3_compare0_scratch pattern results in a mismatch for the > &g

Re: RFC: [PATCH,ARM] Fix 56110

2013-02-24 Thread Tilman Sauerbeck
Richard Earnshaw [2013-02-20 11:00]: > On 19/02/13 22:26, Tilman Sauerbeck wrote: > >I don't get why relaxing the restrictions for the > >andsi3_compare0_scratch pattern results in a mismatch for the > >zeroextractsi_compare0_scratch one. > > > >Any ideas?

Re: RFC: [PATCH,ARM] Fix 56110

2013-02-19 Thread Tilman Sauerbeck
Tilman Sauerbeck [2013-02-19 23:26]: > However it breaks the case where the 2nd operand is a const_int that > *can* be used as an immediate (eg 0x80), and ends up generating the > AND/CMP combination. ... and that would be because I changed the operand patterns in zeroextractsi_compare

Re: RFC: [PATCH,ARM] Fix 56110

2013-02-19 Thread Tilman Sauerbeck
Richard Earnshaw [2013-02-19 15:12]: Hi, thanks for your reply. > [...] > However, the question you need to be asking is why the pattern immediately > before the one you've added is not matching. The compiler knows how to add > clobbers, so I'm surprised that you're finding a new pattern to be >

Re: RFC: [PATCH,ARM] Fix 56110

2013-02-18 Thread Tilman Sauerbeck
Tilman Sauerbeck [2013-02-18 22:47]: > [...] > + "TARGET_32BIT" > + "@ > + tst%?\\t%0, %1" > [...] I managed to post the wrong diff -- line 2 in the citation should be omitted of course. Sorry. Regards, Tilman -- A: Because it messes up the order in

RFC: [PATCH,ARM] Fix 56110

2013-02-18 Thread Tilman Sauerbeck
Hi, adding the instruction pattern below fixes my testcase for PR 56110; however I'm not sure if adding a new pattern is the correct way to go. I duplicated the andsi3_compare0_scratch pattern, and lifted the requirement that the 2nd operand be an arm_not_operand. I didn't copy over the clobber pa

[PATCH,testsuite] Added test for PR 55987

2013-02-14 Thread Tilman Sauerbeck
Hi, here's a patch that adds a testcase for PR 55987. Is xfail the right thing to use here? I went with that since I guess the PR won't be fixed anytime soon ;) I haven't assigned copyright to the FSF -- is this patch small enough to go in without it? Thanks, Tilman 2013-02-14 T