On 2012/12/06 21:19:17, shenhan wrote:
On 2012/12/06 20:18:02, asharif wrote:
Please review this backport needed to enable PGO for Chrome.
I think we shall only change ChangeLog.google-xxx when adding changes
to google
branch.
Quote from Diego -
'Please remember to use ChangeLog.google
On 2012/12/06 22:02:16, Diego Novillo wrote:
On Thu, Dec 6, 2012 at 4:51 PM, mailto:asha...@chromium.org wrote:
I don't think the rule is to *only* update ChangeLog.google*. The
rule
is to update ChangeLog, but also update ChangeLog.google*.
Just ChangeLog.google*, actually. When
Reviewers: xur, davidxl,
Message:
Please take a look at this patch.
Description:
2012-03-12 Richard Guenther rguent...@suse.de
* gthr.h (__GTHREAD_MUTEX_INIT_FUNCTION): Adjust specification.
* gthr-posix.h (__GTHREAD_MUTEX_INIT_FUNCTION): Define.
Reviewers: davidxl, xur,
Message:
When I backported this patch to google/gcc-4.6, I forgot to do it for
main. So now I am backporting this to google/main, google/4_7 and
google/4_7-mobile.
This is the first of the 3 (google/main is the target).
I am running crosstool_validate.py and it should
On 2012/12/04 00:50:45, asharif wrote:
When I backported this patch to google/gcc-4.6, I forgot to do it for
main. So
now I am backporting this to google/main, google/4_7 and
google/4_7-mobile.
This is the first of the 3 (google/main is the target).
I am running crosstool_validate.py
On 2012/04/24 22:14:17, asharif wrote:
Ping?
Ping.
I also filed a bug here:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53547
Here is the formatted ChangeLog in case you want a summary of what I
did:
* gcc/ipa-inline.c (edge_badness): Make sure profile is valid before
using
On 2012/06/02 01:52:28, asharif wrote:
A trunk version of this patch is already under review. I'm creating
this CL in
order to get this patch in before the branch date.
Ping.
http://codereview.appspot.com/6273045/
Reviewers: davidxl, xur, bjanakiraman_google.com,
Message:
A trunk version of this patch is already under review. I'm creating this
CL in order to get this patch in before the branch date.
Please review this at http://codereview.appspot.com/6273045/
Affected files:
M
Reviewers: xur, davidxl, iant2, Diego Novillo,
Message:
The relevant bug is this:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53546.
Please take a look and provide feedback.
Thanks,
Description:
2012-05-31 Ahmad Sharif asha...@google.com
* gcc/dwarf2asm.c:
On 2012/05/16 01:02:26, shenhan wrote:
Hi Amhad and Jing, could you take a look at this CL at
http://codereview.appspot.com/6210060/
Thanks,
-Han
Shouldn't this have a corresponding ChangeLog entry and a
ChangeLog.google-gcc-4_6 entry?
http://codereview.appspot.com/6210060/
On 2012/05/16 22:11:08, shenhan wrote:
On 2012/05/16 17:27:59, asharif1 wrote:
On 2012/05/16 01:02:26, shenhan wrote:
Hi Amhad and Jing, could you take a look at this CL at
http://codereview.appspot.com/6210060/
Thanks,
-Han
Shouldn't this have a corresponding ChangeLog entry and a
what tests you have done.
Done.
Thanks,
Jing
On 2012/05/01 22:40:12, asharif wrote:
+carrot@
http://codereview.appspot.com/6148044/
On 2012/04/30 19:54:14, asharif wrote:
I backported the following patch:
2012-03-12 Richard Guenther mailto:rguent...@suse.de
* gthr.h (__GTHREAD_MUTEX_INIT_FUNCTION): Adjust specification.
* gthr-posix.h (__GTHREAD_MUTEX_INIT_FUNCTION): Define
On 2012/05/01 20:44:05, davidxl wrote:
Ok for google branches (please also backport to google/gcc_47 branch.
Commited as r187026.
I'll backport to google/gcc-4_7 as well.
David
On 2012/05/01 20:37:44, asharif wrote:
On 2012/04/30 19:54:14, asharif wrote:
I backported the following
Reviewers: xur, davidxl,
Message:
Please take a look at this.
Description:
This fixes an issue with profile collection when multiple threads call
fork() around the same time.
2012-03-12 Richard Guenther rguent...@suse.de
* gthr.h (__GTHREAD_MUTEX_INIT_FUNCTION): Adjust
Reviewers: xur, davidxl, iant2,
Message:
I backported the following patch:
2012-03-12 Richard Guenther rguent...@suse.de
* gthr.h (__GTHREAD_MUTEX_INIT_FUNCTION): Adjust specification.
* gthr-posix.h (__GTHREAD_MUTEX_INIT_FUNCTION): Define.
Ping?
Here is the formatted ChangeLog in case you want a summary of what I did:
* gcc/ipa-inline.c (edge_badness): Make sure profile is valid before
using it to compute badness.
* gcc/predict.c (maybe_hot_frequency_p): Ditto.
(cgraph_maybe_hot_edge_p): Ditto.
(maybe_hot_edge_p): Ditto.
On 2012/04/05 18:53:28, asharif wrote:
Jan, please take a look and provide some feedback.
Thanks,
Ping?
http://codereview.appspot.com/5989046/
Committed as r186168.
http://codereview.appspot.com/5989043/
Reviewers: jingyu, bjanakiraman_google.com, dougkwan,
Message:
PTAL.
Description:
2012-04-04 Ahmad Sharif asha...@google.com
Backport from mainline r179661, r179662.
2011-10-07 Andrew Stubbs a...@codesourcery.com
gcc/
* config/arm/predicates.md
Reviewers: jh_suse.cz, davidxl, bjanakiraman_google.com,
Message:
Jan, please take a look and provide some feedback.
Thanks,
Description:
Added better handling of outdated profiles.
gcc dumps profile information in .gcda files that contain the function
id and
the corresponding counter
Added shenhan to the list of reviewers.
http://codereview.appspot.com/5991052/
On 2012/04/05 17:25:44, shenhan wrote:
Hi Jing and Ahmad,
This adds a new test base line for x86_64-cros-linux-gnu. Please take
a look.
Thanks,
Han
lgtm.
http://codereview.appspot.com/5990044/
On 2012/04/05 21:56:19, asharif wrote:
Added shenhan to the list of reviewers.
I'm abandoning this CL in favor of a new one which will be a bulk
integrate from branches/google/gcc-4_6 to
branches/google/gcc-4_6_2-mobile.
Sorry about the noise.
http://codereview.appspot.com/5991052/
Reviewers: xur, shenhan, jingyu,
Message:
This merges in the fix for ICE when using PGO when building Chrome.
Please review this at http://codereview.appspot.com/5541046/
Affected files:
M.
M gcc/ChangeLog.google-4_6
M gcc/profile.c
Index: .
On 2012/01/12 23:16:03, asharif1 wrote:
This merges in the fix for ICE when using PGO when building Chrome.
+reviewer: dnovillo.
Updated the patch description.
http://codereview.appspot.com/5541046/
Please take a look.
http://codereview.appspot.com/5541046/
Reviewers: xur, bjanakiraman_google.com, jingyu,
Message:
Please review this backport.
Please review this at http://codereview.appspot.com/5501051/
Affected files:
Mgcc-4_6-mobile
M gcc-4_6-mobile/gcc/ChangeLog.google-4_6
M gcc-4_6-mobile/gcc/common.opt
M
Adding shenhan.
http://codereview.appspot.com/5501051/
Reviewers: xur, jingyu, shenhan, bjanakiraman_google.com,
Message:
This merges xur's patch to our mobile release branch. LGTM and I will
submit it.
Please review this at http://codereview.appspot.com/5491078/
Affected files:
Mgcc-4_6-mobile
M
Reviewers: Diego Novillo, shenhan, jingyu, bjanakiraman_google.com,
Message:
Please review this on behalf of shenhan@.
Please review this at http://codereview.appspot.com/5496077/
Affected files:
M gcc-4_6-mobile/gcc/ChangeLog.google-4_6
M gcc-4_6-mobile/gcc/cfgexpand.c
M
I have seen an ICE in 4.4.3 when a corrupted profile file causes a
division by 0 in gcc. This is the equivalent code in trunk and this
check should help fix it.
Thoughts?
2011-03-15 Ahmad Sharif asha...@google.com
* predict.c (probably_never_executed_bb_p): Add check to see
32 matches
Mail list logo
