On Wed, Jul 01, 2015 at 10:59:15AM +0100, Richard Sandiford wrote:
> Trevor Saunders writes:
> > On Tue, Jun 16, 2015 at 09:45:56AM +0100, Richard Sandiford wrote:
> >> I couldn't tell whether the unusual name of the function
> >> ("gt_cleare_cache") is deliberate or not, but I left it be.
> >
> >
Trevor Saunders writes:
> On Tue, Jun 16, 2015 at 09:45:56AM +0100, Richard Sandiford wrote:
>> I couldn't tell whether the unusual name of the function
>> ("gt_cleare_cache") is deliberate or not, but I left it be.
>
> I'm not sure what's particularly unusual about it?
"cleare" rather than "clea
On Tue, Jun 16, 2015 at 09:45:56AM +0100, Richard Sandiford wrote:
> As described in the covering note, this patch replaces handle_cache_entry
> with a new function keep_cache_entry. It also ensures that elements are
> deleted using the proper function, so that m_n_deleted is updated.
Thanks for
On 06/24/2015 02:16 AM, Richard Sandiford wrote:
So for all the keep_cache_entry functions, I guess they're trivial
enough that a function comment probably isn't needed.
Yeah. For cases like this where the function is implementing a defined
interface (described in hash-table.h), I think it's b
Jeff Law writes:
> On 06/16/2015 02:45 AM, Richard Sandiford wrote:
>> As described in the covering note, this patch replaces handle_cache_entry
>> with a new function keep_cache_entry. It also ensures that elements are
>> deleted using the proper function, so that m_n_deleted is updated.
>>
>> I
On 06/16/2015 02:45 AM, Richard Sandiford wrote:
As described in the covering note, this patch replaces handle_cache_entry
with a new function keep_cache_entry. It also ensures that elements are
deleted using the proper function, so that m_n_deleted is updated.
I couldn't tell whether the unusu
As described in the covering note, this patch replaces handle_cache_entry
with a new function keep_cache_entry. It also ensures that elements are
deleted using the proper function, so that m_n_deleted is updated.
I couldn't tell whether the unusual name of the function
("gt_cleare_cache") is deli
