Re: [Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-16 Thread Rainer Orth
Hi Pierre-Marie, > On Wed, Dec 16, 2020 at 1:18 PM Pierre-Marie de Rodat > wrote: >> Thank you. I can reproduce the issue: at this point I suspect that my >> testing hasn’t detected this because of some inconsistency with my >> incremental builds. The actual correction is a few patches later in

Re: [Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-16 Thread Pierre-Marie de Rodat
On Wed, Dec 16, 2020 at 1:18 PM Pierre-Marie de Rodat wrote: > Thank you. I can reproduce the issue: at this point I suspect that my > testing hasn’t detected this because of some inconsistency with my > incremental builds. The actual correction is a few patches later in my > porting queue: I’m

Re: [Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-16 Thread Pierre-Marie de Rodat
Hello all, On Wed, Dec 16, 2020 at 9:31 AM Martin Liška wrote: > I've just create PR for it: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98312 Thank you. I can reproduce the issue: at this point I suspect that my testing hasn’t detected this because of some inconsistency with my incremental

Re: [Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-16 Thread Iain Sandoe via Gcc-patches
Rainer Orth wrote: Rainer Orth wrote: Hi Pierre-Marie, This fixes an issue when setting the baud rate. The baud rate is set using the cfsetospeed and cfsetispeed system calls. The code is using speed_t for clarity. The non-blocking status is only reset when Block is True. And serial

Re: [Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-16 Thread Rainer Orth
Hi Iain, > Rainer Orth wrote: > >> Hi Pierre-Marie, >> >>> This fixes an issue when setting the baud rate. The baud rate is set >>> using the cfsetospeed and cfsetispeed system calls. The code is using >>> speed_t for clarity. The non-blocking status is only reset when Block is >>> True. And

Re: [Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-16 Thread Martin Liška
On 12/16/20 8:56 AM, Iain Sandoe via Gcc-patches wrote: Rainer Orth wrote: Hi Pierre-Marie, This fixes an issue when setting the baud rate. The baud rate is set using the cfsetospeed and cfsetispeed system calls. The code is using speed_t for clarity. The non-blocking status is only reset

Re: [Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-15 Thread Iain Sandoe via Gcc-patches
Rainer Orth wrote: Hi Pierre-Marie, This fixes an issue when setting the baud rate. The baud rate is set using the cfsetospeed and cfsetispeed system calls. The code is using speed_t for clarity. The non-blocking status is only reset when Block is True. And serial blocking mode is now

Re: [Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-15 Thread Rainer Orth
Hi Pierre-Marie, > This fixes an issue when setting the baud rate. The baud rate is set > using the cfsetospeed and cfsetispeed system calls. The code is using > speed_t for clarity. The non-blocking status is only reset when Block is > True. And serial blocking mode is now properly set according

[Ada] Fix serial port baud rate setting on GNU/Linux

2020-12-15 Thread Pierre-Marie de Rodat
This fixes an issue when setting the baud rate. The baud rate is set using the cfsetospeed and cfsetispeed system calls. The code is using speed_t for clarity. The non-blocking status is only reset when Block is True. And serial blocking mode is now properly set according to termios manual. Add