Re: [C++ PATCH] C++2A P0386R1 - default member initializers for bit-fields

2017-09-27 Thread Nathan Sidwell
Jakub, The following patch implements P0386R1 - NSDMIs for bit-fields. While working on that, I've discovered our parser mishandles attributes on bitfields, already C++11 says: identifier[opt] attribute-specifier-seq[opt] : constant-expression in the grammar, but we actually parsed identifier[opt

Re: [C++ PATCH] C++2A P0386R1 - default member initializers for bit-fields

2017-09-19 Thread Jakub Jelinek
On Tue, Sep 19, 2017 at 08:59:23AM -0400, Tim Song wrote: > On Tue, Sep 19, 2017 at 8:54 AM, Jakub Jelinek wrote: > > Hi! > > > > The following patch implements P0386R1 - NSDMIs for bit-fields. > > It's P0683R1. Oops, got it right in the testcases, just not in the ChangeLog line from which I've

Re: [C++ PATCH] C++2A P0386R1 - default member initializers for bit-fields

2017-09-19 Thread Tim Song
On Tue, Sep 19, 2017 at 8:54 AM, Jakub Jelinek wrote: > Hi! > > The following patch implements P0386R1 - NSDMIs for bit-fields. It's P0683R1.

[C++ PATCH] C++2A P0386R1 - default member initializers for bit-fields

2017-09-19 Thread Jakub Jelinek
Hi! The following patch implements P0386R1 - NSDMIs for bit-fields. While working on that, I've discovered our parser mishandles attributes on bitfields, already C++11 says: identifier[opt] attribute-specifier-seq[opt] : constant-expression in the grammar, but we actually parsed identifier[opt] :