Re: [C++ PATCH] Deprecate -ffriend-injection

2018-02-16 Thread Jakub Jelinek
On Fri, Feb 16, 2018 at 01:54:15PM -0500, Jason Merrill wrote: > My dejagnu doesn't like "cc1plus" as a line number: > > ERROR: g++.old-deja/g++.jason/scoping15.C -std=gnu++98: expected > integer but got "cc1plus:" for " dg-warning 25 "ffriend-injection.* is > deprecated" "" { target *-*-* } cc1p

Re: [C++ PATCH] Deprecate -ffriend-injection

2018-02-16 Thread Nathan Sidwell
On 02/16/2018 01:54 PM, Jason Merrill wrote: My dejagnu doesn't like "cc1plus" as a line number: ERROR: g++.old-deja/g++.jason/scoping15.C -std=gnu++98: expected integer but got "cc1plus:" for " dg-warning 25 "ffriend-injection.* is deprecated" "" { target *-*-* } cc1plus: " I think I got dis

Re: [C++ PATCH] Deprecate -ffriend-injection

2018-02-16 Thread Nathan Sidwell
On 02/16/2018 01:52 PM, Sandra Loosemore wrote: The GCC documentation conventions say to use American spellings, not British  so in the patch hunk please s/behaviour/behavior/g American imperialist :) nathan -- Nathan Sidwell 2018-02-16 Nathan Sidwell * doc/extend.texi (Backwards C

Re: [C++ PATCH] Deprecate -ffriend-injection

2018-02-16 Thread Jason Merrill
My dejagnu doesn't like "cc1plus" as a line number: ERROR: g++.old-deja/g++.jason/scoping15.C -std=gnu++98: expected integer but got "cc1plus:" for " dg-warning 25 "ffriend-injection.* is deprecated" "" { target *-*-* } cc1plus: " On Fri, Feb 16, 2018 at 10:44 AM, Nathan Sidwell wrote: > This p

Re: [C++ PATCH] Deprecate -ffriend-injection

2018-02-16 Thread Sandra Loosemore
On 02/16/2018 08:44 AM, Nathan Sidwell wrote: Index: doc/extend.texi === --- doc/extend.texi (revision 257739) +++ doc/extend.texi (working copy) @@ -23881,11 +23881,23 @@ deprecated. @xref{Deprecated Features} @table @c

[C++ PATCH] Deprecate -ffriend-injection

2018-02-16 Thread Nathan Sidwell
This patch deprecates the -ffriend-injection option. 1) issue a deprecated warning, if the option is set. 2) if we do inject a visible friend, issue a warning. This warning is not inhibitable, like the for-scope behaviour. (Notice we never injected visible friend classes, only functions). 3)