Re: [C++ PATCH] Fix FIX_TRUNC_EXPR instantiation (PR c++/84942)

2018-03-23 Thread Jason Merrill
OK. On Fri, Mar 23, 2018 at 10:18 AM, Jakub Jelinek wrote: > On Thu, Mar 22, 2018 at 02:02:01PM -0400, Jason Merrill wrote: >> He hadn't yet checked in the relevant change, "Disable >> auto_is_implicit_function_template_parm_p while parsing attributes". >> That should happen

Re: [C++ PATCH] Fix FIX_TRUNC_EXPR instantiation (PR c++/84942)

2018-03-23 Thread Jakub Jelinek
On Thu, Mar 22, 2018 at 02:02:01PM -0400, Jason Merrill wrote: > He hadn't yet checked in the relevant change, "Disable > auto_is_implicit_function_template_parm_p while parsing attributes". > That should happen soon. > > > but with > > the following patch we don't ICE, because args is NULL and >

Re: [C++ PATCH] Fix FIX_TRUNC_EXPR instantiation (PR c++/84942)

2018-03-22 Thread Alexandre Oliva
On Mar 22, 2018, Jakub Jelinek wrote: > On Thu, Mar 22, 2018 at 02:02:01PM -0400, Jason Merrill wrote: >> > To my surprise, with latest Alex' changes tsubst_copy_and_build is still >> > called with FIX_TRUNC_EXPR (the (int) __builtin_inf () expression) >> >> He hadn't yet

Re: [C++ PATCH] Fix FIX_TRUNC_EXPR instantiation (PR c++/84942)

2018-03-22 Thread Jakub Jelinek
On Thu, Mar 22, 2018 at 02:02:01PM -0400, Jason Merrill wrote: > > To my surprise, with latest Alex' changes tsubst_copy_and_build is still > > called with FIX_TRUNC_EXPR (the (int) __builtin_inf () expression) > > He hadn't yet checked in the relevant change, "Disable >

Re: [C++ PATCH] Fix FIX_TRUNC_EXPR instantiation (PR c++/84942)

2018-03-22 Thread Jason Merrill
On Thu, Mar 22, 2018 at 4:14 AM, Jakub Jelinek wrote: > On Wed, Mar 21, 2018 at 12:01:58PM -0400, Jason Merrill wrote: >> On Wed, Mar 21, 2018 at 4:42 AM, Jakub Jelinek wrote: >> > On Tue, Mar 20, 2018 at 05:00:34PM -0400, Jason Merrill wrote: >> >> On Mon,

Re: [C++ PATCH] Fix FIX_TRUNC_EXPR instantiation (PR c++/84942)

2018-03-22 Thread Jakub Jelinek
On Wed, Mar 21, 2018 at 12:01:58PM -0400, Jason Merrill wrote: > On Wed, Mar 21, 2018 at 4:42 AM, Jakub Jelinek wrote: > > On Tue, Mar 20, 2018 at 05:00:34PM -0400, Jason Merrill wrote: > >> On Mon, Mar 19, 2018 at 3:50 PM, Jakub Jelinek wrote: > >> > +int

Re: [C++ PATCH] Fix FIX_TRUNC_EXPR instantiation (PR c++/84942)

2018-03-21 Thread Jason Merrill
On Wed, Mar 21, 2018 at 4:42 AM, Jakub Jelinek wrote: > On Tue, Mar 20, 2018 at 05:00:34PM -0400, Jason Merrill wrote: >> On Mon, Mar 19, 2018 at 3:50 PM, Jakub Jelinek wrote: >> > +int a(__attribute__((b((int)__builtin_inf() * 1ULL / auto; >> >> This

Re: [C++ PATCH] Fix FIX_TRUNC_EXPR instantiation (PR c++/84942)

2018-03-21 Thread Jakub Jelinek
On Tue, Mar 20, 2018 at 05:00:34PM -0400, Jason Merrill wrote: > On Mon, Mar 19, 2018 at 3:50 PM, Jakub Jelinek wrote: > > +int a(__attribute__((b((int)__builtin_inf() * 1ULL / auto; > > This seems like another situation like 84610 and 84642 that Alex sent > a patch for, of

Re: [C++ PATCH] Fix FIX_TRUNC_EXPR instantiation (PR c++/84942)

2018-03-20 Thread Jason Merrill
On Mon, Mar 19, 2018 at 3:50 PM, Jakub Jelinek wrote: > +int a(__attribute__((b((int)__builtin_inf() * 1ULL / auto; This seems like another situation like 84610 and 84642 that Alex sent a patch for, of 'auto' in an attribute wrongly being treated as an implicit template

[C++ PATCH] Fix FIX_TRUNC_EXPR instantiation (PR c++/84942)

2018-03-19 Thread Jakub Jelinek
Hi! We instantiate FIX_TRUNC_EXPR using cp_build_unary_op, but that function doesn't look like a good match for this tree, what it really does for it is: 1) handle error_operand_p 2) on ia64 only diagnose __fpreg uses (I believe a cast of __fpreg to int is fine, so we shouldn't warn) 3) and