Re: [C++ PATCH] Fix concepts vs. PCH (PR c++/92458, take 2)

2019-11-24 Thread Jason Merrill
On 11/22/19 3:08 PM, Jakub Jelinek wrote: On Fri, Nov 22, 2019 at 02:43:25PM -0500, Jason Merrill wrote: @@ -5358,6 +5410,18 @@ struct tree_cache_traits : simple_cache_map_traits, tree> { }; We should probably use tree_hash instead of default_hash_traits here. OK with or without that chan

Re: [C++ PATCH] Fix concepts vs. PCH (PR c++/92458, take 2)

2019-11-22 Thread Jakub Jelinek
On Fri, Nov 22, 2019 at 02:43:25PM -0500, Jason Merrill wrote: > > @@ -5358,6 +5410,18 @@ struct tree_cache_traits > > : simple_cache_map_traits, tree> { }; > > We should probably use tree_hash instead of default_hash_traits here. OK > with or without that change. Dunno, I'd say pointer_hash

Re: [C++ PATCH] Fix concepts vs. PCH (PR c++/92458, take 2)

2019-11-22 Thread Jason Merrill
On 11/22/19 2:08 PM, Jakub Jelinek wrote: On Wed, Nov 20, 2019 at 07:46:13PM -0500, Jason Merrill wrote: If decl_tree_cache_map will be needed in more than one spot, I'll probably need to move it to some generic header. Most of them probably need it, for code that uses the relevant features. E

[C++ PATCH] Fix concepts vs. PCH (PR c++/92458, take 2)

2019-11-22 Thread Jakub Jelinek
On Wed, Nov 20, 2019 at 07:46:13PM -0500, Jason Merrill wrote: > > If decl_tree_cache_map will be needed in more than one spot, I'll probably > > need to move it to some generic header. > > Most of them probably need it, for code that uses the relevant features. > Except debug_type_map, which prob