Re: [C++ PATCH] Fix cxx_eval_loop_expr ICE (PR c++/89652, take 2)

2019-03-13 Thread Jason Merrill
On 3/13/19 6:20 PM, Jakub Jelinek wrote: On Mon, Mar 11, 2019 at 11:21:00PM +0100, Jakub Jelinek wrote: The following testcase ICEs since my recent cxx_eval_loop_expr changes. The problem is that the Forget saved values of SAVE_EXPRs. inside of the loop can remove SAVE_EXPRs from new_ctx.values

Re: [C++ PATCH] Fix cxx_eval_loop_expr ICE (PR c++/89652)

2019-03-13 Thread Jason Merrill
On 3/13/19 10:08 PM, Jason Merrill wrote: On 3/11/19 6:21 PM, Jakub Jelinek wrote: Hi! The following testcase ICEs since my recent cxx_eval_loop_expr changes. The problem is that the Forget saved values of SAVE_EXPRs. inside of the loop can remove SAVE_EXPRs from new_ctx.values and if that is

Re: [C++ PATCH] Fix cxx_eval_loop_expr ICE (PR c++/89652)

2019-03-13 Thread Jason Merrill
On 3/11/19 6:21 PM, Jakub Jelinek wrote: Hi! The following testcase ICEs since my recent cxx_eval_loop_expr changes. The problem is that the Forget saved values of SAVE_EXPRs. inside of the loop can remove SAVE_EXPRs from new_ctx.values and if that is the last iteration, we can also do the loop

[C++ PATCH] Fix cxx_eval_loop_expr ICE (PR c++/89652, take 2)

2019-03-13 Thread Jakub Jelinek
On Mon, Mar 11, 2019 at 11:21:00PM +0100, Jakub Jelinek wrote: > The following testcase ICEs since my recent cxx_eval_loop_expr changes. > The problem is that the Forget saved values of SAVE_EXPRs. inside of the > loop can remove SAVE_EXPRs from new_ctx.values and if that is the last > iteration,

[C++ PATCH] Fix cxx_eval_loop_expr ICE (PR c++/89652)

2019-03-11 Thread Jakub Jelinek
Hi! The following testcase ICEs since my recent cxx_eval_loop_expr changes. The problem is that the Forget saved values of SAVE_EXPRs. inside of the loop can remove SAVE_EXPRs from new_ctx.values and if that is the last iteration, we can also do the loop at the end of function (which has been