Re: [C++ PATCH] Remove useless tokens from cp_parser_linkage_specification (PR c++/87393)

2018-11-21 Thread Jason Merrill
On 11/21/18 10:59 AM, Jakub Jelinek wrote: Hi! David's r251026 change added a weird trailing ->location. It doesn't seem to be useful for anything, matching_braces has its own code to track locations, so no need to do anything in the caller (and no other spot does something like that).

Re: [C++ PATCH] Remove useless tokens from cp_parser_linkage_specification (PR c++/87393)

2018-11-21 Thread David Malcolm
On Wed, 2018-11-21 at 16:59 +0100, Jakub Jelinek wrote: > Hi! > > David's r251026 change added a weird trailing ->location. > It doesn't seem to be useful for anything, matching_braces has its > own code > to track locations, so no need to do anything in the caller (and no > other > spot does

[C++ PATCH] Remove useless tokens from cp_parser_linkage_specification (PR c++/87393)

2018-11-21 Thread Jakub Jelinek
Hi! David's r251026 change added a weird trailing ->location. It doesn't seem to be useful for anything, matching_braces has its own code to track locations, so no need to do anything in the caller (and no other spot does something like that). Bootstrapped/regtested on x86_64-linux and