Re: [C++ PATCH] Toplevel asm volatile (PR c++/89585)

2019-03-07 Thread Jakub Jelinek
On Thu, Mar 07, 2019 at 10:11:56PM +0100, Matthias Klose wrote: > On 07.03.19 00:39, Jakub Jelinek wrote: > > The following patch tries to improve diagnostics of toplevel asm qualifiers > > in C++ by actually parsing them and complaining if they appear at toplevel, > > instead of just emitting a

Re: [C++ PATCH] Toplevel asm volatile (PR c++/89585)

2019-03-07 Thread Matthias Klose
On 07.03.19 00:39, Jakub Jelinek wrote: > Hi! > > The following patch tries to improve diagnostics of toplevel asm qualifiers > in C++ by actually parsing them and complaining if they appear at toplevel, > instead of just emitting a parse error that ( is expected, e.g. some > versions of Qt do

Re: [C++ PATCH] Toplevel asm volatile (PR c++/89585)

2019-03-06 Thread Jason Merrill
On Wed, Mar 6, 2019 at 6:39 PM Jakub Jelinek wrote: > > The following patch tries to improve diagnostics of toplevel asm qualifiers > in C++ by actually parsing them and complaining if they appear at toplevel, > instead of just emitting a parse error that ( is expected, e.g. some > versions of Qt

[C++ PATCH] Toplevel asm volatile (PR c++/89585)

2019-03-06 Thread Jakub Jelinek
Hi! The following patch tries to improve diagnostics of toplevel asm qualifiers in C++ by actually parsing them and complaining if they appear at toplevel, instead of just emitting a parse error that ( is expected, e.g. some versions of Qt do use toplevel asm volatile and apparently the Qt code