Re: [C++ Patch] PR 17212

2011-10-14 Thread Mike Stump
On Oct 13, 2011, at 4:19 PM, Paolo Carlini wrote: Ok for mainline? Ok.

Re: [C++ Patch] PR 17212

2011-10-14 Thread Jason Merrill
On 10/13/2011 07:19 PM, Paolo Carlini wrote: -@item -Wno-format-zero-length @r{(C and Objective-C only)} +@item -Wno-format-zero-length @r{(C, C++, Objective-C and Objective-C++ only)} I would just remove the {...only} to match the other -Wformat items. OK. Jason

Re: [C++ Patch] PR 17212

2011-10-14 Thread Paolo Carlini
On 10/14/2011 03:57 PM, Jason Merrill wrote: On 10/13/2011 07:19 PM, Paolo Carlini wrote: -@item -Wno-format-zero-length @r{(C and Objective-C only)} +@item -Wno-format-zero-length @r{(C, C++, Objective-C and Objective-C++ only)} I would just remove the {...only} to match the other -Wformat

[C++ Patch] PR 17212

2011-10-13 Thread Paolo Carlini
Hi, in this simple PR, submitter remarks that there isn't a real reason not to have -W(no-)format-zero-length working in C++ exactly like in C. In fact, the status quo is that the warning *is* active in C++ too, part of -Wformat, but it cannot be *disabled*, because -Wno-format-zero-length

Re: [C++ Patch] PR 17212

2011-10-13 Thread Jason Merrill
Why not support it in Obj-C++, too? Jason

Re: [C++ Patch] PR 17212

2011-10-13 Thread Paolo Carlini
Hi, Why not support it in Obj-C++, too? Yes I briefly wondered that but I know *so* little about that front end... Do you think we can just add it? Probably yes ;) Paolo

Re: [C++ Patch] PR 17212

2011-10-13 Thread Jason Merrill
On 10/13/2011 09:53 AM, Paolo Carlini wrote: Yes I briefly wondered that but I know *so* little about that front end... Do you think we can just add it? Probably yes ;) Definitely. Anything supported in C++ should also be in Obj-C++ by default. Jason

Re: [C++ Patch] PR 17212

2011-10-13 Thread Mike Stump
On Oct 13, 2011, at 6:53 AM, Paolo Carlini wrote: Why not support it in Obj-C++, too? Yes I briefly wondered that but I know *so* little about that front end... Do you think we can just add it? Probably yes ;) The ground rule is, make ObjC behave just like C, unless an ObjC expert decides

Re: [C++ Patch] PR 17212

2011-10-13 Thread Paolo Carlini
On 10/13/2011 04:24 PM, Jason Merrill wrote: On 10/13/2011 09:53 AM, Paolo Carlini wrote: Yes I briefly wondered that but I know *so* little about that front end... Do you think we can just add it? Probably yes ;) Definitely. Anything supported in C++ should also be in Obj-C++ by default.