Re: [C++ Patch] PR 51064

2012-01-04 Thread Jason Merrill
OK. Jason

Re: [C++ Patch] PR 51064

2012-01-04 Thread Paolo Carlini
Hi, I'm a bit nervous about the instantiated tree being a different kind of tree from the template one, such that TREE_NO_WARNING doesn't make sense on the new one. Maybe just check EXPR_P (r) as well. I see, better be safe. The below still passes testing. Ok? Thanks, Paolo.

Re: [C++ Patch] PR 51064

2012-01-04 Thread Jason Merrill
I'm a bit nervous about the instantiated tree being a different kind of tree from the template one, such that TREE_NO_WARNING doesn't make sense on the new one. Maybe just check EXPR_P (r) as well. Jason

[C++ Patch] PR 51064

2012-01-04 Thread Paolo Carlini
Hi, we emit spurious -Wparentheses warnings for template arguments, evidently because we are not propagating TREE_NO_WARNING during tsubstitution. I'm fixing the problem in a straightforward way, by using the same idiom already used elsewhere: call build_x_binary_op and then propagate TREE_