[C++ Patch] PR 54191

2012-08-08 Thread Paolo Carlini
Hi, this is a booted and tested patch which handles all the tests submitted as part of the PR besides the first 4, which require finish_decltype_type to use an instantiation_dependent_p along the lines of the work done as part of c++/51222. As I mentioned, I already verified that the latter w

Re: [C++ Patch] PR 54191

2012-08-27 Thread Jason Merrill
Let's do away with ba_quiet entirely and instead pass tf_none in cases where we would have set ba_quiet. #define DERIVED_FROM_P(PARENT, TYPE) \ - (lookup_base ((TYPE), (PARENT), ba_any, NULL) != NULL_TREE) + (lookup_base ((TYPE), (PARENT), ba_any, NULL, tf_warning_or_error) \ + != NULL_TRE

Re: [C++ Patch] PR 54191

2012-08-27 Thread Paolo Carlini
On 08/27/2012 06:28 PM, Jason Merrill wrote: Let's do away with ba_quiet entirely and instead pass tf_none in cases where we would have set ba_quiet. Thanks for the feedback. Indeed, as I tried to explain in an older message, that was also my understanding. The practical difficulty with the map

Re: [C++ Patch] PR 54191

2012-08-27 Thread Jason Merrill
On 08/27/2012 01:36 PM, Paolo Carlini wrote: Thanks for the feedback. Indeed, as I tried to explain in an older message, that was also my understanding. The practical difficulty with the mapping (which you can also guess from the current structure of get_delta_difference_1, the if (kind == bk_ina

Re: [C++ Patch] PR 54191

2012-08-27 Thread Paolo Carlini
On 08/27/2012 08:04 PM, Jason Merrill wrote: On 08/27/2012 01:36 PM, Paolo Carlini wrote: Thanks for the feedback. Indeed, as I tried to explain in an older message, that was also my understanding. The practical difficulty with the mapping (which you can also guess from the current structure of

Re: [C++ Patch] PR 54191

2012-08-27 Thread Jason Merrill
OK. Jason

Re: [C++ Patch] PR 54191

2012-09-05 Thread Paolo Carlini
On 08/28/2012 01:49 AM, Jason Merrill wrote: OK. Thanks Jason. I have now committed the patch together with the three additional tests which depended on instantiation_dependent_p. Thanks again, Paolo.