[C++ Patch] PR 94034 ("[10 Regression] Broken diagnostic: 'result_decl' not supported by dump_expr")

2020-03-06 Thread Paolo Carlini
Hi, in this apparently simple regression we end up producing garbled diagnostic because dump_expr (called via verify_constant) doesn't handle RESULT_DECL. I think it makes sense to add the tree code together with all the other *_DECL. Tested x86_64-linux. Thanks, Paolo.

Re: [C++ Patch] PR 94034 ("[10 Regression] Broken diagnostic: 'result_decl' not supported by dump_expr")

2020-03-06 Thread Paolo Carlini
... the patch ;) Paolo. Fix "PR c++/94034 Broken diagnostic: 'result_decl' not supported by dump_expr" A rather simple diagnostic issue where we failed to handle RESULT_DECL in dump_expr. Tested x86_64-linux. /cp PR c++/94034 * error.c (dump_expr): Handle RESULT_DECL like

Re: [C++ Patch] PR 94034 ("[10 Regression] Broken diagnostic: 'result_decl' not supported by dump_expr")

2020-03-06 Thread Marek Polacek
On Fri, Mar 06, 2020 at 04:58:32PM +0100, Paolo Carlini wrote: > ... the patch ;) > > Paolo. > > Fix "PR c++/94034 Broken diagnostic: 'result_decl' not supported by dump_expr" > > A rather simple diagnostic issue where we failed to handle RESULT_DECL in > dump_expr. > > Tested x86_64-linux. >

Re: [C++ Patch] PR 94034 ("[10 Regression] Broken diagnostic: 'result_decl' not supported by dump_expr")

2020-03-06 Thread Jason Merrill
On 3/6/20 11:02 AM, Marek Polacek wrote: On Fri, Mar 06, 2020 at 04:58:32PM +0100, Paolo Carlini wrote: ... the patch ;) Paolo. Fix "PR c++/94034 Broken diagnostic: 'result_decl' not supported by dump_expr" A rather simple diagnostic issue where we failed to handle RESULT_DECL in dump_expr

Re: [C++ Patch] PR 94034 ("[10 Regression] Broken diagnostic: 'result_decl' not supported by dump_expr")

2020-03-06 Thread Marek Polacek
On Fri, Mar 06, 2020 at 07:40:20PM -0500, Jason Merrill wrote: > On 3/6/20 11:02 AM, Marek Polacek wrote: > > On Fri, Mar 06, 2020 at 04:58:32PM +0100, Paolo Carlini wrote: > > > ... the patch ;) > > > > > > Paolo. > > > > > > > > Fix "PR c++/94034 Broken diagnostic: 'result_decl' not supported

Re: [C++ Patch] PR 94034 ("[10 Regression] Broken diagnostic: 'result_decl' not supported by dump_expr")

2020-03-06 Thread Jason Merrill
On 3/6/20 8:24 PM, Marek Polacek wrote: On Fri, Mar 06, 2020 at 07:40:20PM -0500, Jason Merrill wrote: On 3/6/20 11:02 AM, Marek Polacek wrote: On Fri, Mar 06, 2020 at 04:58:32PM +0100, Paolo Carlini wrote: ... the patch ;) Paolo. Fix "PR c++/94034 Broken diagnostic: 'result_decl' not sup