Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-29 Thread Jason Merrill
On 3/28/19 7:54 PM, Martin Sebor wrote: On 3/28/19 11:45 AM, Jason Merrill wrote: On 3/27/19 6:56 PM, Martin Sebor wrote: On 3/27/19 3:11 PM, Martin Sebor wrote: On 3/27/19 4:44 AM, Jonathan Wakely wrote: On 21/03/19 15:03 -0400, Jason Merrill wrote: On 3/20/19 6:06 PM, Marek Polacek wrote:

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-28 Thread Martin Sebor
On 3/28/19 11:45 AM, Jason Merrill wrote: On 3/27/19 6:56 PM, Martin Sebor wrote: On 3/27/19 3:11 PM, Martin Sebor wrote: On 3/27/19 4:44 AM, Jonathan Wakely wrote: On 21/03/19 15:03 -0400, Jason Merrill wrote: On 3/20/19 6:06 PM, Marek Polacek wrote: On Wed, Mar 20, 2019 at 10:58:32PM

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-28 Thread Jason Merrill
On 3/27/19 6:56 PM, Martin Sebor wrote: On 3/27/19 3:11 PM, Martin Sebor wrote: On 3/27/19 4:44 AM, Jonathan Wakely wrote: On 21/03/19 15:03 -0400, Jason Merrill wrote: On 3/20/19 6:06 PM, Marek Polacek wrote: On Wed, Mar 20, 2019 at 10:58:32PM +0100, Jakub Jelinek wrote: On Wed, Mar 20,

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-27 Thread Martin Sebor
On 3/27/19 3:11 PM, Martin Sebor wrote: On 3/27/19 4:44 AM, Jonathan Wakely wrote: On 21/03/19 15:03 -0400, Jason Merrill wrote: On 3/20/19 6:06 PM, Marek Polacek wrote: On Wed, Mar 20, 2019 at 10:58:32PM +0100, Jakub Jelinek wrote: On Wed, Mar 20, 2019 at 05:55:04PM -0400, Marek Polacek

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-27 Thread Martin Sebor
On 3/27/19 4:44 AM, Jonathan Wakely wrote: On 21/03/19 15:03 -0400, Jason Merrill wrote: On 3/20/19 6:06 PM, Marek Polacek wrote: On Wed, Mar 20, 2019 at 10:58:32PM +0100, Jakub Jelinek wrote: On Wed, Mar 20, 2019 at 05:55:04PM -0400, Marek Polacek wrote: On Wed, Mar 20, 2019 at 04:56:33PM

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-27 Thread Jason Merrill
On 3/27/19 12:24 PM, Martin Sebor wrote: On 3/21/19 1:03 PM, Jason Merrill wrote: On 3/20/19 6:06 PM, Marek Polacek wrote: On Wed, Mar 20, 2019 at 10:58:32PM +0100, Jakub Jelinek wrote: On Wed, Mar 20, 2019 at 05:55:04PM -0400, Marek Polacek wrote: On Wed, Mar 20, 2019 at 04:56:33PM -0300,

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-27 Thread Martin Sebor
On 3/21/19 1:03 PM, Jason Merrill wrote: On 3/20/19 6:06 PM, Marek Polacek wrote: On Wed, Mar 20, 2019 at 10:58:32PM +0100, Jakub Jelinek wrote: On Wed, Mar 20, 2019 at 05:55:04PM -0400, Marek Polacek wrote: On Wed, Mar 20, 2019 at 04:56:33PM -0300, Alexandre Oliva wrote: On Mar 20, 2019,

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-27 Thread Jonathan Wakely
On 21/03/19 15:03 -0400, Jason Merrill wrote: On 3/20/19 6:06 PM, Marek Polacek wrote: On Wed, Mar 20, 2019 at 10:58:32PM +0100, Jakub Jelinek wrote: On Wed, Mar 20, 2019 at 05:55:04PM -0400, Marek Polacek wrote: On Wed, Mar 20, 2019 at 04:56:33PM -0300, Alexandre Oliva wrote: On Mar 20,

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-21 Thread Jason Merrill
On 3/20/19 6:06 PM, Marek Polacek wrote: On Wed, Mar 20, 2019 at 10:58:32PM +0100, Jakub Jelinek wrote: On Wed, Mar 20, 2019 at 05:55:04PM -0400, Marek Polacek wrote: On Wed, Mar 20, 2019 at 04:56:33PM -0300, Alexandre Oliva wrote: On Mar 20, 2019, Marek Polacek wrote: This test fails with

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-20 Thread Marek Polacek
On Wed, Mar 20, 2019 at 10:58:32PM +0100, Jakub Jelinek wrote: > On Wed, Mar 20, 2019 at 05:55:04PM -0400, Marek Polacek wrote: > > On Wed, Mar 20, 2019 at 04:56:33PM -0300, Alexandre Oliva wrote: > > > On Mar 20, 2019, Marek Polacek wrote: > > > > > > > This test fails with > > > >

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-20 Thread Jakub Jelinek
On Wed, Mar 20, 2019 at 05:55:04PM -0400, Marek Polacek wrote: > On Wed, Mar 20, 2019 at 04:56:33PM -0300, Alexandre Oliva wrote: > > On Mar 20, 2019, Marek Polacek wrote: > > > > > This test fails with > > > pr88534.C:58:1: sorry, unimplemented: string literal in function template > > >

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-20 Thread Marek Polacek
On Wed, Mar 20, 2019 at 04:56:33PM -0300, Alexandre Oliva wrote: > On Mar 20, 2019, Marek Polacek wrote: > > > This test fails with > > pr88534.C:58:1: sorry, unimplemented: string literal in function template > > signature > > Interesting... gcc-8 rejected it with an error message rejecting

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-20 Thread Alexandre Oliva
On Mar 20, 2019, Marek Polacek wrote: > This test fails with > pr88534.C:58:1: sorry, unimplemented: string literal in function template > signature Interesting... gcc-8 rejected it with an error message rejecting the template parameter, but my latest trunk build (dated Mar 13, r269641)

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-20 Thread Marek Polacek
On Fri, Mar 15, 2019 at 10:53:35AM -0300, Alexandre Oliva wrote: > On Mar 14, 2019, Jason Merrill wrote: > > >> You can use VAR_P for this. > > > OK with that change. > > Thanks, I went ahead and also added a test before dereferencing it, > since there was evidence shortly thereafter that it

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-15 Thread Alexandre Oliva
On Mar 14, 2019, Jason Merrill wrote: >> You can use VAR_P for this. > OK with that change. Thanks, I went ahead and also added a test before dereferencing it, since there was evidence shortly thereafter that it could possibly be NULL. Here's what I'm installing. P0732R2 / C++ 2a introduce

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-14 Thread Jason Merrill
On 3/14/19 4:20 PM, Marek Polacek wrote: On Thu, Mar 14, 2019 at 05:14:49PM -0300, Alexandre Oliva wrote: P0732R2 / C++ 2a introduce class literals as template parameters. The front-end uses VAR_DECLs constructed from such literals to bind the template PARM_DECLs, but dwarf2out.c used to

Re: [C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-14 Thread Marek Polacek
On Thu, Mar 14, 2019 at 05:14:49PM -0300, Alexandre Oliva wrote: > P0732R2 / C++ 2a introduce class literals as template parameters. The > front-end uses VAR_DECLs constructed from such literals to bind the > template PARM_DECLs, but dwarf2out.c used to reject such VAR_DECLs. > > Taking

[C++ debug PATCH] [PR88534] accept VAR_DECL in class literal template parms

2019-03-14 Thread Alexandre Oliva
P0732R2 / C++ 2a introduce class literals as template parameters. The front-end uses VAR_DECLs constructed from such literals to bind the template PARM_DECLs, but dwarf2out.c used to reject such VAR_DECLs. Taking DECL_INITIAL from such VAR_DECLs enables the generation of DW_AT_const_value for