[C/C++ PATCH] Fix merge_decls/duplicate_decls DECL_USER_ALIGN/DECL_ALIGN handling (PR c/52181)

2012-02-09 Thread Jakub Jelinek
Hi! DECL_USER_ALIGN bit used to be formerly in tree_decl_common structure directly, thus the memcpy merge_decls performs used to copy also the DECL_USER_ALIGN (newdecl) bit to DECL_USER_ALIGN (olddecl). But it has been moved into tree_base, which is not copied that way. This means that in C if ol

Re: [C/C++ PATCH] Fix merge_decls/duplicate_decls DECL_USER_ALIGN/DECL_ALIGN handling (PR c/52181)

2012-02-09 Thread Richard Guenther
On Thu, Feb 9, 2012 at 12:38 PM, Jakub Jelinek wrote: > Hi! > > DECL_USER_ALIGN bit used to be formerly in tree_decl_common structure > directly, thus the memcpy merge_decls performs used to copy also the > DECL_USER_ALIGN (newdecl) bit to DECL_USER_ALIGN (olddecl).  But > it has been moved into t

Re: [C/C++ PATCH] Fix merge_decls/duplicate_decls DECL_USER_ALIGN/DECL_ALIGN handling (PR c/52181)

2012-02-09 Thread Jakub Jelinek
On Thu, Feb 09, 2012 at 12:54:59PM +0100, Richard Guenther wrote: > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > I'd say this needs to be backported to at least the point where we moved > the align fields. Agreed, but I'd wait with the backports a little bit.

Re: [C/C++ PATCH] Fix merge_decls/duplicate_decls DECL_USER_ALIGN/DECL_ALIGN handling (PR c/52181)

2012-02-09 Thread Joseph S. Myers
On Thu, 9 Feb 2012, Jakub Jelinek wrote: > 2012-02-09 Jakub Jelinek > > PR c/52181 > * c-decl.c (merge_decls): Copy DECL_USER_ALIGN bit from olddecl to > newdecl. > > * decl.c (duplicate_decls): If olddecl has bigger DECL_ALIGN than > newdecl, copy DECL_ALIGN to

Re: [C/C++ PATCH] Fix merge_decls/duplicate_decls DECL_USER_ALIGN/DECL_ALIGN handling (PR c/52181)

2012-02-13 Thread Jason Merrill
OK. Jason