Re: [COMMITTED] [range-op-float] Implement MINUS_EXPR.

2022-11-09 Thread Aldy Hernandez via Gcc-patches
I have reverted the patch while I sort this out. Thanks for the report and especially for the distilled test. It's very useful. Aldy On Wed, Nov 9, 2022 at 2:58 PM Xi Ruoyao wrote: > > On Wed, 2022-11-09 at 21:49 +0800, Xi Ruoyao wrote: > > Hi Aldy, > > > > This commit breaks the attached test

Re: [COMMITTED] [range-op-float] Implement MINUS_EXPR.

2022-11-09 Thread Xi Ruoyao via Gcc-patches
On Wed, 2022-11-09 at 21:49 +0800, Xi Ruoyao wrote: > Hi Aldy, > > This commit breaks the attached test case at -O2 on x86_64-linux-gnu and ^^^ Ah, not this one. I meant r13-3842 "Implement op[12]_range operators for PLUS_EXPR and MINUS_EXPR." > loongarch64-linux-gnu :(. > > The code

Re: [COMMITTED] [range-op-float] Implement MINUS_EXPR.

2022-11-09 Thread Xi Ruoyao via Gcc-patches
Hi Aldy, This commit breaks the attached test case at -O2 on x86_64-linux-gnu and loongarch64-linux-gnu :(. The code is simplified from Glibc: the breakage causes two Glibc test failures on loongarch64-linux-gnu. Reverting the commit can fix the breakage. On Wed, 2022-11-09 at 08:07 +0100, Aldy

[COMMITTED] [range-op-float] Implement MINUS_EXPR.

2022-11-08 Thread Aldy Hernandez via Gcc-patches
Now that the generic parts of the binary operators have been abstracted, implementing MINUS_EXPR is a cinch. The op[12]_range entries will be submitted as a follow-up. gcc/ChangeLog: * range-op-float.cc (class foperator_minus): New. (floating_op_table::floating_op_table): Add MIN