Re: [COMMITTED] PR tree-optimization/101741 - Ensure toupper and tolower follow the expected pattern.

2021-08-10 Thread Jakub Jelinek via Gcc-patches
On Tue, Aug 10, 2021 at 04:14:15PM +0200, Richard Biener via Gcc-patches wrote: > OK, so gimple_builtin_call_types_compatible_p only checks that the > call is consistent with the fndecl type - iff the declaration is incompatible > with the declaration as specified by builtins.def then that's of cou

Re: [COMMITTED] PR tree-optimization/101741 - Ensure toupper and tolower follow the expected pattern.

2021-08-10 Thread Richard Biener via Gcc-patches
On Tue, Aug 10, 2021 at 3:21 PM Andrew MacLeod wrote: > > On 8/10/21 3:45 AM, Richard Biener wrote: > > On Mon, Aug 9, 2021 at 10:31 PM Andrew MacLeod via Gcc-patches > > wrote: > >> The user has overridden the function name "toupper" . Its marked as a > >> builtin function, presumably because it

Re: [COMMITTED] PR tree-optimization/101741 - Ensure toupper and tolower follow the expected pattern.

2021-08-10 Thread Andrew MacLeod via Gcc-patches
On 8/10/21 3:45 AM, Richard Biener wrote: On Mon, Aug 9, 2021 at 10:31 PM Andrew MacLeod via Gcc-patches wrote: The user has overridden the function name "toupper" . Its marked as a builtin function, presumably because it matches the name. In range folding, we were assuming the LHS and the par

Re: [COMMITTED] PR tree-optimization/101741 - Ensure toupper and tolower follow the expected pattern.

2021-08-10 Thread Richard Biener via Gcc-patches
On Mon, Aug 9, 2021 at 10:31 PM Andrew MacLeod via Gcc-patches wrote: > > The user has overridden the function name "toupper" . Its marked as a > builtin function, presumably because it matches the name. In range > folding, we were assuming the LHS and the parameter were compatible > types... bu

[COMMITTED] PR tree-optimization/101741 - Ensure toupper and tolower follow the expected pattern.

2021-08-09 Thread Andrew MacLeod via Gcc-patches
The user has overridden the function name "toupper" . Its marked as a builtin function, presumably because it matches the name.  In range folding, we were assuming the LHS and the parameter were compatible types...  but they are not in this case.. I don't know if we should be marking such a th