Re: [GOOGLE] Remove overly-aggressive LIPO assert

2015-12-08 Thread Xinliang David Li
ok. David On Fri, Dec 4, 2015 at 11:29 AM, Teresa Johnson wrote: > Ping. > Thanks, Teresa > > On Wed, Dec 2, 2015 at 12:46 PM, Teresa Johnson wrote: >> Remove an assert that was overly-strict and already partially redundant >> with an immediately prior assert. In this case we had a hidden visib

Re: [GOOGLE] Remove overly-aggressive LIPO assert

2015-12-04 Thread Teresa Johnson
Ping. Thanks, Teresa On Wed, Dec 2, 2015 at 12:46 PM, Teresa Johnson wrote: > Remove an assert that was overly-strict and already partially redundant > with an immediately prior assert. In this case we had a hidden visibility > function clone that was created after the LIPO link due to indirect c

[GOOGLE] Remove overly-aggressive LIPO assert

2015-12-02 Thread Teresa Johnson
Remove an assert that was overly-strict and already partially redundant with an immediately prior assert. In this case we had a hidden visibility function clone that was created after the LIPO link due to indirect call promotion. It is a cgraph_is_aux_decl_external node. Fixes failures and passes