Re: [GOOGLE] Restrict the count_scale to be no larger than 100%

2014-01-22 Thread Xinliang David Li
ok. David On Wed, Jan 22, 2014 at 3:23 PM, Dehao Chen wrote: > Unfortunately, copy_cfg_body is actually using basic block count > instead of cgraph edge count. Thus even fixing up the call graph does > not solve the problem. The 2nd chunk of the patch (cgraphclones.c) is > actually not necessary

Re: [GOOGLE] Restrict the count_scale to be no larger than 100%

2014-01-22 Thread Dehao Chen
Unfortunately, copy_cfg_body is actually using basic block count instead of cgraph edge count. Thus even fixing up the call graph does not solve the problem. The 2nd chunk of the patch (cgraphclones.c) is actually not necessary. We only need the first part (tree-inline.c). Thanks, Dehao On Fri, J

Re: [GOOGLE] Restrict the count_scale to be no larger than 100%

2014-01-17 Thread Xinliang David Li
Can callgraph node count be fixed up properly instead of doing individual fixups like this? David On Fri, Jan 17, 2014 at 2:38 PM, Dehao Chen wrote: > In AutoFDO, sometime edge count might be propagated to be too large > due to bad debug info. In this cases, we need to make sure the count > scal

[GOOGLE] Restrict the count_scale to be no larger than 100%

2014-01-17 Thread Dehao Chen
In AutoFDO, sometime edge count might be propagated to be too large due to bad debug info. In this cases, we need to make sure the count scale is no larger than 100% otherwise it'll make real hot code cold. Bootstrapped and passed regression test. Performance test on-going. OK for google-4_8 if p