Re: [GOOGLE] Workaround a bug in AutoFDO which may leads to infinite loop for inlined assembly

2013-04-21 Thread Teresa Johnson
Looks ok to me. Teresa On Sun, Apr 21, 2013 at 7:15 PM, Dehao Chen wrote: > Thanks for the comment, new patch attached: > > Index: gcc/auto-profile.c > === > --- gcc/auto-profile.c (revision 198117) > +++ gcc/auto-profile.c (working

Re: [GOOGLE] Workaround a bug in AutoFDO which may leads to infinite loop for inlined assembly

2013-04-21 Thread Dehao Chen
Thanks for the comment, new patch attached: Index: gcc/auto-profile.c === --- gcc/auto-profile.c (revision 198117) +++ gcc/auto-profile.c (working copy) @@ -623,6 +623,10 @@ static tree get_function_decl_from_block (tree block) {

Re: [GOOGLE] Workaround a bug in AutoFDO which may leads to infinite loop for inlined assembly

2013-04-21 Thread Teresa Johnson
On Sun, Apr 21, 2013 at 4:51 PM, Dehao Chen wrote: > This patch fixed a bug in getting inline stacks: if there is no > location info attached to a block, we should *not* try to get its > function name because it could result in infinite loop. Is the infinite loop within get_function_decl_from_blo

[GOOGLE] Workaround a bug in AutoFDO which may leads to infinite loop for inlined assembly

2013-04-21 Thread Dehao Chen
This patch fixed a bug in getting inline stacks: if there is no location info attached to a block, we should *not* try to get its function name because it could result in infinite loop. Bootstrapped and passed all regression tests. Ok for gcc-4_7 branch? Thanks, Dehao Index: gcc/auto-profile.c