Re: [GSoC] type of an isl_ast_expr_id

2014-07-31 Thread Roman Gareev
Could you please advise me how is it better to answer the following questions of Sven: In what way is it not optimal? That is, what are your optimality criteria? (I could answer them, but I don't want to miss anything) -- Cheers, Roman Gareev.

Re: [GSoC] type of an isl_ast_expr_id

2014-07-31 Thread Tobias Grosser
On 31/07/2014 08:19, Roman Gareev wrote: Could you please advise me how is it better to answer the following questions of Sven: In what way is it not optimal? That is, what are your optimality criteria? (I could answer them, but I don't want to miss anything) Don't worry. Just give it a

Re: [GSoC] type of an isl_ast_expr_id

2014-07-30 Thread Roman Gareev
Blindly converting type sizes is not a good idea and may be problematic when we switch to smaller types. As we can obviously only improve this when we have the appropriate support in isl, I think the attached patch is fine. However, please add a fixme that states that this should be looked at

Re: [GSoC] type of an isl_ast_expr_id

2014-07-30 Thread Tobias Grosser
On 30/07/2014 09:56, Roman Gareev wrote: Blindly converting type sizes is not a good idea and may be problematic when we switch to smaller types. As we can obviously only improve this when we have the appropriate support in isl, I think the attached patch is fine. However, please add a fixme

Re: [GSoC] type of an isl_ast_expr_id

2014-07-30 Thread Roman Gareev
OK. I proposed a slightly longer description. With the updated description, you can commit this patch. I've fixed the fixme. FIXME: We should replace blind conversation of id's type with derivation of the optimal type when we get the corresponding isl support. Blindly converting type sizes may

Re: [GSoC] type of an isl_ast_expr_id

2014-07-30 Thread Tobias Grosser
On 30/07/2014 14:32, Roman Gareev wrote: OK. I proposed a slightly longer description. With the updated description, you can commit this patch. I've fixed the fixme. FIXME: We should replace blind conversation of id's type with derivation of the optimal type when we get the corresponding isl

[GSoC] type of an isl_ast_expr_id

2014-07-29 Thread Roman Gareev
I've tested Graphite with the ISL AST generator as the main code generator and found out the following problem: in the current implementation the gcc_expression_from_isl_ast_expr_id can return a tree of a type, which doesn't correspond to the type chosen for graphite expressions. If we try, for

Re: [GSoC] type of an isl_ast_expr_id

2014-07-29 Thread Tobias Grosser
On 29/07/2014 12:14, Roman Gareev wrote: I've tested Graphite with the ISL AST generator as the main code generator and found out the following problem: in the current implementation the gcc_expression_from_isl_ast_expr_id can return a tree of a type, which doesn't correspond to the type chosen