Re: [Google] Use line offset instead of absolute lineno to represent AutoFDO profile

2013-04-11 Thread Xinliang David Li
yes -- Dehao first needs to rip out some internal dependencies for the profile generation tool before it can be pushed upstream. David On Thu, Apr 11, 2013 at 2:04 PM, Steven Bosscher wrote: > On Thu, Apr 11, 2013 at 1:47 AM, Dehao Chen wrote: >> Hi, >> >> This patch >> 1. Uses relative line off

Re: [Google] Use line offset instead of absolute lineno to represent AutoFDO profile

2013-04-11 Thread Steven Bosscher
On Thu, Apr 11, 2013 at 1:47 AM, Dehao Chen wrote: > Hi, > > This patch > 1. Uses relative line offset (lineno - start_lineno_of_function) to > represent AutoFDO profile. This ensures profile still work for > modified source code. Is this something that is possible to do on trunk, too? Sounds like

Re: [Google] Use line offset instead of absolute lineno to represent AutoFDO profile

2013-04-11 Thread Xinliang David Li
Ok. As followup, the profile generation tool should be moved into compiler space to avoid format mismatch. David On Wed, Apr 10, 2013 at 4:47 PM, Dehao Chen wrote: > Hi, > > This patch > 1. Uses relative line offset (lineno - start_lineno_of_function) to > represent AutoFDO profile. This ensure

[Google] Use line offset instead of absolute lineno to represent AutoFDO profile

2013-04-10 Thread Dehao Chen
Hi, This patch 1. Uses relative line offset (lineno - start_lineno_of_function) to represent AutoFDO profile. This ensures profile still work for modified source code. 2. When matching the profile, add function name (bfd_name) to match the inline stack. Bootstrapped and passed regression tests.