Re: [Google 4.6] Backport C++ canonicalization patch (issue6297080)

2012-06-12 Thread Diego Novillo
On 12-06-12 12:57 , Sterling Augustine wrote: The wrapper code is the same, but the internal call is not--"lang_decl_name" and "decl_as_string" return different strings, and their interface is different so it wouldn't be easy to pass a function pointer. So, I'm not sure how you would combine th

Re: [Google 4.6] Backport C++ canonicalization patch (issue6297080)

2012-06-12 Thread Sterling Augustine
On Tue, Jun 12, 2012 at 9:36 AM, Diego Novillo wrote: > On 12-06-12 11:58 , Sterling Augustine wrote: > >> +/* Wrap lang_decl_name with options appropriate for dwarf.  */ >> + >> +const char * >> +lang_decl_dwarf_name (tree decl, int v, bool translate) >> +{ >> +  const char *name; >> +  /* Curiou

Re: [Google 4.6] Backport C++ canonicalization patch (issue6297080)

2012-06-12 Thread Diego Novillo
On 12-06-12 11:58 , Sterling Augustine wrote: +/* Wrap lang_decl_name with options appropriate for dwarf. */ + +const char * +lang_decl_dwarf_name (tree decl, int v, bool translate) +{ + const char *name; + /* Curiously, reinit_cxx_pp doesn't reset the flags field, so setting the flag +

[Google 4.6] Backport C++ canonicalization patch (issue6297080)

2012-06-12 Thread Sterling Augustine
The enclosed patch for Google 4.6 backports the final pubnames-canonicalization patch from top of trunk. It differs slightly from the earlier one because google/4.6 had an earlier implementation already present. OK for Google 4.6? Sterling 2012-06-11 Sterling Augustine * gcc/c-famil