[LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Alex Potapenko
Hi! Building GCC 7.2.0 libgo against uClibc-ng 1.0.26 results in the following error: > runtime_sysinfo.go:418:17: error: use of undefined type > ‘___uclibc_locale_struct’ This happens because -fdump-go-spec probably generates types only from typedef declarations, ignoring structs, like "struct

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Ian Lance Taylor
On Fri, Sep 29, 2017 at 1:38 AM, Alex Potapenko wrote: > > Building GCC 7.2.0 libgo against uClibc-ng 1.0.26 results in the following > error: > >> runtime_sysinfo.go:418:17: error: use of undefined type >> ‘___uclibc_locale_struct’ > > > This happens because -fdump-go-spec probably generates type

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Alex Potapenko
(Sorry for the rerepost: the list doesn't accept any attachments) Hi Ian, On Fri, Sep 29, 2017 at 3:56 PM, Ian Lance Taylor wrote: > On Fri, Sep 29, 2017 at 1:38 AM, Alex Potapenko > wrote: > > > > Building GCC 7.2.0 libgo against uClibc-ng 1.0.26 results in the > following > > error: > > > >>

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Ian Lance Taylor
On Fri, Sep 29, 2017 at 6:28 AM, Alex Potapenko wrote: > (Sorry for the rerepost: the list doesn't accept any attachments) > > Hi Ian, > > On Fri, Sep 29, 2017 at 3:56 PM, Ian Lance Taylor wrote: >> >> On Fri, Sep 29, 2017 at 1:38 AM, Alex Potapenko >> wrote: >> > >> > Building GCC 7.2.0 libgo a

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Alex Potapenko
On Fri, Sep 29, 2017 at 4:44 PM, Ian Lance Taylor wrote: > > Thanks. Yes, the problem is that -fdump-go-spec is faithfully > reporting a dangling type definition, which is fine in C but not in > Go. Since we don't care about any of the locale stuff anyhow, I'm > inclined to a patch like the appe

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Ian Lance Taylor
On Fri, Sep 29, 2017 at 7:08 AM, Alex Potapenko wrote: > On Fri, Sep 29, 2017 at 4:44 PM, Ian Lance Taylor wrote: >> >> Thanks. Yes, the problem is that -fdump-go-spec is faithfully >> reporting a dangling type definition, which is fine in C but not in >> Go. Since we don't care about any of th

Re: [LIBGO PATCH] Fix compilation error against uClibc-ng: runtime_sysinfo.go: error: use of undefined type ‘___uclibc_locale_struct’

2017-09-29 Thread Alex Potapenko
On Fri, Sep 29, 2017 at 5:15 PM, Ian Lance Taylor wrote: > > Thanks. Committed to mainline. > Great, thanks! -- Best regards, Alex Potapenko