Re: Re: [NOT CODE REVIEW] [PATCH v3 1/1] [RISC-V] Add support for _Bfloat16

2024-05-16 Thread Xiao Zeng
2024-05-16 16:55  Kito Cheng wrote: > >Hi Xiao Zeng: > >Just wondering why use _Bfloat16 rather than __bf16? you mention >__bf16 in comment, but implementation use _Bfloat16? Obviously, this is a mistake. This patch has spanned a considerable amount of time locally. I will submit a new patch to c

Re: [NOT CODE REVIEW] [PATCH v3 1/1] [RISC-V] Add support for _Bfloat16

2024-05-16 Thread Kito Cheng
Hi Xiao Zeng: Just wondering why use _Bfloat16 rather than __bf16? you mention __bf16 in comment, but implementation use _Bfloat16? I would like to use __bf16 to make it consistent between LLVM and psABI if possible :)

Re: [NOT CODE REVIEW] [PATCH v3 1/1] [RISC-V] Add support for _Bfloat16

2024-05-14 Thread Andreas Schwab
This breaks libstdc++-abi/abi_check. 3 incompatible symbols 0 _ZTIPKDF16b typeinfo for std::bfloat16_t const* version status: incompatible CXXABI_1.3.14 type: object type size: 32 status: added 1 _ZTIPDF16b typeinfo for std::bfloat16_t* version status: incompatible CXXABI_1.3.14 type: object ty

Re: [NOT CODE REVIEW] [PATCH v3 1/1] [RISC-V] Add support for _Bfloat16

2024-05-06 Thread Jeff Law
On 5/5/24 6:38 PM, Xiao Zeng wrote: 1 At point , BF16 has already been completed "post public review". 2 LLVM has also added support for RISCV BF16 in and . 3 According to t

[NOT CODE REVIEW] [PATCH v3 1/1] [RISC-V] Add support for _Bfloat16

2024-05-05 Thread Xiao Zeng
1 At point , BF16 has already been completed "post public review". 2 LLVM has also added support for RISCV BF16 in and . 3 According to the discussion