Re: [PATCH, AArch64] Negate with Compare instruction

2013-04-25 Thread Marcus Shawcroft
Looks OK to me. Thank you. /Marcus On 22 April 2013 08:15, Hurugalawadi, Naveen wrote: > Hi, > >>> This and the preceding scan are the same pattern. So if either passes >>> you'll fail to detect a failure in the other. > > Thanks for the suggestion. > > Please find attached the modified patch a

Re: [PATCH, AArch64] Negate with Compare instruction

2013-04-22 Thread Hurugalawadi, Naveen
Hi, >> This and the preceding scan are the same pattern. So if either passes >> you'll fail to detect a failure in the other. Thanks for the suggestion. Please find attached the modified patch as per your suggestions. Please review the same and let me know if there should be any further modific

Re: [PATCH, AArch64] Negate with Compare instruction

2013-04-19 Thread Richard Earnshaw
On 19/04/13 12:41, Hurugalawadi, Naveen wrote: Hi, Please find attached the patch that implements Negate with Carry instruction for aarch64 target. Please review the same and let me know if there should be any modifications in the patch. Build and tested on aarch64-thunder-elf (using Cavium's

[PATCH, AArch64] Negate with Compare instruction

2013-04-19 Thread Hurugalawadi, Naveen
Hi, Please find attached the patch that implements Negate with Carry instruction for aarch64 target. Please review the same and let me know if there should be any modifications in the patch. Build and tested on aarch64-thunder-elf (using Cavium's internal simulator). No new regressions. Thanks