Re: [PATCH, AArch64] Testcases for ANDS instruction

2013-05-07 Thread Marcus Shawcroft
On 1 May 2013 10:50, Ian Bolton wrote: > Thanks for the review. I've fixed this up in the attached patch, by > counting the number of matches for the first rule and expecting it to > match additional times to cover the overlap with the lsl based rule. > > I've also renamed the testcases in line w

RE: [PATCH, AArch64] Testcases for ANDS instruction

2013-05-01 Thread Ian Bolton
> From: Richard Earnshaw > This rule > > + /* { dg-final { scan-assembler "and\tw\[0-9\]+, w\[0-9\]+, w\[0- > 9\]+" } } */ > > Will match anything that this rule > > > + /* { dg-final { scan-assembler "and\tw\[0-9\]+, w\[0-9\]+, w\[0- > 9\]+, lsl 3" } } */ > > matches (though not vice versa).

Re: [PATCH, AArch64] Testcases for ANDS instruction

2013-04-26 Thread Richard Earnshaw
On 26/04/13 13:54, Ian Bolton wrote: I made some testcases to go with my implementation of ANDS in the backend, but Naveen Hurugalawadi got the ANDS patterns in before me! I'm now just left with the testcases, but they are still worth adding, so here they are. Tests are working correctly as of

[PATCH, AArch64] Testcases for ANDS instruction

2013-04-26 Thread Ian Bolton
I made some testcases to go with my implementation of ANDS in the backend, but Naveen Hurugalawadi got the ANDS patterns in before me! I'm now just left with the testcases, but they are still worth adding, so here they are. Tests are working correctly as of current trunk. OK to commit? Cheers,