> I thought of that, but thought this was slightly clearer from usage. I'm
> open the default option if you prefer.
No, either is fine as far as I'm concerned.
--
Eric Botcazou
On 10/31/18 5:32 PM, Eric Botcazou wrote:
>> * optabs-libfuncs.c (build_libfunc_function_visibility):
>> New, split out from...
>> (build_libfunc_function): ... here.
>> (init_one_libfunc_visibility): New, split out from ...
>> (init_one_libfunc): ... here.
>
> Either
> * optabs-libfuncs.c (build_libfunc_function_visibility):
> New, split out from...
> (build_libfunc_function): ... here.
> (init_one_libfunc_visibility): New, split out from ...
> (init_one_libfunc): ... here.
Either that or add the parameter with a
Ping for rtl, middle-end, or global reviewers.
r~
On 10/2/18 5:19 PM, Richard Henderson wrote:
> * optabs-libfuncs.c (build_libfunc_function_visibility):
> New, split out from...
> (build_libfunc_function): ... here.
> (init_one_libfunc_visibility): New, split out from
This one needs some other reviewers copied in, who may have missed that
it is not an AARch64 only patch (it looks fine to me).
James
On Tue, Oct 02, 2018 at 11:19:10AM -0500, Richard Henderson wrote:
> * optabs-libfuncs.c (build_libfunc_function_visibility):
> New, split out from...
* optabs-libfuncs.c (build_libfunc_function_visibility):
New, split out from...
(build_libfunc_function): ... here.
(init_one_libfunc_visibility): New, split out from ...
(init_one_libfunc): ... here.
---
gcc/optabs-libfuncs.h | 2 ++
gcc/optabs-libfuncs.c
