RE: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-23 Thread Sudakshina Das
Hi James -Original Message- From: James Greenhalgh Sent: 18 April 2019 09:56 To: Sudakshina Das Cc: Richard Henderson ; H.J. Lu ; Richard Henderson ; gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw ; Marcus Shawcroft ; ni...@redhat.com Subject: Re: [PATCH, GCC, AARCH64] Add GNU note

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-18 Thread James Greenhalgh
On Thu, Apr 04, 2019 at 05:01:06PM +0100, Sudakshina Das wrote: > Hi Richard > > On 03/04/2019 11:28, Richard Henderson wrote: > > On 4/3/19 5:19 PM, Sudakshina Das wrote: > >> + /* PT_NOTE header: namesz, descsz, type. > >> + namesz = 4 ("GNU\0") > >> + descsz = 16 (Size of the program p

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-12 Thread Sudakshina Das
Ping. On 04/04/2019 17:01, Sudakshina Das wrote: > Hi Richard > > On 03/04/2019 11:28, Richard Henderson wrote: >> On 4/3/19 5:19 PM, Sudakshina Das wrote: >>> +  /* PT_NOTE header: namesz, descsz, type. >>> + namesz = 4 ("GNU\0") >>> + descsz = 16 (Size of the program property array)

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-04 Thread Sudakshina Das
Hi Richard On 03/04/2019 11:28, Richard Henderson wrote: > On 4/3/19 5:19 PM, Sudakshina Das wrote: >> + /* PT_NOTE header: namesz, descsz, type. >> + namesz = 4 ("GNU\0") >> + descsz = 16 (Size of the program property array) >> + type = 5 (NT_GNU_PROPERTY_TYPE_0). */ >> +

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-03 Thread Richard Henderson
On 4/3/19 5:19 PM, Sudakshina Das wrote: > + /* PT_NOTE header: namesz, descsz, type. > + namesz = 4 ("GNU\0") > + descsz = 16 (Size of the program property array) > + type = 5 (NT_GNU_PROPERTY_TYPE_0). */ > + assemble_align (POINTER_SIZE); > + assemble_integer (GEN

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-03 Thread Sudakshina Das
Hi Richard On 02/04/2019 10:25, Sudakshina Das wrote: > Hi > > On 02/04/2019 03:27, H.J. Lu wrote: >> On Tue, Apr 2, 2019 at 10:05 AM Richard Henderson >> wrote: >>> >>> On 4/1/19 8:53 PM, Sudakshina Das wrote: > This could stand to use a comment, a moment's thinking about the > sizes,

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-02 Thread Sudakshina Das
Hi On 02/04/2019 03:27, H.J. Lu wrote: > On Tue, Apr 2, 2019 at 10:05 AM Richard Henderson wrote: >> >> On 4/1/19 8:53 PM, Sudakshina Das wrote: This could stand to use a comment, a moment's thinking about the sizes, and to use the existing asm output functions. /*

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-01 Thread H.J. Lu
On Tue, Apr 2, 2019 at 10:05 AM Richard Henderson wrote: > > On 4/1/19 8:53 PM, Sudakshina Das wrote: > >> This could stand to use a comment, a moment's thinking about the sizes, > >> and to > >> use the existing asm output functions. > >> > >> /* PT_NOTE header: namesz, descsz, type. > >>

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-01 Thread Richard Henderson
On 4/1/19 8:53 PM, Sudakshina Das wrote: >> This could stand to use a comment, a moment's thinking about the sizes, and >> to >> use the existing asm output functions. >> >> /* PT_NOTE header: namesz, descsz, type. >> namesz = 4 ("GNU\0") >> descsz = 12 (see below) > I was try

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-01 Thread Sudakshina Das
Hi Richard Thanks for the comments and pointing out the much cleaner existing asm output functions! On 29/03/2019 17:51, Richard Henderson wrote: >> +#define ASM_LONG "\t.long\t" > > Do not replicate targetm.asm_out.aligned_op.si, or integer_asm_op, really. > >> +aarch64_file_end_indicate_exec

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-03-29 Thread Richard Henderson
> +#define ASM_LONG "\t.long\t" Do not replicate targetm.asm_out.aligned_op.si, or integer_asm_op, really. > +aarch64_file_end_indicate_exec_stack () > +{ > + file_end_indicate_exec_stack (); > + > + if (!aarch64_bti_enabled () > + && aarch64_ra_sign_scope == AARCH64_FUNCTION_NONE) > +

[PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-03-29 Thread Sudakshina Das
Hi This patch adds the GNU NOTE section to the BTI and/or PAC enabled objects for linux targets. The ABI document that we published mentioning GNU NOTE section is below: https://developer.arm.com/docs/ihi0056/latest/elf-for-the-arm-64-bit-architecture-aarch64-abi-2018q4 The patches needed for the