Re: [PATCH, GCC] Fix unrolling check.

2019-11-11 Thread Sudakshina Das
On 11/11/2019 14:50, Eric Botcazou wrote: >> Thanks for the explanation. However, I do not understand why are we >> returning with the default value. > > The regression you reported should be clear enough though: if we don't do > that, we will unroll in cases where we would not have before. Try w

Re: [PATCH, GCC] Fix unrolling check.

2019-11-11 Thread Eric Botcazou
> Thanks for the explanation. However, I do not understand why are we > returning with the default value. The regression you reported should be clear enough though: if we don't do that, we will unroll in cases where we would not have before. Try with a compiler that predates the pragma and com

Re: [PATCH, GCC] Fix unrolling check.

2019-11-11 Thread Sudakshina Das
Hi Eric On 08/11/2019 19:16, Eric Botcazou wrote: >> I was fiddling around with the loop unrolling pass and noticed a check >> in decide_unroll_* functions (in the patch). The comment on top of this >> check says >> "/* If we were not asked to unroll this loop, just return back silently. >>*/"

Re: [PATCH, GCC] Fix unrolling check.

2019-11-08 Thread Eric Botcazou
> I was fiddling around with the loop unrolling pass and noticed a check > in decide_unroll_* functions (in the patch). The comment on top of this > check says > "/* If we were not asked to unroll this loop, just return back silently. > */" > However the check returns when loop->unroll == 0 ra

[PATCH, GCC] Fix unrolling check.

2019-11-08 Thread Sudakshina Das
Hi I was fiddling around with the loop unrolling pass and noticed a check in decide_unroll_* functions (in the patch). The comment on top of this check says "/* If we were not asked to unroll this loop, just return back silently. */" However the check returns when loop->unroll == 0 rather tha