Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On Mon, 14 Feb 2022 16:56:35 +0100 Thomas Schwinge wrote: > Hi Julian! > > Two more questions here, in context of > "[12 Regression] ICE in expand_gimple_stmt_1, at cfgexpand.c:3932 > since r12-980-g29a2f51806c": > > On 2019-06-03T17:02:45+0100, Julian Brown >

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

Hi Julian! Two more questions here, in context of "[12 Regression] ICE in expand_gimple_stmt_1, at cfgexpand.c:3932 since r12-980-g29a2f51806c": On 2019-06-03T17:02:45+0100, Julian Brown wrote: > This is a new version of the patch, rebased The code as we've now

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

Hi! On 2019-06-07T15:08:37+0100, Julian Brown wrote: > Hi Jakub, > > Thanks for the review! I believe I've addressed all your comments in > the attached version of the patch. > > On Mon, 3 Jun 2019 18:23:00 +0200 > Jakub Jelinek wrote: >> > +/* Record vars listed in private clauses in CLAUSES

Add 'libgomp.oacc-c-c++-common/loop-gwv-2.c' (was: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory)

Hi! On 2018-08-13T21:41:50+0100, Julian Brown wrote: > On Mon, 13 Aug 2018 11:42:26 -0700 Cesar Philippidis > wrote: >> On 08/13/2018 09:21 AM, Julian Brown wrote: >> > diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c >> >

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

Hi! This is a new patch that takes a different approach to the last-posted version in this thread. I have combined the previous incremental patches on the og9 branch that culminated in the following patch: https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01220.html From that email, the following

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On Wed, 12 Jun 2019 13:57:22 +0200 Thomas Schwinge wrote: > Hi! > > First, thanks for picking this up, and improving the patch you > inherited. Thanks for review! > I understand right that this will address some aspects of PR90115 > "OpenACC: predetermined private levels for variables

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

Hi! First, thanks for picking this up, and improving the patch you inherited. Then, just a few individual comments, not a complete review. (As far as I concerned, and as far as relevant, these can be addressed later, incrementally, of course.) I understand right that this will address some

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On 12-06-19 12:22, Jakub Jelinek wrote: > On Fri, Jun 07, 2019 at 03:08:37PM +0100, Julian Brown wrote: >> diff --git a/gcc/omp-low.c b/gcc/omp-low.c >> index a7f35ffe416..67e1e82ec00 100644 >> --- a/gcc/omp-low.c >> +++ b/gcc/omp-low.c >> @@ -9794,6 +9882,8 @@ lower_omp_target

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On Fri, Jun 07, 2019 at 03:08:37PM +0100, Julian Brown wrote: > diff --git a/gcc/omp-low.c b/gcc/omp-low.c > index a7f35ffe416..67e1e82ec00 100644 > --- a/gcc/omp-low.c > +++ b/gcc/omp-low.c > @@ -9794,6 +9882,8 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, > omp_context *ctx) > >if

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

Hi Jakub, Thanks for the review! I believe I've addressed all your comments in the attached version of the patch. On Mon, 3 Jun 2019 18:23:00 +0200 Jakub Jelinek wrote: > Why vec * rather than vec? > > @@ -878,6 +884,7 @@ new_omp_context (gimple *stmt, omp_context > > *outer_ctx) } > > > >

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On Mon, Jun 03, 2019 at 05:02:45PM +0100, Julian Brown wrote: > * omp-low.c (omp_context): Add oacc_partitioning_level and > oacc_addressable_var_decls fields. > (new_omp_context): Initialize oacc_addressable_var_decls in new > omp_context. >

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

8ba289c5fbcd768b7d4dff785f Mon Sep 17 00:00:00 2001 From: Julian Brown Date: Thu, 9 Aug 2018 20:27:04 -0700 Subject: [PATCH] [OpenACC] Add support for gang local storage allocation in shared memory 2019-06-03 Julian Brown Chung-Lin Tang gcc/ * config/nvptx/nvptx.c (tree-hash-traits.h):

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On Fri, 17 Aug 2018 18:39:00 +0200 Bernhard Reutner-Fischer wrote: > On 16 August 2018 17:46:43 CEST, Julian Brown > wrote: > >On Wed, 15 Aug 2018 21:56:54 +0200 > >Bernhard Reutner-Fischer wrote: > > > >> On 15 August 2018 18:46:37 CEST, Julian Brown > >> wrote: > >> >On Mon, 13 Aug 2018

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On 8/16/18 5:46 PM, Julian Brown wrote: > On Wed, 15 Aug 2018 21:56:54 +0200 > Bernhard Reutner-Fischer wrote: > >> On 15 August 2018 18:46:37 CEST, Julian Brown >> wrote: >>> On Mon, 13 Aug 2018 12:06:21 -0700 >>> Cesar Philippidis wrote: >> >> atttribute has more t than strictly necessary.

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On 16 August 2018 17:46:43 CEST, Julian Brown wrote: >On Wed, 15 Aug 2018 21:56:54 +0200 >Bernhard Reutner-Fischer wrote: > >> On 15 August 2018 18:46:37 CEST, Julian Brown >> wrote: >> >On Mon, 13 Aug 2018 12:06:21 -0700 >> >Cesar Philippidis wrote: >> >> atttribute has more t than

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On Wed, 15 Aug 2018 21:56:54 +0200 Bernhard Reutner-Fischer wrote: > On 15 August 2018 18:46:37 CEST, Julian Brown > wrote: > >On Mon, 13 Aug 2018 12:06:21 -0700 > >Cesar Philippidis wrote: > > atttribute has more t than strictly necessary. > Don't like signed integer levels where they

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On 15 August 2018 18:46:37 CEST, Julian Brown wrote: >On Mon, 13 Aug 2018 12:06:21 -0700 >Cesar Philippidis wrote: atttribute has more t than strictly necessary. Don't like signed integer levels where they should be some unsigned. Also don't like single switch cases instead of if. And

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On Mon, 13 Aug 2018 12:06:21 -0700 Cesar Philippidis wrote: > So in other words, this is safe for fortran. It probably could use a > fortran test, because that functionality wasn't explicitly exercised > in og7/og8. Here's a new version of the patch with a Fortran test case. It's not too easy

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On Mon, 13 Aug 2018 11:42:26 -0700 Cesar Philippidis wrote: > On 08/13/2018 09:21 AM, Julian Brown wrote: > > > diff --git > > a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c > > b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c new file > > mode 100644 index

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On 08/13/2018 11:42 AM, Cesar Philippidis wrote: > On 08/13/2018 09:21 AM, Julian Brown wrote: > >> diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c >> b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c >> new file mode 100644 >> index 000..2fa708a >> ---

Re: [PATCH, OpenACC] Add support for gang local storage allocation in shared memory

On 08/13/2018 09:21 AM, Julian Brown wrote: > diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c > b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-gwv-2.c > new file mode 100644 > index 000..2fa708a > --- /dev/null > +++

[PATCH, OpenACC] Add support for gang local storage allocation in shared memory

This patch adds support for placing gang-private variables in NVPTX per-CU shared memory. This is done by marking up addressable variables declared at the appropriate parallelism level with an attribute ("oacc gangprivate") in omp-low.c. Target-dependent code in the NVPTX backend then modifies