I committed this as revision 205090 on behalf of Joshua.
Cheers,
Manuel.
On 15 November 2013 05:15, Joshua J Cogliati wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> The patch is the same as before (but for newer revision 204343 so line
> numbers are a bit different), but the copyr
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
The patch is the same as before (but for newer revision 204343 so line
numbers are a bit different), but the copyright assignment has been
sorted out and the changelog has been modified as discussed by Dodji
Seketeli. I think it is ready to be applied
/13, Dodji Seketeli wrote:
Subject: Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for
floating point conversion
To: "Joshua J Cogliati"
Cc: "Joseph S. Myers" , gcc-patches@gcc.gnu.org,
ja...@redhat.com, m...@gcc.gnu.org
Date: Tuesday, November 5, 2013, 5:1
Sorry for my late reply on this.
I just have one very small nit for one ChangeLog entry, expressed
below. If nobody objects in the next 48 hours, I'd say this is OK to
commit with the nit fixed.
I am not seeing your name in the MAINTAINERS file. Have you filed
copyright assignment to the FSF an
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Since part of it was to go into c-family (as per Joseph S. Myers's
email) and parts are not in c-family, I split the changelog into three
parts. I also changed the formatting of the changelog and patch as
per Dodji's comments. The attached patch is t
"Joseph S. Myers" writes:
> On Mon, 28 Oct 2013, Dodji Seketeli wrote:
>
>> * c-family/c-common.c (unsafe_conversion_p): Make this function
>
> As previously noted, c-family/ has its own ChangeLog, so the c-family/
> part does not go in the ChangeLog entry.
Agreed. I missed this.
--
On Mon, 28 Oct 2013, Dodji Seketeli wrote:
> * c-family/c-common.c (unsafe_conversion_p): Make this function
As previously noted, c-family/ has its own ChangeLog, so the c-family/
part does not go in the ChangeLog entry.
--
Joseph S. Myers
jos...@codesourcery.com
Hello Joshua,
Joshua J Cogliati writes:
> I am not certain that c.opt was modified correctly.
I don't see any problem with the c.opt part. So unless another
maintainer says otherwise, I'd say this is OK.
> 1. warn_float_patch_and_new_testcase.diff
> This adds a new testcase and checks for flo
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
== Administrivia ==
This is my first patch. I have emailed in the signed copyright transfer
documents already. Several versions of this patch have been sent to
the mailing list already. I believe that I have incorporated all
comments into the attac
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Only one of these should be applied. The
warn_float_patch_simple_trunk.diff just changes formatting from the
previous version. The warn_float_patch_and_new_testcase.diff leaves
existing testcases alone, and adds a new one that tests
- -Wfloat-convers
On Fri, 18 Oct 2013, Joshua J Cogliati wrote:
> This patch does not change any of the non-commented c and c++ code.
> It changes the dg comments.
> Example:
> - fsi (3.1f); /* { dg-warning "conversion" } */
> + fsi (3.1f); /* { dg-warning "float-conversion" } */
>
> If you want I can change it
On 10/14/2013 05:34 PM, Joseph S. Myers wrote:
> On Mon, 14 Oct 2013, Dodji Seketeli wrote:
>
>>> This patch has passes the existing -Wconversion testcases. It
>>> modifies Wconversion-real.c, Wconversion-real-integer.c and
>>> pr35635.c to be more specific
>>
>> If the patch passes existing tes
Attached is a patch that addresses most of Dodji Seketeli's comments.
Explanations for the rest are inline.
On 10/14/2013 03:04 AM, Dodji Seketeli wrote:
> Thank you Joshua for following up on this. Please find below some
> comments of mine that mostly belong to the nitpicking department.
You ar
On Mon, 14 Oct 2013, Dodji Seketeli wrote:
> > This patch has passes the existing -Wconversion testcases. It modifies
> > Wconversion-real.c, Wconversion-real-integer.c and pr35635.c to be more
> > specific
>
> If the patch passes existing tests, I'd be inclined to leave them
> tests alone and a
Thank you Joshua for following up on this. Please find below some
comments of mine that mostly belong to the nitpicking department.
Joshua J Cogliati writes:
[...]
> A split out patch to make the floating conversions explicit is attached
> at the PR 53001 page, but is not included in this patc
Changes compared to previous version of patch:
This patch only includes -Wfloat-conversion in -Wconversion, it does not
include it in -Wextra
It also changes several testcases to use -Wfloat-conversion instead of
-Wconversion
A split out patch to make the floating conversions explicit is attached
a
16 matches
Mail list logo
